dohertj2 dohertj2
  • Joined on 2026-02-20
dohertj2 closed issue dohertj2/lmxopcua#573 2026-10-08 01:53:52 -04:00
Flaky AbLegacyReadWriteTests (~1 in 15 runs, pre-existing)
dohertj2 commented on issue dohertj2/lmxopcua#574 2026-10-08 01:53:52 -04:00
AbCip: ParseEnum transport error wording + probe test positive assertion

Fixed: PlcFamily ParseEnum wording (Transport was already correct); probe tests positively assert libplctag's timeout text (later made load-tolerant in 277cd6ee). (merge 7105ef3e on master,…

dohertj2 closed issue dohertj2/lmxopcua#574 2026-10-08 01:53:52 -04:00
AbCip: ParseEnum transport error wording + probe test positive assertion
dohertj2 closed issue dohertj2/lmxopcua#570 2026-10-08 01:53:51 -04:00
Native AbCip runtime: STRING capacity, mistype churn, malformed-name device backoff
dohertj2 commented on issue dohertj2/lmxopcua#572 2026-10-08 01:53:51 -04:00
Native AbCip browse: per-call template connections, instance-order assumption, unpaced listing

Fixed: paging continues from max(instance seen)+1 with a no-progress guard; a browse's template reads share one lease (CreateBatch); listing pages paced by browsePageDelayMs (default 5 ms).…

dohertj2 closed issue dohertj2/lmxopcua#572 2026-10-08 01:53:51 -04:00
Native AbCip browse: per-call template connections, instance-order assumption, unpaced listing
dohertj2 commented on issue dohertj2/lmxopcua#573 2026-10-08 01:53:51 -04:00
Flaky AbLegacyReadWriteTests (~1 in 15 runs, pre-existing)

Fixed: test defect — FakeAbLegacyTagFactory.Tags was a plain Dictionary written concurrently by the probe loop; now ConcurrentDictionary. 1/120 before, 0/150 after. (merge 007174d2 on master,…

dohertj2 commented on issue dohertj2/lmxopcua#569 2026-10-08 01:53:50 -04:00
LibplctagConfinementGuard misses refs after // in literals, block comments, csproj

Fixed: tokenising stripper (regular/verbatim/interpolated/raw strings, char literals, // and /* */ comments) and a csproj PackageReference guard limiting libplctag to the AbCip/AbLegacy projects.…

dohertj2 closed issue dohertj2/lmxopcua#569 2026-10-08 01:53:50 -04:00
LibplctagConfinementGuard misses refs after // in literals, block comments, csproj
dohertj2 commented on issue dohertj2/lmxopcua#570 2026-10-08 01:53:50 -04:00
Native AbCip runtime: STRING capacity, mistype churn, malformed-name device backoff

Fixed: STRING capacity 82; existence-read type refusal no longer churns runtime/connection; malformed tag names → per-tag BadConfigurationError without device backoff or health change; 0xD1/0xD2/0…

dohertj2 commented on issue dohertj2/lmxopcua#568 2026-10-08 01:53:49 -04:00
AbCip/AbLegacy: libplctag adapter status-mapping and WrapSync test gaps

Fixed: ToAbStatus round-trip-tested over every Status; dead AbLegacy MapException removed (AbCip's has callers); WrapSync/Wrap OperationCanceledException pass-through and native-Tag decode-routing…

dohertj2 closed issue dohertj2/lmxopcua#568 2026-10-08 01:53:49 -04:00
AbCip/AbLegacy: libplctag adapter status-mapping and WrapSync test gaps
dohertj2 commented on issue dohertj2/lmxopcua#567 2026-10-08 01:53:48 -04:00
Ab.Transport: RequestScheduler fragment/lock follow-ups

Fixed: private lock object; struct handle compared across Read Tag Fragmented fragments (mismatch fails BadReply). Residual: wide-struct fragmented WRITE unproven on a real controller (presses are…

dohertj2 closed issue dohertj2/lmxopcua#567 2026-10-08 01:53:48 -04:00
Ab.Transport: RequestScheduler fragment/lock follow-ups
dohertj2 commented on issue dohertj2/lmxopcua#566 2026-10-08 01:53:47 -04:00
Ab.Transport: CipConnection/DeviceSessionPool test gaps and CIP-level close detection

Fixed: tests for scheduler-dispose-throws, dispose-during-connect, abandoned-open observer; lease-release-behind-open resolved by #579 (ReleaseInBackground) with a test; CIP-level close (0x01/0x010…

dohertj2 closed issue dohertj2/lmxopcua#566 2026-10-08 01:53:47 -04:00
Ab.Transport: CipConnection/DeviceSessionPool test gaps and CIP-level close detection
dohertj2 commented on issue dohertj2/lmxopcua#565 2026-10-08 01:53:46 -04:00
Ab.Transport: EncapsulationClient drain/timeout/test follow-ups

Fixed: writes awaited under the exchange timeout and fault (tear down) the client on expiry — never cancelled mid-frame; non-finite/non-positive timeouts rejected at every entry point; gate wait…

dohertj2 closed issue dohertj2/lmxopcua#565 2026-10-08 01:53:46 -04:00
Ab.Transport: EncapsulationClient drain/timeout/test follow-ups
dohertj2 commented on issue dohertj2/lmxopcua#564 2026-10-08 01:53:45 -04:00
Ab.Transport: CIP codec hardening (bounds, path casts, immutable constants)

Fixed all items: PatchU16 bounds guard, content-equal CipReply, FromCip(0xFF, empty) test, CipPath port/length/ASCII/odd-size validation, malformed tag names → ArgumentException, MessageRouter/Con…

dohertj2 closed issue dohertj2/lmxopcua#564 2026-10-08 01:53:45 -04:00
Ab.Transport: CIP codec hardening (bounds, path casts, immutable constants)