dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

LibplctagConfinementGuard misses refs after // in literals, block comments, csproj #569

New Issue
Closed
opened 2026-10-07 19:02:14 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-07 19:02:14 -04:00
Owner
Copy Link
Copy Source

Context: native .NET Allen-Bradley transport work (plan docs/plans/2026-10-07-native-ab-transport.md, branch feat/native-ab-transport, not yet merged). Parked as a Minor during per-task review — none of these block the plan.

LibplctagConfinementGuardTests (Ab.Transport.Tests) gaps:

  • Split("//") truncates lines inside string literals containing // (e.g. URLs) — a reference after such a literal is missed.
  • /* */ block comments are not stripped.
  • .csproj PackageReference to libplctag is not guarded — relevant when the libplctag package is finally removed.
Context: native .NET Allen-Bradley transport work (plan `docs/plans/2026-10-07-native-ab-transport.md`, branch `feat/native-ab-transport`, not yet merged). Parked as a Minor during per-task review — none of these block the plan. `LibplctagConfinementGuardTests` (Ab.Transport.Tests) gaps: - [ ] `Split("//")` truncates lines inside string literals containing `//` (e.g. URLs) — a reference after such a literal is missed. - [ ] `/* */` block comments are not stripped. - [ ] `.csproj` `PackageReference` to libplctag is not guarded — relevant when the libplctag package is finally removed.
dohertj2 added the driver/abcipdriver/ablegacy labels 2026-10-07 19:02:14 -04:00
dohertj2 commented 2026-10-08 01:53:50 -04:00
Author
Owner
Copy Link
Copy Source

Fixed: tokenising stripper (regular/verbatim/interpolated/raw strings, char literals, // and /* */ comments) and a csproj PackageReference guard limiting libplctag to the AbCip/AbLegacy projects. (merge 29cd25de on master, pushed 2026-10-08)

Fixed: tokenising stripper (regular/verbatim/interpolated/raw strings, char literals, // and /* */ comments) and a csproj PackageReference guard limiting libplctag to the AbCip/AbLegacy projects. (merge `29cd25de` on master, pushed 2026-10-08)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label driver/abcip driver/ablegacy
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#569
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?