Ab.Transport: RequestScheduler fragment/lock follow-ups #567

New Issue

2026-10-07T19:02:13-04:00

dohertj2 commented

2026-10-07 19:02:13 -04:00

Context: native .NET Allen-Bradley transport work (plan docs/plans/2026-10-07-native-ab-transport.md, branch feat/native-ab-transport, not yet merged). Parked as a Minor during per-task review — none of these block the plan.

RequestScheduler (MSP coalescing + fragmented reads/writes) follow-ups:

Wide-struct fragmented write with 8-byte alignment is unit-tested only — never proven against a real controller.
Uses lock(this) on the private Pending type — switch to a private lock object.
The struct handle is not compared across Read Tag Fragmented reply fragments (a mid-read type change would be stitched silently).

Context: native .NET Allen-Bradley transport work (plan `docs/plans/2026-10-07-native-ab-transport.md`, branch `feat/native-ab-transport`, not yet merged). Parked as a Minor during per-task review — none of these block the plan. `RequestScheduler` (MSP coalescing + fragmented reads/writes) follow-ups: - [ ] Wide-struct fragmented **write** with 8-byte alignment is unit-tested only — never proven against a real controller. - [ ] Uses `lock(this)` on the private `Pending` type — switch to a private lock object. - [ ] The struct handle is not compared across Read Tag Fragmented reply fragments (a mid-read type change would be stitched silently).

dohertj2 added the driver/abcip label 2026-10-07 19:02:13 -04:00

dohertj2 referenced this issue from a commit

2026-10-08 01:53:39 -04:00

fix(abcip): budget expected reply size in RequestScheduler.TakeBatch (#582); private lock + struct-handle check across read fragments (#567)

dohertj2 commented

2026-10-08 01:53:48 -04:00

Fixed: private lock object; struct handle compared across Read Tag Fragmented fragments (mismatch fails BadReply). Residual: wide-struct fragmented WRITE unproven on a real controller (presses are read-only, no bench controller) — recorded in docs/drivers/AbCip.md. (merge bd2bebed on master, pushed 2026-10-08)

Fixed: private lock object; struct handle compared across Read Tag Fragmented fragments (mismatch fails BadReply). Residual: wide-struct fragmented WRITE unproven on a real controller (presses are read-only, no bench controller) — recorded in docs/drivers/AbCip.md. (merge `bd2bebed` on master, pushed 2026-10-08)

dohertj2 closed this issue

2026-10-08 01:53:48 -04:00

dohertj2 referenced this issue

2026-10-08 02:31:08 -04:00

Native AB transport: bench-controller proof of writes + PCCC, then decide libplctag deletion #592

dohertj2 referenced this issue

2026-10-09 04:55:26 -04:00

Native AB transport: bench-controller proof of writes + PCCC, then decide libplctag deletion #592

dohertj2 referenced this issue from a commit

2026-10-09 07:19:56 -04:00

test(abcip): hw5 hardware gate — #566 idle close drops TCP; native STRING write on Z-35162 (#592)

dohertj2 referenced this issue