dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Flaky AbLegacyReadWriteTests (~1 in 15 runs, pre-existing) #573

New Issue
Closed
opened 2026-10-07 19:02:15 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-07 19:02:15 -04:00
Owner
Copy Link
Copy Source

Pre-existing flake (not introduced by the native-transport work; reproduced at the base commit too):

AbLegacyReadWriteTests in tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.AbLegacy.Tests fails roughly 1 run in 15 (2/40 at the pre-change base). Found during review of the native AB transport plan (branch feat/native-ab-transport).

  • Reproduce with a repeat loop + trx, identify the racing assertion (likely presence-vs-absence or timing), fix deterministically.
Pre-existing flake (not introduced by the native-transport work; reproduced at the base commit too): `AbLegacyReadWriteTests` in `tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.AbLegacy.Tests` fails roughly 1 run in 15 (2/40 at the pre-change base). Found during review of the native AB transport plan (branch `feat/native-ab-transport`). - [ ] Reproduce with a repeat loop + trx, identify the racing assertion (likely presence-vs-absence or timing), fix deterministically.
dohertj2 added the driver/ablegacy label 2026-10-07 19:02:15 -04:00
dohertj2 commented 2026-10-08 01:53:51 -04:00
Author
Owner
Copy Link
Copy Source

Fixed: test defect — FakeAbLegacyTagFactory.Tags was a plain Dictionary written concurrently by the probe loop; now ConcurrentDictionary. 1/120 before, 0/150 after. (merge 007174d2 on master, pushed 2026-10-08)

Fixed: test defect — FakeAbLegacyTagFactory.Tags was a plain Dictionary written concurrently by the probe loop; now ConcurrentDictionary. 1/120 before, 0/150 after. (merge `007174d2` on master, pushed 2026-10-08)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label driver/ablegacy
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#573
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?