dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Ab.Transport: CIP codec hardening (bounds, path casts, immutable constants) #564

New Issue
Closed
opened 2026-10-07 19:02:12 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-07 19:02:12 -04:00
Owner
Copy Link
Copy Source

Context: native .NET Allen-Bradley transport work (plan docs/plans/2026-10-07-native-ab-transport.md, branch feat/native-ab-transport, not yet merged). Parked as a Minor during per-task review — none of these block the plan.

Hardening items in the Ab.Transport CIP codec layer (src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Ab.Transport/Cip, Wire):

  • CipWriter.PatchU16 has no bounds guard.
  • CipReply.ExtendedStatus uses array reference equality (record equality over byte[]).
  • FromCip(0xFF, empty) mapping is untested.
  • CipPath: unchecked length/port casts; WithPathSize does not reject odd/oversize paths.
  • Malformed tag-name exceptions are not ArgumentException.
  • MessageRouter / ConnectionManager expose public mutable byte[] constants — make them ReadOnlySpan<byte>/ImmutableArray.
  • Refused Forward Open statuses surface only in the exception message, not as structured data.
  • Test-only CaptureFile still uses BitConverter (endianness-implicit).
Context: native .NET Allen-Bradley transport work (plan `docs/plans/2026-10-07-native-ab-transport.md`, branch `feat/native-ab-transport`, not yet merged). Parked as a Minor during per-task review — none of these block the plan. Hardening items in the `Ab.Transport` CIP codec layer (`src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Ab.Transport/Cip`, `Wire`): - [ ] `CipWriter.PatchU16` has no bounds guard. - [ ] `CipReply.ExtendedStatus` uses array reference equality (record equality over `byte[]`). - [ ] `FromCip(0xFF, empty)` mapping is untested. - [ ] `CipPath`: unchecked length/port casts; `WithPathSize` does not reject odd/oversize paths. - [ ] Malformed tag-name exceptions are not `ArgumentException`. - [ ] `MessageRouter` / `ConnectionManager` expose public mutable `byte[]` constants — make them `ReadOnlySpan<byte>`/`ImmutableArray`. - [ ] Refused Forward Open statuses surface only in the exception message, not as structured data. - [ ] Test-only `CaptureFile` still uses `BitConverter` (endianness-implicit).
dohertj2 added the driver/abcipdriver/ablegacy labels 2026-10-07 19:02:12 -04:00
dohertj2 commented 2026-10-08 01:53:45 -04:00
Author
Owner
Copy Link
Copy Source

Fixed all items: PatchU16 bounds guard, content-equal CipReply, FromCip(0xFF, empty) test, CipPath port/length/ASCII/odd-size validation, malformed tag names → ArgumentException, MessageRouter/ConnectionManager as ReadOnlySpan, ForwardOpenRefusedException with structured General/Extended status, CaptureFile on BinaryPrimitives. (merge 13a67270 on master, pushed 2026-10-08)

Fixed all items: PatchU16 bounds guard, content-equal CipReply, FromCip(0xFF, empty) test, CipPath port/length/ASCII/odd-size validation, malformed tag names → ArgumentException, MessageRouter/ConnectionManager as ReadOnlySpan<byte>, ForwardOpenRefusedException with structured General/Extended status, CaptureFile on BinaryPrimitives. (merge `13a67270` on master, pushed 2026-10-08)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label driver/abcip driver/ablegacy
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#564
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?