CI TRX skip summary reports zero for skipped results #712

Closed
opened 2026-10-13 10:57:26 -04:00 by dohertj2 · 5 comments
Owner

Current implementation update (2026-10-13): PR #714 at 468f13cb56 counts namespace-aware individual NotExecuted results while preserving the executed-test floor. Its 11 deterministic guard fixtures passed in hosted run #979; restore/build also passed. The required whole-solution test step is still active. Merge and closure await the full run, floor and artifact upload. The original audit below is historical context.

The CI assertion script reports zero skips when current VSTest TRX summaries leave Counters.notExecuted at zero despite skipped UnitTestResult entries.

Evidence: complete #711 local coverage has 62 TRX files, total15,203/executed14,631. Individual results contain14,631 Passed and572 NotExecuted; floor log says skipped=0. Runtime alone has total830/executed827 and3 NotExecuted entries. An all-skipped assembly has188 NotExecuted entries but summarynotExecuted0.

The executed>=12,000 gate remains correct for these artifacts; this is misleading diagnostic accounting, not an established gate bypass. Preserve the executed floor and count namespace-aware individual NotExecuted outcomes for reporting. Add mixed/all-skipped/zero-test fixture coverage. No production or livecalls needed. Read-only audit retained; no implementation yet.

Current implementation update (2026-10-13): PR #714 at 468f13cb5640b0275ef93cab4b16e8ce4b338e2c counts namespace-aware individual NotExecuted results while preserving the executed-test floor. Its 11 deterministic guard fixtures passed in hosted run #979; restore/build also passed. The required whole-solution test step is still active. Merge and closure await the full run, floor and artifact upload. The original audit below is historical context. The CI assertion script reports zero skips when current VSTest TRX summaries leave Counters.notExecuted at zero despite skipped UnitTestResult entries. Evidence: complete #711 local coverage has 62 TRX files, total15,203/executed14,631. Individual results contain14,631 Passed and572 NotExecuted; floor log says skipped=0. Runtime alone has total830/executed827 and3 NotExecuted entries. An all-skipped assembly has188 NotExecuted entries but summarynotExecuted0. The executed>=12,000 gate remains correct for these artifacts; this is misleading diagnostic accounting, not an established gate bypass. Preserve the executed floor and count namespace-aware individual NotExecuted outcomes for reporting. Add mixed/all-skipped/zero-test fixture coverage. No production or livecalls needed. Read-only audit retained; no implementation yet.
Author
Owner

Approved diagnostics fix is implemented and independently reviewed, local commit eecf301200. Eleven deterministic fixture checks pass (original script fails six diagnostic assertions); existing62TRX artifacts now report14,631 executed/572 skipped and retain floor12000. Executed comparison and existing malformed/missing-file statuses preserved. CI fixture step added. Publication waits for dependency PR #711 to merge so this issue’s PR contains only the four-file diagnostics change. No solution rerun or live calls for #712.

Approved diagnostics fix is implemented and independently reviewed, local commit eecf3012003bb08086898efcbb100d8c35379fc0. Eleven deterministic fixture checks pass (original script fails six diagnostic assertions); existing62TRX artifacts now report14,631 executed/572 skipped and retain floor12000. Executed comparison and existing malformed/missing-file statuses preserved. CI fixture step added. Publication waits for dependency PR #711 to merge so this issue’s PR contains only the four-file diagnostics change. No solution rerun or live calls for #712.
Author
Owner

Reviewed #712 commit eecf301200 is pushed on fix/trx-skip-reporting. Its PR will open after dependency #711 merges, keeping the review diff limited to this four-file diagnostics fix. Local fixtures11/11 pass; no full-solution rerun or live calls. #711 hosted run975 is currently executing ControlPlane after preceding suites passed.

Reviewed #712 commit eecf3012003bb08086898efcbb100d8c35379fc0 is pushed on fix/trx-skip-reporting. Its PR will open after dependency #711 merges, keeping the review diff limited to this four-file diagnostics fix. Local fixtures11/11 pass; no full-solution rerun or live calls. #711 hosted run975 is currently executing ControlPlane after preceding suites passed.
Author
Owner

Reviewed fix published as stacked draft PR #714, temporarily targeting PR #711’s source branch to keep the diff focused. It will be retargeted to master after #711 passes and merges. No merge into the temporary base will be performed. Existing validation evidence remains recorded above; issue stays open until the verified fix is merged.

Reviewed fix published as stacked draft PR #714, temporarily targeting PR #711’s source branch to keep the diff focused. It will be retargeted to master after #711 passes and merges. No merge into the temporary base will be performed. Existing validation evidence remains recorded above; issue stays open until the verified fix is merged.
Author
Owner

PR #714 now targets master at 468f13cb56. All 11 deterministic script fixtures passed again, and review found no actionable defects. Run 979 is queued behind the active master run under repository concurrency. No retry, cancellation or floor/assertion weakening. Awaiting hosted CI before merge and closure.

PR #714 now targets master at 468f13cb5640b0275ef93cab4b16e8ce4b338e2c. All 11 deterministic script fixtures passed again, and review found no actionable defects. [Run 979](https://gitea.dohertylan.com/dohertj2/lmxopcua/actions/runs/979) is queued behind the active master run under repository concurrency. No retry, cancellation or floor/assertion weakening. Awaiting hosted CI before merge and closure.
Author
Owner

Resolved by PR #714, merged as 4f7a07fbd3. Required hosted run #979 succeeded at exact head 468f13cb56: all restore/build/drift/11 guard fixtures/whole-solution tests/floor/upload steps passed. The floor counted 62 TRX files, 14,630 executed tests (minimum 12,000) and 573 individual skips. Merged tree 2502d88b02 equals the tested tree.

The diagnostic now counts namespace-aware individual NotExecuted results and preserves the existing executed-floor policy. Mixed/all-skipped/zero/malformed and boundary fixtures passed. No production change or live calls.

Resolved by PR #714, merged as 4f7a07fbd358b18cf441eba5ce80721f775babc4. Required hosted run #979 succeeded at exact head 468f13cb5640b0275ef93cab4b16e8ce4b338e2c: all restore/build/drift/11 guard fixtures/whole-solution tests/floor/upload steps passed. The floor counted 62 TRX files, 14,630 executed tests (minimum 12,000) and 573 individual skips. Merged tree 2502d88b0239c257600fedd53ca01746150e75bc equals the tested tree. The diagnostic now counts namespace-aware individual NotExecuted results and preserves the existing executed-floor policy. Mixed/all-skipped/zero/malformed and boundary fixtures passed. No production change or live calls.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#712