Engineering system: CI evidence, global.json, regen-readme check, SlowUnit split (archreview r3 item 12) #606
Assignees
dohertj2 (dohertj2)
Clear assignees
dohertj2 (dohertj2)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: dohertj2/lmxopcua#606
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Resolved verification (2026-10-13): PR #714 is merged as
4f7a07fbd3. scripts/ci/README.md now records green run #975 (14,630 executed tests/62 reports) and the 12,000 floor. Required run #979 passed the full gate for #714 itself, including all tests, floor and artifact upload; merged tree equals its tested tree. All original checklist items are satisfied. Historical updates are preserved below.Current verification update (2026-10-13): hosted run 975 at
76bdca90e9passed the complete gate with 62 TRX reports and 14,630 executed tests (floor 12,000), including artifact upload. PR #711 is merged. A precise repository evidence record is prepared in PR #714 at 468f13cb5640b0275ef93cab4b16e8ce4b338e2c; its required run 979 is active. The first checkbox remains open until that evidence record is merged after its own required CI passes. Master run 977 also passed independently. The older source-proof paragraph below is historical context, not a current claim that no green run exists.Sources: archreview/00-OVERALL.md:123; no
global.jsonat the repo root.MIN_EXECUTEDregen-readme.py --checkCategory=SlowUnit(~45 s of real-time socket windows in one MQTT suite, 07/P-6)global.jsonFiled 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep.
Current source proof (2026-10-13): all 64 src projects explicitly set TreatWarningsAsErrors=true; global.json pins 10.0.100 with latestFeature; README drift is CI-gated; 16 MQTT cases retain the SlowUnit category; the executed-test floor is 12,000. SlowUnit remains included in the main offline unit gate. Green hosted CI remains outstanding and is being verified through #707/#709/#710.
Partial on master; left open.
b007d450, merge5a5f9b22).7aa77588, merge792510c0). OTOPCUA0001 is also an error under src/ (#595)..github/workflows/v2-ci.yml(there is no.gitea/workflow) and its MIN_EXECUTED is still 1; this needs a Gitea Actions runner run, which this sweep cannot produce.regen-readme.py --check: not done.scripts/check-code-reviews-readme.ps1exists but is not wired into any workflow.Progress 2026-10-08 by the hardware-available issue sweep (master
d898262c); left open for the remaining items.Landed on master (small batch merge
baf8cc48): regen-readme.py --check added to the CI build job (839f3291); 16 slow Driver.Mqtt tests tagged Category=SlowUnit (ad108f6a). Remaining: a green Gitea CI run and raising MIN_EXECUTED need a CI runner. Leaving open.Batch b647 (
55ae230f+beccfc64, merged46b4ab69, pushede7dd7425):upload-artifact@v4→@v3+ continue-on-error (Gitea's runner reports GHES, which v4 refuses, so that step failed every run); runner CPU/mem printed;AKKA_TEST_TIMEFACTOR=3on the test step. 33 distinct CI-failing tests from runs 900–910 made deterministic, several with real causes: abandoned infinite-loop timeout scripts pinned a core for the rest of the process; a wait returned on the initial state; a reconnect test read the wrong driver instance; a control ack was dropped before the driver connected; a 60 s refresh outside a 20 s wait. No assertion removed, nothing skipped; starved stress runs 5/20 → 0/20. Next: confirm the first green Gitea run one7dd7425, then raise MIN_EXECUTED to 12000.Handing CI follow-up to the owner. State as of master
ca17d2cf: run 911 (e7dd7425) failed on 3 load races, fixed inf594b29a(FOCAS quality-only events vs PauseAsync, Modbus connect-timeout vs RST, S7 fixed sleep); run 912 (ec375538) passed those but failedSdkServiceLevelPublisherTestson a free-port TOCTOU — fixed for all 45 OPC UA test-host start sites viaOpcUaHostStart.StartAsyncretry (f02067d2).MIN_EXECUTEDraised to 12000 in the unit job (d83e8f21; run 911 executed 12,991). No green run on the pushed head has been observed yet.Source engineering work is present: pinned global.json10.0.100/latestFeature; all64src projects warnings-as-errors; README drift gate;16MQTT SlowUnit tags;MIN_EXECUTED12000. Current master run952 passed build/README/artifact/minimum floor (14630>=12000) but unit job3544 had18 failures. Specific failures and resource/fixture investigation are tracked in #707. Therefore #606 green-CI acceptance is not yet met. No tests/assertions or CI floor weakened.
Hosted CI is now verified: run 975 succeeded on
76bdca90and PR #711 merged with an identical tree. The executed gate counted 14,630 tests across 62 reports against floor 12,000. The required in-repository record is included in PR #714, currently awaiting CI run 979. This issue remains open until that record is merged.Resolved by PR #714, merged as
4f7a07fbd3. Required hosted run #979 succeeded at exact head468f13cb56: all restore/build/drift/11 guard fixtures/whole-solution tests/floor/upload steps passed. The floor counted 62 TRX files, 14,630 executed tests (minimum 12,000) and 573 individual skips. Merged tree2502d88b02equals the tested tree.The diagnostic now counts namespace-aware individual NotExecuted results and preserves the existing executed-floor policy. Mixed/all-skipped/zero/malformed and boundary fixtures passed. No production change or live calls.
Engineering-gate evidence is now merged in scripts/ci/README.md. Source verification already recorded: global.json pinned, README drift CI-gated, SlowUnit retained in the full offline gate, and all 64 source projects explicitly set TreatWarningsAsErrors. All original checklist items checked; closing #606.