CI: ratchet build warnings to errors now that the solution builds with 0 warnings (#725) #766

New Issue

2026-11-09T13:30:06-05:00

dohertj2 commented

2026-11-09 13:30:06 -05:00

Since #725 the CI Release build of ZB.MOM.WW.OtOpcUa.slnx has 0 warnings. Add the ratchet the issue's last acceptance item asked for (e.g. TreatWarningsAsErrors for test projects, or -warnaserror in the CI build step) and update the stale comment in Directory.Build.props that says test projects aren't clean. Also review the xUnit1051 code-fix sites where WriteAsync(..., default) became the runner token, in case a test relied on ignoring runner cancellation.

Since #725 the CI Release build of ZB.MOM.WW.OtOpcUa.slnx has 0 warnings. Add the ratchet the issue's last acceptance item asked for (e.g. `TreatWarningsAsErrors` for test projects, or `-warnaserror` in the CI build step) and update the stale comment in Directory.Build.props that says test projects aren't clean. Also review the xUnit1051 code-fix sites where `WriteAsync(..., default)` became the runner token, in case a test relied on ignoring runner cancellation.

dohertj2 added the type:infra priority:p3 labels 2026-11-09 13:30:06 -05:00

dohertj2 commented

2026-11-09 13:35:06 -05:00

Fixed on master c904472a: TreatWarningsAsErrors=true set globally in Directory.Build.props (the 61 src/ projects already set it per project since #606 — now extended to tests; stale comment rewritten); applies to CI too, so v2-ci.yml unchanged. Evidence: dotnet build ZB.MOM.WW.OtOpcUa.slnx -c Release -m:2 --no-incremental 0 warnings / 0 errors, Debug clean; a planted unused local in a test project fails the build (CS0219). xUnit1051 code-fix review: the WriteAsync(..., default)→runner-token sites (MqttDriverWriteTests) and Task.Run(..., token) sites don't run cleanup/shutdown under the token or rely on ignoring cancellation — no further changes.

Fixed on master c904472a: `TreatWarningsAsErrors=true` set globally in Directory.Build.props (the 61 src/ projects already set it per project since #606 — now extended to tests; stale comment rewritten); applies to CI too, so v2-ci.yml unchanged. Evidence: `dotnet build ZB.MOM.WW.OtOpcUa.slnx -c Release -m:2 --no-incremental` 0 warnings / 0 errors, Debug clean; a planted unused local in a test project fails the build (CS0219). xUnit1051 code-fix review: the WriteAsync(..., default)→runner-token sites (MqttDriverWriteTests) and Task.Run(..., token) sites don't run cleanup/shutdown under the token or rely on ignoring cancellation — no further changes.

dohertj2 closed this issue

2026-11-09 13:35:06 -05:00

dohertj2 referenced this issue

2026-11-09 13:35:07 -05:00

AbLegacy: route health timestamps through the injectable Clock; drop redundant per-project TreatWarningsAsErrors #768

dohertj2 referenced this issue from a commit

2026-11-09 14:03:59 -05:00

fix(ablegacy): stamp health from the injectable Clock; drop the redundant per-project TreatWarningsAsErrors (lmxopcua#768)

dohertj2 referenced this issue

2026-11-09 14:09:23 -05:00

Security: per-remote-endpoint pre-auth API-key miss budget (widen IOpcUaUserAuthenticator seam) #751

Sign in to join this conversation.