1659 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Joseph Doherty	c03361de1b	test(drivers): extract shared stub-driver harness (de-dup)	2026-06-14 22:49:26 -04:00
Joseph Doherty	d8129e5ab7	test(alarms): fix reconnect-drop test to use mailbox-ordering approach	2026-06-14 22:48:36 -04:00
Joseph Doherty	49d98cba31	docs(alarms): note native-alarm severity-bucket snapping	2026-06-14 22:41:57 -04:00
Joseph Doherty	51cda2c744	test(alarms): assert OperatorComment flows through ForwardNativeAlarm	2026-06-14 22:41:43 -04:00
Joseph Doherty	c8db5767ea	test(alarms): guard native-alarm-during-reconnect is dropped not dead-lettered	2026-06-14 22:41:08 -04:00
Joseph Doherty	a1d333869e	docs(plans): residual-followups-cleanup plan (4 offline items; reconcile stale residuals)	2026-06-14 22:38:42 -04:00
Joseph Doherty	cd20c3c064	docs: refresh pending.md for compaction (Phase C shipped; open-items digest)	2026-06-14 22:23:58 -04:00
Joseph Doherty	c24abc8a97	docs(historian): mark Phase C tasks 1-6 complete (T7 live deferred)	2026-06-14 21:19:28 -04:00
Joseph Doherty	7eb8f4d054	docs(historian): Phase C HistoryRead guide + CLAUDE.md pointer	2026-06-14 20:27:17 -04:00
Joseph Doherty	83e1318425	refactor(historian): align ServerHistorianOptions with AlarmHistorian (Port default, Validate list, log context)	2026-06-14 20:23:22 -04:00
Joseph Doherty	a6f1f4ef15	feat(historian): AddServerHistorian DI + Host wiring of IHistorianDataSource	2026-06-14 20:17:10 -04:00
Joseph Doherty	e6ec0ad8be	fix(historian): events arm sets results on bad paths + Variant.Null SourceName + test hardening ... - HistoryReadEvents miss path + catch path now both set results[handle.Index] explicitly (new SdkHistoryReadResult { StatusCode = BadHistoryOperationUnsupported }) — don't rely on base pre-seeding results[i] so every path sets BOTH errors and results coherently (#1) - ProjectEventField: SourceName null now emits Variant.Null instead of a String-typed null variant (evt.SourceName is null ? Variant.Null : new Variant(evt.SourceName)) (#3) - Comment near the HistoryRead dispatcher block updated: all four arms (Raw/Processed/AtTime + Events/Task 4) are now overridden — "left to the base" wording was stale (#5) - Happy-path test adds ReceiveTime to select clauses and asserts it projects ReceivedTimeUtc as a DateTime Variant at the correct select-order position (#4) - Backend-throw test hardened: asserts errors[0] via ServiceResult.IsBad + explicit code, asserts results[0] is non-null with the Bad code (no longer relies on base seeding), and asserts EventsEntered to prove the override reached the bridge before the throw (#1) - RecordingHistorianDataSource gains EventsEntered flag (set before ThrowOnRead check) (#1) - Events_non_source_node test gains clarifying doc comment explaining the SDK base rejects variable nodes (EventNotifier=None) for event reads before our override runs; the override's source-guard is exercised by the promoted-without-source test instead (#2)	2026-06-14 20:10:16 -04:00
Joseph Doherty	e3c0ef7b41	feat(historian): HistoryReadEvents over equipment-folder notifiers + event-field projection	2026-06-14 19:56:38 -04:00
Joseph Doherty	059f18bdad	test(historian): multi-node HistoryRead isolation + single-lookup ServeNode + comment fix ... Fix A: add Raw_multi_node_per_node_error_isolation test — two historized variables (eqA/good→A.PV, eqB/bad→B.PV) in one Raw batch; per-tagname fake throws for B.PV, returns a sample for A.PV; asserts errors[0]=Good+sample, errors[1]=Bad, HistoryData[1]=null (no cross-slot leak), no exception escapes. Fix B: collapse double ConcurrentDictionary lookup in ServeNode — TryGetHistorizedTagname now captures `out var tagname` on the guard; the resolved tagname is threaded into the read callback as a second parameter (Func<IHistorianDataSource, string, Task<HistorianRead>>), removing the redundant ResolveTagname helper (deleted) and the tiny race window between the check and the second lookup. All three call-sites (Raw/Processed/AtTime) updated. Fix C: rewrite the IsReadModified comment at NodeManagerHistoryReadTests.cs:102 — the SDK's ReadRawModifiedDetails.Initialize() sets m_isReadModified=true (generated ctor body in Opc.Ua.DataTypes.cs), so the default IS true; the test must explicitly clear it to false for a plain raw read. Previous comment said the same thing but imprecisely; now cites the SDK mechanism (Initialize() call in the public ctor).	2026-06-14 19:44:56 -04:00
Joseph Doherty	13fba8f8fb	feat(historian): HistoryRead override (Raw/Processed/AtTime) over IHistorianDataSource	2026-06-14 19:31:39 -04:00
Joseph Doherty	50e1141fc2	test(historian): assert Deferred sink forwards historianTagname + doc nits ... I1: DeferredAddressSpaceSinkTests.RecordingSink now captures HistorianTagname per EnsureVariable call (HistorianQueue/HistorianCalls, matching the Phase7ApplierTests pattern); new test EnsureVariable_forwards_historianTagname_to_inner_sink asserts the arg is forwarded unchanged through DeferredAddressSpaceSink. M1: OtOpcUaNodeManager.EnsureVariable doc-comment notes that a changed historize intent on an already-registered node is silently ignored until a RebuildAddressSpace (rebuild precondition for Task 3 implementers). N2: DeploymentArtifact.ExtractTagHistorize doc wording: "The live-edit side" → "The live-edit composer side".	2026-06-14 19:16:23 -04:00
Joseph Doherty	6041dc202b	feat(historian): materialise historized vars with Historizing + HistoryRead bit + NodeId->tagname map	2026-06-14 19:09:32 -04:00
Joseph Doherty	c35c1d3734	refactor(historian): single-parse ExtractTagHistorize + review-nit tests/docs ... Stop parsing TagConfig twice per tag on the deploy hot path: Phase7Composer's equipment-tag Select lambda is now block-bodied (captures isHistorized/historianTagname once), and DeploymentArtifact.BuildEquipmentTagPlans captures locals before result.Add. Add wrong-type-historianTagname InlineData to ExtractTagHistorizeTests. Extend the parity round-trip fixture with a 4th tag (isHistorized:false + JSON-null tagname) exercising the artifact-side private guard path. Align DeploymentArtifact's ExtractTagHistorize doc-comment with the composer-side phrasing (ExtractTagFullName / ExtractTagAlarm cross-reference).	2026-06-14 19:02:02 -04:00
Joseph Doherty	440929c82a	feat(historian): carry isHistorized + historianTagname through EquipmentTagPlan (byte-parity)	2026-06-14 18:55:04 -04:00
Joseph Doherty	fb906f26ac	docs(historian): Phase C HistoryRead implementation plan + tasks	2026-06-14 18:48:33 -04:00
Joseph Doherty	5e42c1bc38	docs(historian): Phase C server-side HistoryRead design	2026-06-14 18:46:43 -04:00
Joseph Doherty	c9a0f627ea	docs(drivers): mark reconfigure-while-faulted bookkeeping task complete	2026-06-14 18:09:46 -04:00
Joseph Doherty	56f73e49ec	docs(drivers): mark reconfigure-while-faulted Task 1 complete	2026-06-14 17:23:10 -04:00
Joseph Doherty	7ffe8939e7	style(drivers): clarify Reconnecting InitializeFailed no-op is generation-agnostic (code-review nit)	2026-06-14 17:19:34 -04:00
Joseph Doherty	751786ec8c	fix(drivers): adopt corrected config via ApplyDelta while (re)connecting (#7) ... A DriverInstanceActor stuck Reconnecting/Connecting now adopts a config delivered via ApplyDelta and re-initialises with it, instead of dead-lettering and retrying the stale config forever. A monotonic init generation supersedes the in-flight init so the corrected config always wins.	2026-06-14 17:15:28 -04:00
Joseph Doherty	806a252f25	docs(drivers): implementation plan for reconfigure-while-faulted (#7)	2026-06-14 17:11:07 -04:00
Joseph Doherty	076ca025ba	docs(drivers): design for adopting config mid-(re)connect (reconfigure-while-faulted #7)	2026-06-14 17:08:24 -04:00
Joseph Doherty	f9be38430c	fix(alarms): route native alarms by ConditionId (dotted FullName), not bare SourceNodeId (integration review)	2026-06-14 04:09:01 -04:00
Joseph Doherty	7e86fa7099	fix(alarms): normalise native TransitionKind to canonical EmissionKind vocabulary (review)	2026-06-14 03:58:46 -04:00
Joseph Doherty	8736fcc37c	feat(alarms): Primary-gated AlarmTransitionEvent fan-out for native alarms (Phase B WS-5)	2026-06-14 03:48:41 -04:00
Joseph Doherty	b50ef9fc2d	feat(alarms): materialise a Part 9 condition for an alarm equipment tag (Phase B WS-3)	2026-06-14 03:37:51 -04:00
Joseph Doherty	4c56a1719b	feat(alarms): DriverHostActor routes native alarm transitions to Part 9 conditions (Phase B WS-4c)	2026-06-14 03:34:25 -04:00
Joseph Doherty	b0e83902b8	docs(alarms): native driver-alarm TagConfig schema (Phase B)	2026-06-14 03:28:55 -04:00
Joseph Doherty	422e5b7db2	refactor(alarms): harden ExtractTagAlarm severity parse (TryGetInt32) + trim projector prior-state (review nits)	2026-06-14 03:27:03 -04:00
Joseph Doherty	25c3bd16ba	feat(alarms): DriverInstanceActor forwards native OnAlarmEvent to parent (Phase B WS-4b)	2026-06-14 03:24:24 -04:00
Joseph Doherty	c1aeafaaf3	feat(alarms): NativeAlarmProjector maps transitions to condition snapshots (Phase B WS-4a)	2026-06-14 03:16:44 -04:00
Joseph Doherty	e1ccd99ea2	feat(alarms): EquipmentTagPlan.Alarm parsed byte-parity from TagConfig (Phase B WS-2)	2026-06-14 03:12:48 -04:00
Joseph Doherty	f44d8d1e6b	feat(alarms): carry transition Kind on AlarmEventArgs; Galaxy populates it (Phase B WS-1)	2026-06-14 03:04:44 -04:00
Joseph Doherty	a996f03b5b	docs(galaxy): Phase B native-alarms implementation plan + tasks	2026-06-14 02:58:12 -04:00
Joseph Doherty	90096e9c00	docs(galaxy): Phase B native-alarms design (equipment-tag path)	2026-06-14 02:50:34 -04:00
Joseph Doherty	1d797c1c8a	docs(opcua): fix stale NodeWriteRouter reference in EnsureVariable comment	2026-06-14 01:45:35 -04:00
Joseph Doherty	c1e921de0b	fix(opcua): RunContinuationsAsynchronously so revert never re-enters the write Lock	2026-06-14 01:39:47 -04:00
Joseph Doherty	590e497872	fix(runtime): narrow ActorNodeWriteGateway catch + drop vacuous no-actor assertion	2026-06-14 01:32:34 -04:00
Joseph Doherty	10efcf4517	feat(opcua): write-outcome self-correction — capture prior + compare-and-revert on failure	2026-06-14 01:30:20 -04:00
Joseph Doherty	526ddb6a57	feat(runtime): ActorNodeWriteGateway — Asks RouteNodeWrite, returns NodeWriteOutcome	2026-06-14 01:23:43 -04:00
Joseph Doherty	0f7c47a559	feat(commons): IOpcUaNodeWriteGateway + NodeWriteOutcome for write-outcome routing	2026-06-14 01:20:14 -04:00
Joseph Doherty	8a79cb0ec7	docs(design): write-outcome self-correction (surface real device-write status, #5)	2026-06-14 01:13:38 -04:00
Joseph Doherty	945c238039	docs(plans): harden-milestone-1b plan + task record	2026-06-14 00:51:05 -04:00
Joseph Doherty	190ef34e6f	docs(security): document the GroupToRole data-plane role requirement	2026-06-14 00:45:28 -04:00
Joseph Doherty	97d82dda46	test(runtime): future-enum trap for AccessLevel->Writable parity	2026-06-14 00:45:00 -04:00