Review #15 P3 batch: Secrets (004–009, 011, 012, 014–016, 018, 019) #45
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
P3 findings from the scadaproj#15 shared-library review (verified at
91fb2b4) — full description, failure scenario and fix for each incode-reviews/<Lib>/findings.md. Split out any that grow.Fixed on main (all 13; Secrets stays 0.6.6, unpublished): 004+007 (34b1b20) malformed nonce/tag/key lengths fail as decryption errors (audit fires); key + id read once per op and zeroed — a 0.6.5-written row still decrypts (test). 005 (57ef43e) drive-relative, symlink, \?, \localhost\C$ and 8.3 paths into the content root rejected (Windows cases pass on windev). 006 (532a88c) in-flight resolve can't re-cache an old value after rotation; expired plaintext evicted; TTL 0 caches nothing. 008 (ea487d0) one hub-rejected row no longer blocks later names. 009 (d8081ef) empty/unterminated ${secret:} fails startup (names key, never value). 011/012 (049cc50) announce carries its sender; rows/pulls chunked ≤64 KB. 014 (ff7dcf4) Add refuses a live name. 015 (93692fb) Reveal fails closed — shown only if its audit succeeds (reversible choice). 016 (c9e5176) UI components check their own policy (+ real role-mapping test). 018 (8f7fa30) bundle import validates all before writing; partial failure names written rows. 019 (e5099aa) cancellation = shutdown, no endpoint cycling. Consumer changes: symlinked store paths + malformed refs now fail startup; Reveal hidden if audit fails; DefaultSecretResolver is IDisposable; MasterKeyProviderBase.ResolveKeyBytes must return a fresh buffer. Evidence: Secrets solution 623 passed / 20 skipped on macOS (re-run green after rebase); windev 4 suites incl. Secrets.Tests 280/2; each regression test fails with its fix reverted.