dohertj2/scadaproj
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

[code-reviews] Review Secrets, LocalDb, GalaxyRepository and Overview; re-review libs changed since 2026-06-01 #15

New Issue
Open
opened 2026-11-06 15:24:44 -05:00 by dohertj2 · 0 comments
dohertj2 commented 2026-11-06 15:24:44 -05:00
Owner
Copy Link
Copy Source

What: The per-library code-review process (code-reviews/) has only ever covered six libraries, all reviewed once on 2026-06-01 at 5f75cd4. Four hosted projects have never been reviewed under it, and the six reviewed ones have changed substantially since.

Never reviewed: ZB.MOM.WW.Secrets (crypto, 5 packages + CLI + replicators), ZB.MOM.WW.LocalDb (2-node sync engine), ZB.MOM.WW.GalaxyRepository, ZB.MOM.WW.Overview (app).
Stale: Auth (now 0.4.1 with user-bind + ApiKeys.SqlServer), Health (0.3.0 active-tier change), Theme (0.5.0) — all reviewed at 0.1.x/0.2.x.

Ask: add folders + findings for the missing libraries (Secrets first) and re-review the changed ones; regenerate code-reviews/README.md (currently "6 of 6 libraries reviewed, 0 pending" — misleading).

Source: code-reviews/README.md; code-reviews/REVIEW-PROCESS.md

**What:** The per-library code-review process (`code-reviews/`) has only ever covered six libraries, all reviewed once on 2026-06-01 at `5f75cd4`. Four hosted projects have never been reviewed under it, and the six reviewed ones have changed substantially since. **Never reviewed:** `ZB.MOM.WW.Secrets` (crypto, 5 packages + CLI + replicators), `ZB.MOM.WW.LocalDb` (2-node sync engine), `ZB.MOM.WW.GalaxyRepository`, `ZB.MOM.WW.Overview` (app). **Stale:** Auth (now 0.4.1 with user-bind + ApiKeys.SqlServer), Health (0.3.0 active-tier change), Theme (0.5.0) — all reviewed at 0.1.x/0.2.x. **Ask:** add folders + findings for the missing libraries (Secrets first) and re-review the changed ones; regenerate `code-reviews/README.md` (currently "6 of 6 libraries reviewed, 0 pending" — misleading). Source: `code-reviews/README.md`; `code-reviews/REVIEW-PROCESS.md`
dohertj2 added the type:review-findingpriority:p3migrated labels 2026-11-06 15:24:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
blocked
Blocked by dependency or external hold
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label migrated priority:p3 type:review-finding
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/scadaproj#15
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?