[Secrets] Follow-ups: mxaccessgw's copied path rules, ReferenceAuditor malformed tokens, SecretName length cap, UNC-share store path #52

Closed
opened 2026-11-09 15:33:27 -05:00 by dohertj2 · 1 comment
Owner

Follow-ups from the Secrets 0.6.6 P3 batch (#45):

  • mxaccessgw carries its own copy of the store-path rules (GatewayConfigPathRules) with the same symlink and drive-relative gaps fixed in Secrets-005 — align it with the library (or call the library's rules).
  • The CLI's ReferenceAuditor doesn't flag malformed ${secret:} tokens, which now fail startup (#45/009) — make the audit report them.
  • Optional: cap SecretName at 450 chars to match the hub column (008 only isolates the bad row).
  • Secrets-005 doesn't catch a store reached through an ordinary UNC share that points back at the content root.
Follow-ups from the Secrets 0.6.6 P3 batch (#45): - **mxaccessgw** carries its own copy of the store-path rules (`GatewayConfigPathRules`) with the same symlink and drive-relative gaps fixed in Secrets-005 — align it with the library (or call the library's rules). - The CLI's `ReferenceAuditor` doesn't flag malformed `${secret:}` tokens, which now fail startup (#45/009) — make the audit report them. - Optional: cap `SecretName` at 450 chars to match the hub column (008 only isolates the bad row). - Secrets-005 doesn't catch a store reached through an ordinary UNC share that points back at the content root.
dohertj2 added the type:followuppriority:p3cross-repo labels 2026-11-09 15:33:27 -05:00
Author
Owner

Fixed: scadaproj main ebc4933 — ReferenceAuditor reports empty/blank/unterminated/nested ${secret: tokens as a new ReferenceStatus.Malformed (same marker check as SecretReferenceExpander; audit flow says 'fix the token', doesn't offer to seed); SecretName.MaxLength = 450 enforced in the SecretName constructor after trim/lowercase (behaviour change: an already-stored >450 name can no longer be constructed); on Windows a local share (\localhost\share or \\share) is mapped via NetShareGetInfo and compared by location (limits documented: needs Administrators/Server Operators, remote shares never resolved, non-Windows mounts can't be resolved). Secrets stays 0.6.6 unpublished; full Secrets solution green on Mac. mxaccessgw main 7a7ef3b8 — GatewayConfigPathRules gets the Secrets-005 checks (IsPathFullyQualified, spelled + symlink-resolved under-root check, \?\ / \.\ stripping, loopback admin + local shares, 8.3 expansion), copied since it pins Secrets 0.6.2; new GatewayConfigPathSpellingTests with WindowsOnlyFact — Mac NonWindows.slnx 0 warnings, MxGateway.Tests 1417 / 6 skipped; windev: all 18 GatewayConfigPath* tests pass. Not run on Windows: the library's own new share test.

Fixed: scadaproj main ebc4933 — ReferenceAuditor reports empty/blank/unterminated/nested ${secret: tokens as a new ReferenceStatus.Malformed (same marker check as SecretReferenceExpander; audit flow says 'fix the token', doesn't offer to seed); SecretName.MaxLength = 450 enforced in the SecretName constructor after trim/lowercase (behaviour change: an already-stored >450 name can no longer be constructed); on Windows a local share (\\localhost\share or \\<this machine>\share) is mapped via NetShareGetInfo and compared by location (limits documented: needs Administrators/Server Operators, remote shares never resolved, non-Windows mounts can't be resolved). Secrets stays 0.6.6 unpublished; full Secrets solution green on Mac. mxaccessgw main 7a7ef3b8 — GatewayConfigPathRules gets the Secrets-005 checks (IsPathFullyQualified, spelled + symlink-resolved under-root check, \\?\ / \\.\ stripping, loopback admin + local shares, 8.3 expansion), copied since it pins Secrets 0.6.2; new GatewayConfigPathSpellingTests with WindowsOnlyFact — Mac NonWindows.slnx 0 warnings, MxGateway.Tests 1417 / 6 skipped; windev: all 18 GatewayConfigPath* tests pass. Not run on Windows: the library's own new share test.
Sign in to join this conversation.