Driver.Galaxy-002 — DataTypeMap.Map had no Int64 arm though MxValueDecoder/ MxValueEncoder both fully support Int64. Galaxy attributes with the Int64 mx_data_type code fell through to the String default, creating a String address-space node while runtime reads decoded a boxed long. Added `6 => DriverDataType.Int64`, extending the contiguous 0..5 scheme so the type map agrees with the decoder/encoder on all seven Galaxy data types. Driver.Galaxy-008 — after a stream fault the EventPump's StreamEvents consumer loop exited and its channel completed; EventPump.Start() is a no-op on a completed-but-non-null loop, so a replayed subscription had no consumer and ReplayAsync never re-registered the post-reconnect item handles. ReplayAsync now recreates the EventPump (RestartEventPumpForReplay) and rebinds the SubscriptionRegistry per subscription with the fresh item handles returned by the post-reconnect SubscribeBulkAsync, via new SubscriptionRegistry.SnapshotEntries and Rebind APIs. Regression tests: DataTypeMapTests (every code incl. Int64), SubscriptionRegistry Tests (Rebind/SnapshotEntries), EventPumpStreamFaultTests (faulted pump dead, fresh pump resumes dispatch). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
193 lines
8.9 KiB
C#
193 lines
8.9 KiB
C#
using System.Threading.Channels;
|
|
using Google.Protobuf.WellKnownTypes;
|
|
using MxGateway.Contracts.Proto;
|
|
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Core.Abstractions;
|
|
using ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Runtime;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Tests.Runtime;
|
|
|
|
/// <summary>
|
|
/// Regression coverage for Driver.Galaxy-001 (Critical): when the gw StreamEvents
|
|
/// stream faults, the <see cref="EventPump"/> must notify the reconnect supervisor
|
|
/// rather than silently logging and exiting. Without the <c>onStreamFault</c>
|
|
/// hand-off a transient gateway transport drop permanently kills the event stream.
|
|
/// </summary>
|
|
public sealed class EventPumpStreamFaultTests
|
|
{
|
|
private const int WaitMs = 2_000;
|
|
|
|
[Fact]
|
|
public async Task StreamFault_InvokesOnStreamFaultCallback_WithTheCause()
|
|
{
|
|
var subscriber = new FaultingSubscriber();
|
|
var registry = new SubscriptionRegistry();
|
|
var faultObserved = new TaskCompletionSource<Exception>(
|
|
TaskCreationOptions.RunContinuationsAsynchronously);
|
|
|
|
await using var pump = new EventPump(
|
|
subscriber, registry, channelCapacity: 4, clientName: "FaultTest",
|
|
onStreamFault: ex => faultObserved.TrySetResult(ex));
|
|
pump.Start();
|
|
|
|
// Drop the gw stream — RunAsync's await foreach throws.
|
|
subscriber.FaultStream(new IOException("simulated gateway transport drop"));
|
|
|
|
var completed = await Task.WhenAny(faultObserved.Task, Task.Delay(WaitMs));
|
|
completed.ShouldBe(faultObserved.Task,
|
|
"EventPump must invoke onStreamFault when the gw StreamEvents stream faults");
|
|
(await faultObserved.Task).ShouldBeOfType<IOException>();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task StreamFault_DrivesReconnectSupervisorReopenReplay()
|
|
{
|
|
// End-to-end: a faulting EventPump wired to a real ReconnectSupervisor must
|
|
// drive the supervisor through its reopen → replay recovery loop.
|
|
var subscriber = new FaultingSubscriber();
|
|
var registry = new SubscriptionRegistry();
|
|
|
|
var reopenRan = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
|
var replayRan = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
|
|
|
using var supervisor = new ReconnectSupervisor(
|
|
reopen: _ => { reopenRan.TrySetResult(); return Task.CompletedTask; },
|
|
replay: _ => { replayRan.TrySetResult(); return Task.CompletedTask; },
|
|
options: new ReconnectOptions(
|
|
InitialBackoffOverride: TimeSpan.FromMilliseconds(5),
|
|
MaxBackoffOverride: TimeSpan.FromMilliseconds(20)));
|
|
|
|
await using var pump = new EventPump(
|
|
subscriber, registry, channelCapacity: 4, clientName: "FaultTest",
|
|
onStreamFault: supervisor.ReportTransportFailure);
|
|
pump.Start();
|
|
|
|
supervisor.CurrentState.ShouldBe(ReconnectSupervisor.State.Healthy);
|
|
|
|
subscriber.FaultStream(new IOException("simulated gateway transport drop"));
|
|
|
|
(await Task.WhenAny(reopenRan.Task, Task.Delay(WaitMs))).ShouldBe(reopenRan.Task,
|
|
"stream fault must trigger the supervisor's reopen path");
|
|
(await Task.WhenAny(replayRan.Task, Task.Delay(WaitMs))).ShouldBe(replayRan.Task,
|
|
"stream fault must trigger the supervisor's replay path");
|
|
|
|
await supervisor.WaitForHealthyAsync(new CancellationTokenSource(WaitMs).Token);
|
|
supervisor.IsDegraded.ShouldBeFalse();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task FaultedPump_IsNotRestartableInPlace_ButAFreshPumpResumesDispatch()
|
|
{
|
|
// Regression coverage for Driver.Galaxy-008 (High): after a stream fault the old
|
|
// pump's RunAsync loop has exited and its channel is completed — EventPump.Start()
|
|
// is a no-op on a non-null-but-completed loop, so the recovery path must DISPOSE
|
|
// the faulted pump and create a FRESH one. This test pins both halves of that:
|
|
// (a) the faulted pump is dead, (b) a new pump on a live stream resumes OnDataChange.
|
|
var registry = new SubscriptionRegistry();
|
|
registry.Register(1, [new TagBinding("Tank.Level", ItemHandle: 7)]);
|
|
|
|
// --- first pump: faults, then is "restarted" (no-op) and confirmed dead ---
|
|
var faulted = new FaultingSubscriber();
|
|
var staleObserved = false;
|
|
var oldPump = new EventPump(faulted, registry, channelCapacity: 8, clientName: "Restart");
|
|
oldPump.OnDataChange += (_, _) => staleObserved = true;
|
|
oldPump.Start();
|
|
faulted.FaultStream(new IOException("simulated gateway transport drop"));
|
|
await Task.Delay(100);
|
|
|
|
// In-place Start() after a fault is a no-op — the loop task is non-null but done.
|
|
oldPump.Start();
|
|
await oldPump.DisposeAsync();
|
|
|
|
// --- fresh pump on a live re-subscribed stream: OnDataChange must resume ---
|
|
var resubscribed = new ReplaySubscriber();
|
|
var resumed = new TaskCompletionSource<DataChangeEventArgs>(
|
|
TaskCreationOptions.RunContinuationsAsynchronously);
|
|
await using var newPump = new EventPump(
|
|
resubscribed, registry, channelCapacity: 8, clientName: "Restart");
|
|
newPump.OnDataChange += (_, args) => resumed.TrySetResult(args);
|
|
newPump.Start();
|
|
|
|
await resubscribed.EmitAsync(itemHandle: 7, value: 123.0);
|
|
|
|
var completed = await Task.WhenAny(resumed.Task, Task.Delay(WaitMs));
|
|
completed.ShouldBe(resumed.Task,
|
|
"a fresh EventPump created after a fault must resume dispatching OnDataChange");
|
|
(await resumed.Task).FullReference.ShouldBe("Tank.Level");
|
|
staleObserved.ShouldBeFalse("the faulted pump must not dispatch after its stream dropped");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task CleanShutdown_DoesNotInvokeOnStreamFault()
|
|
{
|
|
var subscriber = new FaultingSubscriber();
|
|
var registry = new SubscriptionRegistry();
|
|
var faulted = false;
|
|
|
|
var pump = new EventPump(
|
|
subscriber, registry, channelCapacity: 4, clientName: "FaultTest",
|
|
onStreamFault: _ => faulted = true);
|
|
pump.Start();
|
|
|
|
// Graceful disposal cancels the loop — that is OperationCanceledException,
|
|
// not a transport fault, and must NOT trip the supervisor.
|
|
await pump.DisposeAsync();
|
|
|
|
faulted.ShouldBeFalse("clean shutdown must not be reported as a transport fault");
|
|
}
|
|
|
|
/// <summary>
|
|
/// <see cref="IGalaxySubscriber"/> fake whose StreamEvents stream can be faulted
|
|
/// on demand so the EventPump's RunAsync catch path is exercised.
|
|
/// </summary>
|
|
private sealed class FaultingSubscriber : IGalaxySubscriber
|
|
{
|
|
private readonly Channel<MxEvent> _stream =
|
|
Channel.CreateUnbounded<MxEvent>(new UnboundedChannelOptions { SingleReader = true });
|
|
|
|
public Task<IReadOnlyList<SubscribeResult>> SubscribeBulkAsync(
|
|
IReadOnlyList<string> fullReferences, int bufferedUpdateIntervalMs, CancellationToken cancellationToken)
|
|
=> Task.FromResult<IReadOnlyList<SubscribeResult>>([]);
|
|
|
|
public Task UnsubscribeBulkAsync(IReadOnlyList<int> itemHandles, CancellationToken cancellationToken)
|
|
=> Task.CompletedTask;
|
|
|
|
public IAsyncEnumerable<MxEvent> StreamEventsAsync(CancellationToken cancellationToken)
|
|
=> _stream.Reader.ReadAllAsync(cancellationToken);
|
|
|
|
/// <summary>Fault the stream so the pump's <c>await foreach</c> throws.</summary>
|
|
public void FaultStream(Exception cause) => _stream.Writer.TryComplete(cause);
|
|
}
|
|
|
|
/// <summary>
|
|
/// <see cref="IGalaxySubscriber"/> fake modelling the post-reconnect stream — a
|
|
/// fresh, healthy StreamEvents the recovery path's new EventPump consumes.
|
|
/// </summary>
|
|
private sealed class ReplaySubscriber : IGalaxySubscriber
|
|
{
|
|
private readonly Channel<MxEvent> _stream =
|
|
Channel.CreateUnbounded<MxEvent>(new UnboundedChannelOptions { SingleReader = true });
|
|
|
|
public Task<IReadOnlyList<SubscribeResult>> SubscribeBulkAsync(
|
|
IReadOnlyList<string> fullReferences, int bufferedUpdateIntervalMs, CancellationToken cancellationToken)
|
|
=> Task.FromResult<IReadOnlyList<SubscribeResult>>([]);
|
|
|
|
public Task UnsubscribeBulkAsync(IReadOnlyList<int> itemHandles, CancellationToken cancellationToken)
|
|
=> Task.CompletedTask;
|
|
|
|
public IAsyncEnumerable<MxEvent> StreamEventsAsync(CancellationToken cancellationToken)
|
|
=> _stream.Reader.ReadAllAsync(cancellationToken);
|
|
|
|
public ValueTask EmitAsync(int itemHandle, double value) =>
|
|
_stream.Writer.WriteAsync(new MxEvent
|
|
{
|
|
Family = MxEventFamily.OnDataChange,
|
|
ItemHandle = itemHandle,
|
|
Value = new MxValue { DoubleValue = value },
|
|
Quality = 192,
|
|
SourceTimestamp = Timestamp.FromDateTime(DateTime.UtcNow),
|
|
});
|
|
}
|
|
}
|