dohertj2/lmxopcua
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(s7-cli): restore OnDataChange CliFx-console rationale comment #443

Merged
dohertj2 merged 1 commits from fix/s7cli-restore-console-rationale-comment into master 2026-07-14 14:49:28 -04:00
Conversation 0 Commits 1 Files Changed 1
+2

1 Commits

Author SHA1 Message Date
Joseph Doherty d327243fd3 fix(s7-cli): restore OnDataChange CliFx-console rationale comment
v2-ci / build (pull_request) Failing after 15s
Details
v2-ci / unit-tests (pull_request) Has been skipped
Details 
The 9cad9ed0 'strip tracking-ID comments' XML-doc sweep collaterally
removed the comment explaining why the S7 subscribe command routes
OnDataChange through the CliFx IConsole (not System.Console), leaving
SubscribeCommandConsoleHandlerCommentTests red. The Modbus copy still
carries the comment verbatim and the test guards S7-mirrors-Modbus
parity, so restore it (matching the Modbus wording) rather than weaken
the guard.

S7.Cli tests 49/49.
 2026-07-14 14:49:10 -04:00