dohertj2/lmxopcua
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(s7-cli): restore OnDataChange CliFx-console rationale comment #443

Merged
dohertj2 merged 1 commits from fix/s7cli-restore-console-rationale-comment into master 2026-07-14 14:49:28 -04:00
Conversation 0 Commits 1 Files Changed 1
+2
dohertj2 commented 2026-07-14 14:49:20 -04:00
Owner
Copy Link
Copy Source

Closes the pre-existing red SubscribeCommandConsoleHandlerCommentTests on master.

9cad9ed0 (a strip tracking-ID comments XML-doc sweep) collaterally removed the comment explaining why the S7 subscribe command routes OnDataChange through the CliFx IConsole (not System.Console). The Modbus copy still carries that comment verbatim, and the test guards S7-mirrors-Modbus parity — so the honest fix is to restore the comment (matching the Modbus wording), not weaken the guard.

One-line source restore; no behavior change. S7.Cli tests 49/49.

Closes the pre-existing red `SubscribeCommandConsoleHandlerCommentTests` on master. `9cad9ed0` (a *strip tracking-ID comments* XML-doc sweep) collaterally removed the comment explaining why the S7 subscribe command routes `OnDataChange` through the CliFx `IConsole` (not `System.Console`). The Modbus copy still carries that comment verbatim, and the test guards S7-mirrors-Modbus parity — so the honest fix is to **restore the comment** (matching the Modbus wording), not weaken the guard. One-line source restore; no behavior change. S7.Cli tests **49/49**.
dohertj2 added 1 commit 2026-07-14 14:49:21 -04:00
fix(s7-cli): restore OnDataChange CliFx-console rationale comment
v2-ci / build (pull_request) Failing after 15s
Details
v2-ci / unit-tests (pull_request) Has been skipped
Details
d327243fd3 
The 9cad9ed0 'strip tracking-ID comments' XML-doc sweep collaterally
removed the comment explaining why the S7 subscribe command routes
OnDataChange through the CliFx IConsole (not System.Console), leaving
SubscribeCommandConsoleHandlerCommentTests red. The Modbus copy still
carries the comment verbatim and the test guards S7-mirrors-Modbus
parity, so restore it (matching the Modbus wording) rather than weaken
the guard.

S7.Cli tests 49/49.
dohertj2 merged commit 365a90e63d into master 2026-07-14 14:49:28 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#443
Delete Branch "fix/s7cli-restore-console-rationale-comment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?