R2-07 Surgical pure-adds (arch-review round 2) #436

2026-07-13T12:26:25-04:00

dohertj2 commented

2026-07-13 12:26:25 -04:00

Round-2 arch-review plan R2-07 (finding 03/P1 — surgical in-place address-space adds/removals instead of full rebuilds; gated by the U2 forwarding guard).

Phase 1 (adds): new pure AddressSpaceChangeClassifier (default-closed Rebuild); AddressSpaceApplier.Apply routes PureAdd/AttributeOnly to skip RebuildAddressSpace; adds announced via existing guard-covered RaiseNodesAddedModelChange, gated on !outcome.RebuildCalled; MaterialiseAlarmCondition idempotent. Zero new sink members in Phase 1.
Phase 2 (removes): 3 new ISurgicalAddressSpaceSink members (RemoveVariableNode/RemoveAlarmConditionNode/RemoveEquipmentSubtree) — guard-first with observed negative control, DeferredAddressSpaceSink forwards (F10b inertness net), OtOpcUaNodeManager scoped in-place teardown; PureRemove arm writes terminal Bad/RemovedConditionState, false/throw ⇒ full-rebuild ratchet.
Phase 3 (mixed): AddRemoveMix runs remove pass then adds; id-reuse recreate covered.

11 tasks done; T5/T6/T12/T14 deferred-live — the over-the-wire SubscriptionSurvivalTests + docker-dev gates are the F10b inertness nets, MUST run in the serial heavy pass. Build clean; OpcUaServer.Tests 336/336, Runtime.Tests 398/398, Commons.Tests 122/122 (incl. forwarding guard green). Plan: archreview/plans/R2-07-surgical-pure-adds-plan.md.

Round-2 arch-review plan **R2-07** (finding 03/P1 — surgical in-place address-space adds/removals instead of full rebuilds; gated by the U2 forwarding guard). - **Phase 1 (adds):** new pure `AddressSpaceChangeClassifier` (default-closed Rebuild); `AddressSpaceApplier.Apply` routes PureAdd/AttributeOnly to skip `RebuildAddressSpace`; adds announced via existing guard-covered `RaiseNodesAddedModelChange`, gated on `!outcome.RebuildCalled`; `MaterialiseAlarmCondition` idempotent. **Zero new sink members in Phase 1.** - **Phase 2 (removes):** 3 new `ISurgicalAddressSpaceSink` members (RemoveVariableNode/RemoveAlarmConditionNode/RemoveEquipmentSubtree) — **guard-first with observed negative control**, `DeferredAddressSpaceSink` forwards (F10b inertness net), `OtOpcUaNodeManager` scoped in-place teardown; PureRemove arm writes terminal Bad/RemovedConditionState, false/throw ⇒ full-rebuild ratchet. - **Phase 3 (mixed):** AddRemoveMix runs remove pass then adds; id-reuse recreate covered. 11 tasks done; **T5/T6/T12/T14 deferred-live** — the over-the-wire SubscriptionSurvivalTests + docker-dev gates are the F10b inertness nets, MUST run in the serial heavy pass. Build clean; OpcUaServer.Tests 336/336, Runtime.Tests 398/398, Commons.Tests 122/122 (incl. forwarding guard green). Plan: `archreview/plans/R2-07-surgical-pure-adds-plan.md`.

dohertj2 added 15 commits 2026-07-13 12:26:26 -04:00

feat(opcua): add AddressSpaceChangeClassifier — typed delta classification for the applier (R2-07 T1) bb226f45ed

feat(opcua): route AddressSpaceApplier through the classifier — pure-add deploys no longer rebuild (R2-07 T2) 0d717e4785

feat(opcua): announce pure-add nodes via Part 3 NodeAdded model-change (R2-07 T3) 9dbc363ef0

feat(opcua): make MaterialiseAlarmCondition idempotent for same-kind re-applies (R2-07 T4a) a86d9f65bf

feat(runtime): announce added nodes after the materialise passes on non-rebuild applies (R2-07 T4b) e6280cb1da

test(opcua): over-the-wire subscription-survival on pure-add deploy (R2-07 T5) 376233b92c

docs(archreview): record R2-07 Phase 1 (offline-verified; live gate deferred) in STATUS.md 4f1853b21f

feat(commons): add surgical remove members to ISurgicalAddressSpaceSink + deferred forwarding (guard-verified) (R2-07 T7) 438004e371

feat(opcua): surgical RemoveVariableNode with NodeDeleted model-change (R2-07 T8) 14003ab9b8

feat(opcua): surgical RemoveAlarmConditionNode (R2-07 T9) 9653493905

feat(opcua): surgical RemoveEquipmentSubtree with notifier demotion (R2-07 T10) 4504ed930c

feat(opcua): surgical pure-remove deploys — scoped teardown, no full rebuild (R2-07 T11) 502d7650d0

test(opcua): subscription-survival on pure-remove + live-verify note (R2-07 T12) f4ea834fac

feat(opcua): surgical mixed add+remove deploys (R2-07 T13) e2b47638ec

test+docs: mixed-deploy survival, STATUS/P1 close-out (R2-07 T14)

v2-ci / build (pull_request) Successful in 4m3s

Details

v2-ci / unit-tests (pull_request) Failing after 9m47s

Details

ded0595ca7

dohertj2 commented

2026-07-13 12:28:01 -04:00

Landed on master via merge commit 04fa2f5c (local --no-ff merge). Auto-merged OtOpcUaNodeManager.cs against R2-08; verified OpcUaServer.Tests 341/341 + F10b forwarding guard 3/3 + clean build. T5/T6/T12/T14 (over-the-wire SubscriptionSurvivalTests + docker-dev surgical /run) are must-run F10b nets in the serial heavy pass. Closing as merged.

Landed on `master` via merge commit `04fa2f5c` (local --no-ff merge). Auto-merged OtOpcUaNodeManager.cs against R2-08; verified OpcUaServer.Tests 341/341 + F10b forwarding guard 3/3 + clean build. T5/T6/T12/T14 (over-the-wire SubscriptionSurvivalTests + docker-dev surgical /run) are must-run F10b nets in the serial heavy pass. Closing as merged.

dohertj2 closed this pull request

2026-07-13 12:28:02 -04:00

dohertj2 referenced this issue from a commit

2026-07-13 12:28:03 -04:00

Merge R2-07 Surgical pure-adds (arch-review round 2) [PR #436]

v2-ci / build (pull_request) Successful in 4m3s

Details

v2-ci / unit-tests (pull_request) Failing after 9m47s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#436