R2-03 Virtual-Tag failure quality (arch-review round 2) #430

2026-07-13T10:19:25-04:00

dohertj2 commented

2026-07-13 10:19:25 -04:00

Round-2 arch-review plan R2-03 (findings 02/S13, 02/S12, 02/P7).

S13: VT script failure/timeout now degrades the node to OpcUaQuality.Bad (carrying last-known value) once per Good→Bad transition, gated on all deps arrived (no cold-start flash); recovery force-publishes next Good. Bridge historizes 0x80020000 BadInternalError. (Fixes the stale-Good-forever hole the timeout fix created.)
S12: RoslynVirtualTagEvaluator.Evaluate retries once on ObjectDisposedException from a clear racing an in-flight evaluation (re-fetch recompiles into current generation).
P7: apply-boundary ClearCompiledScripts gated on a changed deployed expression set (HashSet.SetEquals, ordinal) — identical redeploys no longer force full VT recompilation.

10/12 tasks; T11 (full sweep) + T12 (live /run) deferred to serial heavy pass. Build clean; Runtime.Tests 372/372, RoslynVirtualTagEvaluatorTests 20/20 (S12 stress deterministically green). Plan: archreview/plans/R2-03-vt-failure-quality-plan.md.

Round-2 arch-review plan **R2-03** (findings 02/S13, 02/S12, 02/P7). - **S13**: VT script failure/timeout now degrades the node to `OpcUaQuality.Bad` (carrying last-known value) once per Good→Bad transition, gated on all deps arrived (no cold-start flash); recovery force-publishes next Good. Bridge historizes 0x80020000 BadInternalError. (Fixes the stale-Good-forever hole the timeout fix created.) - **S12**: `RoslynVirtualTagEvaluator.Evaluate` retries once on ObjectDisposedException from a clear racing an in-flight evaluation (re-fetch recompiles into current generation). - **P7**: apply-boundary `ClearCompiledScripts` gated on a changed deployed expression set (HashSet.SetEquals, ordinal) — identical redeploys no longer force full VT recompilation. 10/12 tasks; **T11 (full sweep) + T12 (live /run) deferred** to serial heavy pass. Build clean; Runtime.Tests 372/372, RoslynVirtualTagEvaluatorTests 20/20 (S12 stress deterministically green). Plan: `archreview/plans/R2-03-vt-failure-quality-plan.md`.

dohertj2 added 12 commits 2026-07-13 10:19:26 -04:00

test(runtime): red repro — VT script failure after success leaves node stale-Good (02/S13) b977548593

feat(runtime): EvaluationResult carries OpcUaQuality; VT bridge publishes it + historizes BadInternalError on Bad (02/S13) c5ca3e8587

fix(runtime): VT script failure/timeout degrades node quality to Bad once per transition (02/S13) 01253818de

test(runtime): pin VT Bad-quality transition semantics — once-per-transition, same-value recovery, throw path (02/S13) 987459fab3

test(runtime): pin VT inputs-ready gate — no Bad flash before all dependencies arrive (02/S13) f2006adb79

test(host): pin sequential clear-then-recompile contract of RoslynVirtualTagEvaluator (02/S12 baseline) 05c35c93d9

test(host): red repro — apply-boundary cache clear races in-flight VT evaluation into ObjectDisposedException (02/S12) d67900e455

fix(host): retry VT evaluation once on ObjectDisposedException from the apply-boundary cache clear (02/S12) ef00d6e5aa

test(runtime): red — apply-boundary compile-cache clear must be gated on a changed expression set (02/P7) 37664e6992

perf(runtime): gate the VT apply-boundary compile-cache clear on a changed expression set (02/P7) a916ae6ebe

docs(archreview): record R2-03 (02/S13+S12+P7) fixed on branch; full VT suites green 534e03bc74