fix(ablegacy): stamp health from the injectable Clock; drop the redundant per-project TreatWarningsAsErrors (lmxopcua#768)

AbLegacyDriver stamped LastSuccessfulRead (init, read, write), the read's sample timestamps and host-state change times from raw DateTime.UtcNow; only the backoff path read the injectable Clock. All of them now read Clock(), so NativePcccBridgeStatusHealthTests drives a manual clock (init at T0, read at T1) and asserts LastSuccessfulRead == T1 exactly instead of spin-waiting for the wall clock to pass the init stamp (#767). Without the driver change the 6 tests fail (init stamp is wall-clock, not T0). Directory.Build.props sets TreatWarningsAsErrors for every project since #766, so the 75 per-csproj copies (64 src + 11 tests) are removed and the props comment says it is now the only place. tools/mem-probe keeps its explicit opt-out. Release build: 0 warnings, 0 errors; a planted CS0168 still fails the build in a src project and in a test project that used to carry its own copy. Claude-Session: https://claude.ai/code/session_01GT67AEHd2Acv1YPwGfXEoV
2026-11-09 13:40:07 -05:00
parent c904472af2
commit 919009c5ef
78 changed files with 39 additions and 107 deletions
@@ -4,9 +4,9 @@

    TreatWarningsAsErrors is ON for every project, src/ and tests alike (#766 ratchet). The solution builds with
    0 warnings since #725 (xUnit1051 etc. cleaned), so any new warning, including analyzer ones, now fails the
-    build instead of accumulating. The 61 src/ projects also still set it in their own csproj (#606); that is
-    redundant but harmless. A project that genuinely needs an exception should suppress the specific warning
-    via NoWarn, not turn this off.
+    build instead of accumulating. This is the ONLY place it is set: the per-project copies (#606) were removed
+    (#768), so do not add it back to a csproj. A project that genuinely needs an exception should suppress the
+    specific warning via NoWarn, not turn this off (only the throwaway tools/mem-probe probes opt out).
  -->
  <PropertyGroup>
    <TargetFramework>net10.0</TargetFramework>
@@ -4,7 +4,6 @@
        <OutputType>Exe</OutputType>
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <ImplicitUsings>enable</ImplicitUsings>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Client.CLI</RootNamespace>
    </PropertyGroup>
@@ -3,7 +3,6 @@
    <PropertyGroup>
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <ImplicitUsings>enable</ImplicitUsings>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Client.Shared</RootNamespace>
    </PropertyGroup>
@@ -4,7 +4,6 @@
        <OutputType>WinExe</OutputType>
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <ImplicitUsings>enable</ImplicitUsings>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Client.UI</RootNamespace>
    </PropertyGroup>
@@ -2,7 +2,6 @@

    <PropertyGroup>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Cluster</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -2,7 +2,6 @@

    <PropertyGroup>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Commons</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <!-- WP7: the calc deploy-gate reuses the pure DependencyGraph (Tarjan SCC) from Core.VirtualTags,
             whose closure includes Microsoft.CodeAnalysis.CSharp.Scripting 4.12.0 (== CodeAnalysis.Common
@@ -5,7 +5,6 @@
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
    <LangVersion>latest</LangVersion>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    <GenerateDocumentationFile>true</GenerateDocumentationFile>
    <NoWarn>$(NoWarn);CS1591</NoWarn>
  </PropertyGroup>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Core.AlarmHistorian</RootNamespace>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Core.ScriptedAlarms</RootNamespace>
@@ -5,7 +5,6 @@
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
    <LangVersion>latest</LangVersion>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    <GenerateDocumentationFile>true</GenerateDocumentationFile>
    <NoWarn>$(NoWarn);CS1591</NoWarn>
    <RootNamespace>ZB.MOM.WW.OtOpcUa.Core.Scripting</RootNamespace>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Core.Scripting</RootNamespace>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Core.VirtualTags</RootNamespace>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Core</RootNamespace>
@@ -13,7 +13,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.AbCip.Cli</RootNamespace>
@@ -13,7 +13,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.AbLegacy.Cli</RootNamespace>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Cli.Common</RootNamespace>
@@ -13,7 +13,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Cli</RootNamespace>
@@ -13,7 +13,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Modbus.Cli</RootNamespace>
@@ -13,7 +13,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.S7.Cli</RootNamespace>
@@ -13,7 +13,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.TwinCAT.Cli</RootNamespace>
@@ -4,7 +4,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Ab.Transport</RootNamespace>
@@ -3,7 +3,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>
    <!-- NO PackageReference. ProjectReference only to the zero-dependency Core.Abstractions leaf
         (R2-11 05/CONV-2 — shared TagConfigJson readers). -->
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.AbCip</RootNamespace>
@@ -3,7 +3,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>
    <!-- NO PackageReference. ProjectReference only to the zero-dependency Core.Abstractions leaf
         (R2-11 05/CONV-2 — shared TagConfigJson readers). -->
@@ -217,7 +217,7 @@ public sealed partial class AbLegacyDriver : IDriver, IReadable, IWritable, ITag
                    ?? throw new InvalidOperationException(
                        $"AbLegacy device has invalid HostAddress '{device.HostAddress}' — expected 'ab://gateway[:port]/cip-path'.");
                var profile = AbLegacyPlcFamilyProfile.ForFamily(device.PlcFamily);
-                devices[device.HostAddress] = new DeviceState(addr, device, profile);
+                devices[device.HostAddress] = new DeviceState(addr, device, profile) { HostStateChangedUtc = Clock() };
            }
            // Build the RawPath → definition table from the authored raw tags. Each entry's TagConfig
            // blob is mapped by the pure factory; the entry's WriteIdempotent flag is threaded onto the
@@ -286,7 +286,7 @@ public sealed partial class AbLegacyDriver : IDriver, IReadable, IWritable, ITag
                        state.ProbeTask = Task.Run(() => ProbeLoopAsync(state, probe, ct), ct);
                    }
                }
-                _health = new DriverHealth(DriverState.Healthy, DateTime.UtcNow, null);
+                _health = new DriverHealth(DriverState.Healthy, Clock(), null);
            }
        }
        catch (Exception ex)
@@ -451,9 +451,11 @@ public sealed partial class AbLegacyDriver : IDriver, IReadable, IWritable, ITag
    internal const int FaultsToMarkDeviceDown = 2;

    /// <summary>
-    ///     The clock every per-device backoff decision reads (window open? when does it end?). Wall-clock UTC in
-    ///     production; a test substitutes a manual clock so the window can be crossed deterministically rather than by
-    ///     sleeping (review 07 r0 M7).
+    ///     The clock every per-device backoff decision reads (window open? when does it end?) AND every health stamp
+    ///     (<c>LastSuccessfulRead</c> at init / read / write, the read's sample timestamps, host-state change times).
+    ///     Wall-clock UTC in production; a test substitutes a manual clock so a window can be crossed, or a stamp proven
+    ///     to advance, deterministically rather than by sleeping or spinning (review 07 r0 M7, lmxopcua#768). Set it
+    ///     before <c>InitializeAsync</c> for the init stamp to come from it.
    /// </summary>
    internal Func<DateTime> Clock { get; set; } = () => DateTime.UtcNow;

@@ -508,7 +510,7 @@ public sealed partial class AbLegacyDriver : IDriver, IReadable, IWritable, ITag
    {
        ArgumentNullException.ThrowIfNull(fullReferences);
        var epoch = CurrentEpoch;
-        var now = DateTime.UtcNow;
+        var now = Clock();
        var results = new DataValueSnapshot[fullReferences.Count];
        var devices = _devices; // one snapshot of the published table for the whole call

@@ -1080,7 +1082,7 @@ public sealed partial class AbLegacyDriver : IDriver, IReadable, IWritable, ITag
        }

        outcome.FoldOpaque();
-        ApplyHealth(epoch, outcome.FaultMessage, anyGood: outcome.AnyAnswered, anyAnswered: outcome.AnyAnswered, DateTime.UtcNow);
+        ApplyHealth(epoch, outcome.FaultMessage, anyGood: outcome.AnyAnswered, anyAnswered: outcome.AnyAnswered, Clock());
        return results;
    }

@@ -1230,7 +1232,7 @@ public sealed partial class AbLegacyDriver : IDriver, IReadable, IWritable, ITag
            old = state.HostState;
            if (old == newState) return;
            state.HostState = newState;
-            state.HostStateChangedUtc = DateTime.UtcNow;
+            state.HostStateChangedUtc = Clock();
        }
        if (newState == HostState.Stopped)
            _logger.LogWarning(
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.AbLegacy</RootNamespace>
@@ -4,7 +4,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Calculation</RootNamespace>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Calculation</RootNamespace>
@@ -3,7 +3,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>
    <!-- NO PackageReference. ProjectReference only to the zero-dependency Core.Abstractions leaf
         (R2-11 05/CONV-2 — shared TagConfigJson readers beside EquipmentTagRefResolver; no
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.FOCAS</RootNamespace>
@@ -3,7 +3,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>
    <ItemGroup>
        <ProjectReference Include="..\..\Core\ZB.MOM.WW.OtOpcUa.Commons\ZB.MOM.WW.OtOpcUa.Commons.csproj" />
@@ -3,7 +3,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>
    <ItemGroup>
        <!-- v3 RawPath identity: GalaxyDriverOptions.RawTags is IReadOnlyList<RawTagEntry>,
@@ -6,7 +6,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Galaxy</RootNamespace>
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">

    <PropertyGroup>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <Platforms>AnyCPU;x64</Platforms>
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">

    <PropertyGroup>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <Platforms>AnyCPU;x64</Platforms>
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">

    <PropertyGroup>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <Platforms>AnyCPU;x64</Platforms>
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">

    <PropertyGroup>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <Platforms>AnyCPU;x64</Platforms>
@@ -4,7 +4,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <!-- Pure records + the MTConnect data-type inference table, shared by the driver, browse-commit,
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.MTConnect</RootNamespace>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Modbus</RootNamespace>
@@ -4,7 +4,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <!-- ModbusDriverOptions references enums (ModbusFamily, ModbusRegion, ModbusDataType, etc.)
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Modbus</RootNamespace>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Mqtt.Browser</RootNamespace>
        <AssemblyName>ZB.MOM.WW.OtOpcUa.Driver.Mqtt.Browser</AssemblyName>
    </PropertyGroup>
@@ -3,7 +3,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>
    <ItemGroup>
        <ProjectReference Include="..\..\Core\ZB.MOM.WW.OtOpcUa.Core.Abstractions\ZB.MOM.WW.OtOpcUa.Core.Abstractions.csproj"/>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Mqtt</RootNamespace>
        <AssemblyName>ZB.MOM.WW.OtOpcUa.Driver.Mqtt.Transport</AssemblyName>
    </PropertyGroup>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Mqtt</RootNamespace>
@@ -3,7 +3,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>
    <ItemGroup>
        <ProjectReference Include="..\..\Core\ZB.MOM.WW.OtOpcUa.Commons\ZB.MOM.WW.OtOpcUa.Commons.csproj" />
@@ -3,7 +3,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>
    <ItemGroup>
        <!-- DEPENDENCY-LIGHT ON PURPOSE: Core.Abstractions and nothing else, the same shape as
@@ -3,7 +3,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <!-- Namespace stays ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient (no .Session suffix) so moving
             NamespaceMap here changed no consumer's `using`. -->
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient</RootNamespace>
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient</RootNamespace>
@@ -4,7 +4,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <!-- NO PackageReference. ProjectReference only to the zero-dependency Core.Abstractions leaf
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.S7</RootNamespace>
@@ -3,7 +3,6 @@
    <TargetFramework>net10.0</TargetFramework>
    <Nullable>enable</Nullable>
    <ImplicitUsings>enable</ImplicitUsings>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    <GenerateDocumentationFile>true</GenerateDocumentationFile>
    <NoWarn>$(NoWarn);CS1591</NoWarn>
    <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Sql.Browser</RootNamespace>
@@ -3,7 +3,6 @@
    <TargetFramework>net10.0</TargetFramework>
    <Nullable>enable</Nullable>
    <ImplicitUsings>enable</ImplicitUsings>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    <GenerateDocumentationFile>true</GenerateDocumentationFile>
    <NoWarn>$(NoWarn);CS1591</NoWarn>
    <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Sql.Contracts</RootNamespace>
@@ -4,7 +4,6 @@
    <Nullable>enable</Nullable>
    <ImplicitUsings>enable</ImplicitUsings>
    <LangVersion>latest</LangVersion>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    <GenerateDocumentationFile>true</GenerateDocumentationFile>
    <NoWarn>$(NoWarn);CS1591</NoWarn>
    <!-- Assembly is .Dialect; the NAMESPACE stays ZB.MOM.WW.OtOpcUa.Driver.Sql, matching the
@@ -4,7 +4,6 @@
    <Nullable>enable</Nullable>
    <ImplicitUsings>enable</ImplicitUsings>
    <LangVersion>latest</LangVersion>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    <GenerateDocumentationFile>true</GenerateDocumentationFile>
    <NoWarn>$(NoWarn);CS1591</NoWarn>
    <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.Sql</RootNamespace>
@@ -3,7 +3,6 @@
        <TargetFramework>net10.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>
    <!-- NO PackageReference. ProjectReference only to the zero-dependency Core.Abstractions leaf
         (R2-11 05/CONV-2 — shared TagConfigJson readers). -->
@@ -5,7 +5,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.TwinCAT</RootNamespace>
@@ -3,7 +3,6 @@
    <PropertyGroup>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.AdminUI</RootNamespace>
        <AddRazorSupportForMvc>true</AddRazorSupportForMvc>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -2,7 +2,6 @@

    <PropertyGroup>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.ControlPlane</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -4,7 +4,6 @@
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Host</RootNamespace>
        <AssemblyName>OtOpcUa.Host</AssemblyName>
        <UserSecretsId>zb-mom-ww-otopcua-host</UserSecretsId>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <!-- Microsoft.CodeAnalysis.CSharp.Scripting (4.12.0, pulled in via Core.Scripting for F8b
             user-script compilation) requires CodeAnalysis.Common 4.12.0 exactly, but ASP.NET
             Core's transitive Microsoft.CodeAnalysis.CSharp 5.0.0 wins resolution. Suppress
@@ -2,7 +2,6 @@

    <PropertyGroup>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.OpcUaServer</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -2,7 +2,6 @@

    <PropertyGroup>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Runtime</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -2,7 +2,6 @@

    <PropertyGroup>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Security</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -5,7 +5,6 @@
             (which on .NET Framework 4.7.2 and .NET 6+ equally resolves netstandard2.0). -->
        <TargetFramework>netstandard2.0</TargetFramework>
        <Nullable>enable</Nullable>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <LangVersion>latest</LangVersion>
        <IsPackable>false</IsPackable>
        <IsRoslynComponent>true</IsRoslynComponent>
@@ -4,7 +4,6 @@
        <IsPackable>false</IsPackable>
        <IsTestProject>true</IsTestProject>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Cluster.Tests</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -4,7 +4,6 @@
        <IsPackable>false</IsPackable>
        <IsTestProject>true</IsTestProject>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Commons.Tests</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -45,20 +45,17 @@ public sealed class NativePcccBridgeStatusHealthTests
    }

    /// <summary>
-    ///     InitializeAsync stamps <c>LastSuccessfulRead</c> with <c>DateTime.UtcNow</c> and the read stamps its own
-    ///     <c>UtcNow</c> microseconds later; on a coarse/identical clock reading the two are equal, so an "advanced"
-    ///     assertion (<c>ShouldNotBe(before)</c>) failed ~70% of runs (lmxopcua#767). Spin until the clock has strictly
-    ///     passed the init stamp so any later stamp is provably newer. The assertion itself is unchanged.
+    ///     A manual clock the driver stamps health from (lmxopcua#768). Init stamps <see cref="InitTime"/>; each test
+    ///     moves it to <see cref="ReadTime"/> before reading, so an "advanced" <c>LastSuccessfulRead</c> is provably
+    ///     the read's stamp (it used to be <c>DateTime.UtcNow</c> twice microseconds apart, equal ~70% of runs on a
+    ///     coarse clock, lmxopcua#767).
    /// </summary>
-    private static void WaitUntilClockPast(DateTime? stamp)
-    {
-        if (stamp is null) return;
-        var spin = new SpinWait();
-        while (DateTime.UtcNow <= stamp.Value) spin.SpinOnce();
-    }
+    private static readonly DateTime InitTime = new(2026, 1, 1, 0, 0, 0, DateTimeKind.Utc);
+
+    private static readonly DateTime ReadTime = InitTime.AddSeconds(1);

 #pragma warning disable OTOPCUA0001 // the driver is called directly to pin its OWN classification (no resilience wrap)
-    private static async Task<AbLegacyDriver> DriverAsync(FakeEipServer server)
+    private static async Task<AbLegacyDriver> DriverAsync(FakeEipServer server, Func<DateTime> clock)
    {
        var host = $"ab://127.0.0.1:{server.Port}/1,0";
        var driver = new AbLegacyDriver(new AbLegacyDriverOptions
@@ -67,7 +64,10 @@ public sealed class NativePcccBridgeStatusHealthTests
            RawTags = AbLegacyRawTags.Entries([new AbLegacyTagDefinition("T", host, "N7:0", AbLegacyDataType.Int)]),
            Timeout = TimeSpan.FromSeconds(5),
            Probe = new AbLegacyProbeOptions { Enabled = false },
-        }, "drv-pccc-bridge", new NativeAbLegacyTagFactory(new DeviceSessionPool()));
+        }, "drv-pccc-bridge", new NativeAbLegacyTagFactory(new DeviceSessionPool()))
+        {
+            Clock = clock,
+        };
        await driver.InitializeAsync("{}", TestContext.Current.CancellationToken);
        return driver;
    }
@@ -78,8 +78,11 @@ public sealed class NativePcccBridgeStatusHealthTests
    {
        var ct = TestContext.Current.CancellationToken;
        await using var server = StsServer(0x30);
-        var driver = await DriverAsync(server);
+        var now = InitTime;
+        var driver = await DriverAsync(server, () => now);
        var before = driver.GetHealth().LastSuccessfulRead;
+        before.ShouldBe(InitTime);
+        now = ReadTime;

        var result = (await driver.ReadAsync(["T"], ct)).Single();

@@ -97,17 +100,18 @@ public sealed class NativePcccBridgeStatusHealthTests
    {
        var ct = TestContext.Current.CancellationToken;
        await using var server = StsServer(0x60);
-        var driver = await DriverAsync(server);
+        var now = InitTime;
+        var driver = await DriverAsync(server, () => now);
        var before = driver.GetHealth().LastSuccessfulRead;
-        WaitUntilClockPast(before);
+        before.ShouldBe(InitTime);
+        now = ReadTime;

        var result = (await driver.ReadAsync(["T"], ct)).Single();

        result.StatusCode.ShouldBe(AbOpcUaStatusMap.BadNotWritable);
        var health = driver.GetHealth();
        health.State.ShouldBe(DriverState.Healthy);
-        health.LastSuccessfulRead.ShouldNotBeNull();
-        health.LastSuccessfulRead.ShouldNotBe(before);
+        health.LastSuccessfulRead.ShouldBe(ReadTime);
        await driver.ShutdownAsync(ct);
        server.HandlerErrors.ShouldBeEmpty();
    }
@@ -128,17 +132,18 @@ public sealed class NativePcccBridgeStatusHealthTests
    {
        var ct = TestContext.Current.CancellationToken;
        await using var server = general == 0 ? StsServer(0x10) : CipEnvelopeServer(general);
-        var driver = await DriverAsync(server);
+        var now = InitTime;
+        var driver = await DriverAsync(server, () => now);
        var before = driver.GetHealth().LastSuccessfulRead;
-        WaitUntilClockPast(before);
+        before.ShouldBe(InitTime);
+        now = ReadTime;

        var result = (await driver.ReadAsync(["T"], ct)).Single();

        result.StatusCode.ShouldBe(AbLegacyStatusMapper.BadNotSupported);
        var health = driver.GetHealth();
        health.State.ShouldBe(DriverState.Healthy);
-        health.LastSuccessfulRead.ShouldNotBeNull();
-        health.LastSuccessfulRead.ShouldNotBe(before);
+        health.LastSuccessfulRead.ShouldBe(ReadTime);
        await driver.ShutdownAsync(ct);
        server.HandlerErrors.ShouldBeEmpty();
    }
@@ -27,7 +27,6 @@
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <LangVersion>latest</LangVersion>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        <GenerateDocumentationFile>true</GenerateDocumentationFile>
        <NoWarn>$(NoWarn);CS1591</NoWarn>
        <IsPackable>false</IsPackable>
@@ -4,7 +4,6 @@
        <IsPackable>false</IsPackable>
        <IsTestProject>true</IsTestProject>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.AdminUI.Tests</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -4,7 +4,6 @@
        <IsPackable>false</IsPackable>
        <IsTestProject>true</IsTestProject>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.ControlPlane.Tests</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -4,7 +4,6 @@
        <IsPackable>false</IsPackable>
        <IsTestProject>true</IsTestProject>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Host.IntegrationTests</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -4,7 +4,6 @@
        <IsPackable>false</IsPackable>
        <IsTestProject>true</IsTestProject>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Host.Tests</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -4,7 +4,6 @@
        <IsPackable>false</IsPackable>
        <IsTestProject>true</IsTestProject>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.OpcUaServer.IntegrationTests</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <!-- OTOPCUA0001 (#595): OpcUaClientDriverWireTests call driver capabilities directly at the wire level on
@@ -4,7 +4,6 @@
        <IsPackable>false</IsPackable>
        <IsTestProject>true</IsTestProject>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.OpcUaServer.Tests</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -4,7 +4,6 @@
        <IsPackable>false</IsPackable>
        <IsTestProject>true</IsTestProject>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Runtime.Tests</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>
@@ -4,7 +4,6 @@
        <IsPackable>false</IsPackable>
        <IsTestProject>true</IsTestProject>
        <RootNamespace>ZB.MOM.WW.OtOpcUa.Security.Tests</RootNamespace>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <ItemGroup>