S7 counter documentation overstates wire encoding and live gate readiness #713
Assignees
dohertj2 (dohertj2)
Clear assignees
dohertj2 (dohertj2)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: dohertj2/lmxopcua#713
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Read-only #616 audit found documentation/source comments asserting S7-300/400 C-area wire words are BCD and S7-1200/1500 C-area raw words are correct, while inspected evidence only establishes instruction-level binary/BCD outputs, not S7comm ReadVar C-area representation.
Sources: docs/drivers/S7.md Counter read; S7Driver.DecodeScalarBlock comments. Existing nonzero device-number gate S7_1500SpanReadTests TimerCounterLayout hardcodes S71500/rack0/slot0 and expects C7 raw31337 from a synthetic profile; this is not a ready classic0..999 semantic-count proof.
Bounded correction: state actual raw-word behavior and evidence limits, distinguish DB/IEC values from C-area wire reads, and correct test remarks/readiness instructions so the synthetic raw-word profile cannot be mistaken for classic hardware count validation. Record required independent PLC count/raw-byte/model/connection evidence under #616. No codec/default/config/transport/assertion changes or live calls. Do not close #616’s hardware gates based on docs/offline work.
Approved three-file documentation/comments correction independently reviewed with no blocking findings, commit
cd50db13. Root confirmed exact non-comment C# text identity and XML documentation parsing; diff whitespace clean. Decoder, config, transport, test assertions/skip strings remain unchanged; historical fixture wording explicitly qualified in remarks. Hardware count/raw-byte/nonzero-numbering evidence remains open under #616. Branch docs/s7-counter-evidence published; PR will follow dependency #711 merge. No builds, test runs or live calls for this documentation-only correction.Reviewed fix published as stacked draft PR #715, temporarily targeting PR #711’s source branch to keep the diff focused. It will be retargeted to master after #711 passes and merges. No merge into the temporary base will be performed. Existing validation evidence remains recorded above; issue stays open until the verified fix is merged.
Merged documentation-only PR #715 after independent review and fresh diff/non-comment identity checks. Both C# files retain exactly the same executable text, assertions, configuration and calls. The guide now states the actual raw-word behavior, distinguishes IEC/DB counters and flags the synthetic S7-1500 fixture limits. #616 remains open for independent target-specific PLC count and wire evidence. No live calls or decoder changes.