1369 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Joseph Doherty	f19f2ee73b	fix(adminui): bind driver-page Error + picker SelectedNodeId as Razor expressions ... Audit (task #134) found the same Razor literal-binding bug class as the UNS Filter fix (14b4692): a string-typed component parameter assigned without a leading @ is a LITERAL, not an expression. Confirmed against the generated .g.cs (literal "_error" vs TypeCheck<String>(_error)). - DriverFormShell Error="_error" -> "@_error" on all 9 driver edit pages: Error received the constant "_error", so the error banner rendered permanently and the real failure message was never shown. - DriverBrowseTree SelectedNodeId="_tagName"/"_nodeId" -> "@..." in the Galaxy and OpcUaClient address pickers: the tree's selected-node highlight compared against a literal that never matched a real node. Build clean; generated code now binds all 11 as TypeCheck<String>(field); AdminUI.Tests 216/216 green.	2026-06-09 07:39:08 -04:00
Joseph Doherty	14b469291a	fix(uns): bind _filter + modal parent-ids as Razor expressions, not literals ... GlobalUns passed string component params without an @ prefix (Filter="_filter", ClusterId="_areaModalClusterId", etc.). Razor treats a string-typed component-parameter value without @ as a LITERAL, so UnsTree.Filter became the literal "_filter" and the modals received literal field-name strings as their parent ids. The non-empty literal filter matched no node, so the tree never rendered children beyond the enterprise roots; the modals would have created children under a bogus cluster/area/line/equipment id. Add @ to the six string-param bindings. Verified live in docker-dev: the full Enterprise->Cluster->Area->Line->Equipment tree renders and an area created via the modal persists with the correct ClusterId (MAIN). No unit test added — this is a Razor binding issue not reachable without bUnit (not used in this project).	2026-06-08 15:15:46 -04:00
Joseph Doherty	8ba64b1d99	fix(uns): enforce #122 on line reparent across clusters (final review)	2026-06-08 14:12:46 -04:00
Joseph Doherty	1bb7482c3a	feat(uns): remove per-cluster UNS/Equipment/Tags + standalone virtual-tag pages ... Deletes the 10 Razor pages superseded by the global /uns tree (Tasks 12–16): ClusterUns, UnsAreaEdit, UnsLineEdit, ClusterEquipment, EquipmentEdit, ImportEquipment, ClusterTags, TagEdit, VirtualTags, VirtualTagEdit. No dangling references found; build is clean.	2026-06-08 14:02:32 -04:00
Joseph Doherty	983d30cb15	fix(uns): guard import save + comma-limitation hint + reset-on-open (review)	2026-06-08 14:00:26 -04:00
Joseph Doherty	7db9a24403	feat(uns): equipment CSV import folded into the tree toolbar	2026-06-08 13:56:01 -04:00
Joseph Doherty	c0346f14ce	feat(uns): tag + virtual-tag modals wired into the tree	2026-06-08 13:47:34 -04:00
Joseph Doherty	d637b834b9	fix(uns): reject equipment bind to non-existent driver + modal-xl (review)	2026-06-08 13:38:33 -04:00
Joseph Doherty	2beaa43d60	feat(uns): equipment modal wired into the tree	2026-06-08 13:31:14 -04:00
Joseph Doherty	0abd1d8fc2	fix(uns): delete-confirm reports not-available instead of false success for unwired kinds (review)	2026-06-08 13:25:15 -04:00
Joseph Doherty	a4a9dc912a	feat(uns): area + line modals wired into the tree	2026-06-08 13:20:25 -04:00
Joseph Doherty	307cec5a3d	test(uns): cover no-script + update-duplicate-name virtual-tag guards (review)	2026-06-08 13:15:10 -04:00
Joseph Doherty	d8fba02a5e	feat(uns): equipment-bound virtual-tag CRUD	2026-06-08 13:11:12 -04:00
Joseph Doherty	77024f87da	fix(uns): reject tag create on non-existent equipment + narrow JSON catch (review)	2026-06-08 13:06:45 -04:00
Joseph Doherty	5a392c5db0	feat(uns): equipment-bound tag CRUD with namespace + cluster guards	2026-06-08 13:00:26 -04:00
Joseph Doherty	ab0ff8aedf	fix(uns): reject driver-bind on unresolvable line + enforce MachineCode uniqueness on update (review)	2026-06-08 12:55:36 -04:00
Joseph Doherty	2836a0704b	feat(uns): equipment CRUD with #122 driver-cluster guard	2026-06-08 12:47:19 -04:00
Joseph Doherty	8b1d3de806	feat(uns): add global UNS nav item, drop per-cluster UNS/Equipment/Tags tabs	2026-06-08 12:45:18 -04:00
Joseph Doherty	ace366ebcf	test(uns): cover #122 allow-when-driver-already-in-target-cluster (review)	2026-06-08 12:42:13 -04:00
Joseph Doherty	4a32edef1a	fix(uns): re-entrancy guard + clear stale error + PageTitle on GlobalUns (review)	2026-06-08 12:39:23 -04:00
Joseph Doherty	47b1d2259f	feat(uns): area + line CRUD with #122 reassignment guard	2026-06-08 12:35:58 -04:00
Joseph Doherty	c9f59e4bd2	feat(uns): GlobalUns page with browsable tree	2026-06-08 12:34:37 -04:00
Joseph Doherty	b33cf1c80d	feat(uns): lazy per-equipment tag + virtual-tag load ... Add LoadEquipmentChildrenAsync to IUnsTreeService and UnsTreeService; returns Tag nodes (ordered by Name) then VirtualTag nodes (ordered by Name) as leaf nodes with ChildCount=0, HasLazyChildren=false, keys tag:{id}/vtag:{id}.	2026-06-08 12:29:52 -04:00
Joseph Doherty	c264441b74	refactor(uns): clarify service lifetime doc + defensive vtag-count null filter (review)	2026-06-08 12:27:29 -04:00
Joseph Doherty	2c0297c1af	fix(uns): @key node rows for stable Blazor diffing (review)	2026-06-08 12:27:19 -04:00
Joseph Doherty	cec670f0c8	feat(uns): IUnsTreeService structural load + DI registration	2026-06-08 12:23:00 -04:00
Joseph Doherty	0f286a70b8	feat(uns): recursive UnsTree renderer	2026-06-08 12:21:38 -04:00
Joseph Doherty	3e8941bce4	docs(uns): clarify HasLazyChildren + cluster EntityId, add tie-break test (review I1/I2/M2)	2026-06-08 12:18:37 -04:00
Joseph Doherty	d9082e22e3	feat(uns): UnsNode VM + pure tree-assembly helper	2026-06-08 12:14:49 -04:00
Joseph Doherty	944732e500	docs(uns): implementation plan + task graph for global UNS management	2026-06-08 12:11:40 -04:00
Joseph Doherty	3361eac6d8	docs(uns): design for global UNS management tree-table	2026-06-08 12:02:18 -04:00
Joseph Doherty	f5ef0991af	docs(adminui): correct equipment help text for driver-less equipment (review I1/M1)	2026-06-08 07:13:45 -04:00
Joseph Doherty	b962b041f3	docs(plan): driver-less equipment — all tasks complete + live-verified	2026-06-08 07:10:14 -04:00
Joseph Doherty	d909a8e4f6	docs+test(deploy): clarify driver-less attribution docs + no-line exclusion test (Task 2 review)	2026-06-08 07:02:25 -04:00
Joseph Doherty	0b5fc44866	fix(adminui): show + clarify driver-less equipment across list/import (Task 1 review)	2026-06-08 07:00:03 -04:00
Joseph Doherty	53eb3fcda5	test(config): DraftValidator accepts driver-less equipment + driverless equipment namespace	2026-06-08 06:56:22 -04:00
Joseph Doherty	c688899134	fix(deploy): cluster-attribute driver-less equipment via its UNS line area (BuildClusterSets)	2026-06-08 06:53:41 -04:00
Joseph Doherty	d2dbf7b0d7	feat(config): make Equipment.DriverInstanceId nullable + driver-less AdminUI support + migration	2026-06-08 06:49:28 -04:00
Joseph Doherty	a94d03a194	docs(plan): driver-less equipment namespace implementation plan (#143-147)	2026-06-08 06:40:14 -04:00
Joseph Doherty	064adb0bd0	docs(design): driver-less equipment namespace (nullable Equipment.DriverInstanceId, drop Modbus placeholder)	2026-06-08 06:36:40 -04:00
Joseph Doherty	446a45686f	docs(plan): mark all VirtualTag/script-memory Phase-1 tasks complete	2026-06-07 15:57:43 -04:00
Joseph Doherty	92d1df88f4	fix(deploy): guardrail estimate is best-effort, never blocks a valid deploy ... Wrap the script compile-cost guardrail block in its own inner try/catch so a transient SQL failure on ToListAsync cannot fall through to the outer catch and produce a Rejected reply for an otherwise-valid deploy. advisory is declared in the outer scope so the Accepted StartDeploymentResult Message is unaffected on the happy path; the inner catch logs a Warning and leaves advisory null.	2026-06-07 15:40:06 -04:00
Joseph Doherty	cfbf0b2a17	feat(deploy): warn-only script-compile-cost advisory on deploy	2026-06-07 15:36:09 -04:00
Joseph Doherty	b73ce75402	harden(vtag): exclude backslash from passthrough capture + parity tests (A review)	2026-06-07 15:31:54 -04:00
Joseph Doherty	08d7477860	feat(vtag): passthrough fast-path skips Roslyn for mirror scripts (A)	2026-06-07 15:26:20 -04:00
Joseph Doherty	3834400f05	test(mem-probe): confirm A0 drops production per-script RSS ~11x (18->~1.66 MiB) ... Swap MemProbe's ProjectReference from Core.VirtualTags to Core.Scripting.Abstractions so the heavy-mode globalsType (ScriptGlobals<VirtualTagContext>) resolves from the post-A0 Roslyn-free assembly. Measured results (2026-06-07, N=50, Release): heavy (post-A0): 2.40 / 2.53 MiB/script (was ~18 MiB) lean: 1.64 / 1.65 MiB/script => heavy ≈ lean; both well under the 3 MiB gate. PASS.	2026-06-07 15:19:02 -04:00
Joseph Doherty	1827c51c42	refactor(scripting): clarify sandbox-pin invariant + add RootNamespace (A0 review)	2026-06-07 15:16:14 -04:00
Joseph Doherty	56cac39216	refactor(scripting): extract script-callable types into Roslyn-free Core.Scripting.Abstractions (A0)	2026-06-07 15:10:00 -04:00
Joseph Doherty	df772dd09a	docs(plan): VirtualTag/script memory Phase-1 implementation plan (A0+A+guardrail)	2026-06-07 15:00:11 -04:00
Joseph Doherty	321d57938f	docs(design): VirtualTag/script memory scalability (A0+A+guardrail; C2 deferred) + measurement harness	2026-06-07 14:55:28 -04:00