6 Commits

Author	SHA1	Message	Date
Joseph Doherty	1806af54f0	fix(ab): Task 22 review r1 — release-note timing and AbLegacy regressions, probe E2E on both transports ... - I1: the upgrade restart itself moves every no-key AbCip/AbLegacy driver to Native (every process start constructs drivers, incl. boot-from-cache). Docs + CLAUDE.md now say so and tell operators to set "transport": "Libplctag" BEFORE upgrading (older builds ignore the unknown key). - I2: AbLegacy release note leads with the status-bit write refusal (T4:0.DN, C5:0.CU, R6:0.EN, ...) on defaulted SLC/MicroLogix drivers and the fallback. The real client status is BadCommunicationError, not BadNotSupported (the driver's write catch-all maps the runtime's AbTransportException like any transport failure, as #571 does for PLC-5), with handle eviction and Degraded health; pinned by a driver-level test (no 0xAA write on the wire, with a positive control). ST string byte order stated as unverified. Also corrects the docs' "T4:0/DN" examples: the driver's address grammar is "T4:0.DN" ("/DN" is a malformed address). - I3: DriverProbeHandshakeE2eTests' two AbCip probe tests are a [Theory] over Native and Libplctag. Run against ab_server controllogix: all 4 rows pass with identical exact messages. - M1: documented (docs + resolver XML doc): the AdminUI merges only the probed device, so a mixed-family defaulted AbLegacy driver can probe Native while running Libplctag. - M2: factory ParseEnum rejects undefined integer strings ("7") via Enum.IsDefined (both drivers). - M3: AbCip driver-level bad value reads "AB CIP config in '<id>' has unknown Transport ..."; the named constant is gone (tagName: null now means driver-level). - M4: the explicit-Native limited-family Warning is once per instance, not per (re)init. - Nit: EffectiveTransport docs note that injected factories bypass it. Claude-Session: https://claude.ai/code/session_01Ef2ozxS7QPanGT8uoATbTe	2026-10-07 21:06:40 -04:00
Joseph Doherty	ed0881d672	feat(ab): native managed transport is the default for AbCip and AbLegacy; libplctag remains as fallback ... Task 22 (spec section 8 P5), with the controller rulings that exclude PLC-5 and LogixPccc. - Transport is nullable on both option records; null (key absent) means "use the default" and is never serialized. Factory DTO parse: absent -> null; a bad value still fails via ParseEnum. - One resolver per driver (AbCipTransportResolver / AbLegacyTransportResolver), used by the driver constructor, the Test Connect probe and (through the driver) the CLI. AbCip: null -> Native. AbLegacy: null -> Native unless any device is Plc5 or LogixPccc, then the whole driver resolves to Libplctag. Explicit values always win; explicit Native with a Plc5/LogixPccc device logs one Warning at init. - Init log shows configured vs effective, e.g. transport=Native (default). - AdminUI forms: "Default (...)" / "Native (managed)" / "libplctag (fallback)". Default omits the key on save (reverses Task 19's explicit re-emit, which would have pinned every edited driver). - CLIs: --transport default|native|libplctag, default "default" via the resolver, so --plc-type Plc5 with no --transport runs libplctag. - Tests pinned to Libplctag where a default-path runtime was created: found by instrumenting the native factories with the current xUnit test name (one unit test, AbLegacyReinitConfigAdoption; plus the two fixture-gated AbCip probe E2E tests whose exact messages were proven on libplctag). TransportMatrix and the differential harness already pass explicit transports. - Switch/resolver/CLI/form tests are falsified by mutating the resolver (default -> Libplctag, exclusion removed, AbLegacy default -> Libplctag): each mutation turns them red. - Replaces the inline role-name literal in AbCipDriverFactoryExtensions' ParseEnum call with a named constant; RoleAuthorityGuardTests was already red on the base commit for that line. - Docs: AbCip.md / AbLegacy.md default + release note; CLAUDE.md AB section. Claude-Session: https://claude.ai/code/session_01Ef2ozxS7QPanGT8uoATbTe	2026-10-07 20:49:33 -04:00
Joseph Doherty	6b3da93151	fix(browse): commit the browsed data type, and fix the probe classification the fixture was hiding (#536) ... A browse-committed AB CIP / TwinCAT / FOCAS tag bound with its model's DEFAULT data type, not the one the device reported. A browsed REAL committed as `{"tagPath":"Pump_1_Speed","dataType":"DInt"}` — and those three drivers decode the wire bytes by that field, not by the raw row's OPC UA DataType — so the tag read four bytes of a float through an integer decoder and published a plausible wrong number with no error raised anywhere. FOCAS was missed when #536 was filed. The type is CARRIED, not derived. Reverse-mapping the leaf's driver-agnostic DriverDataType looks like the smaller fix and is wrong: SInt/Int/DInt/USInt/UInt all collapse into Int32 on the way out of the driver, so that version would bind a 16-bit INT as a 32-bit DINT while appearing to fix the REAL. Drivers now state their own type name on DriverAttributeInfo.NativeDataType, which reaches the picker as AttributeInfo.AddressFields["dataType"] and the commit mapper from there. A leaf that states nothing keeps the model default — the pre-#536 behaviour, kept deliberately as the fallback rather than a guess. Numeric strings are refused before parsing: Enum.TryParse accepts "9" for any enum and Enum.IsDefined then confirms it, so an unguarded parse would bind a tag to a type nobody named. A test caught this in the first version of the guard. --- and the other half, which the fixture was hiding --- Test Connect on a device with NO authored tags — every AB CIP device at the moment an operator first presses the button — reported "CIP handshake failed" against a healthy controller. That was written down as a fixture limitation ("ab_server doesn't implement @raw_cpu_type"). Both halves of that were wrong: * @raw_cpu_type is not a libplctag special tag at all (only @raw, @tags and @udt/ are), so it goes out as an ordinary symbolic name that no controller defines, and the controller's "tag does not exist" IS the successful answer. * ab_server answered an unresolvable tag path with CIP 0x03 where a Logix controller answers 0x04 — ErrorBadParam vs ErrorNotFound, which the probe classifies oppositely. Fixed in vendored patch 0002. * With the fixture then telling the truth, the real defect surfaced: AbCipDriverProbe.IsReachableException matched the native C status spellings ("STATUS_NOT_FOUND"), but libplctag.NET throws with the MANAGED enum name ("ErrorNotFound"). Those substrings can never match, so the reachable classification could not fire on the exception path — which is the path every no-authored-tags probe takes. This was failing on real hardware too, not just against the sim. It now recovers the Status and defers to IsReachableStatus, so there is one classification rather than two that can drift. Rejected: switching the fallback to @tags. libplctag builds a tag-listing tag with NO network I/O, so it reports OK against any TCP listener — measured green against a Mosquitto broker. Verification: full solution suite green. Falsification runs confirm exactly the intended tests go red — 9 for the type carry, 3 (the reachable statuses only) for the probe classification. Live on docker-dev: browse-committed TestString/ Motor_Run/TestSINT now store String/Bool/SInt, alongside last session's Pump_1_Speed still holding the wrong DInt. TestSINT is the falsifier — its row DataType is Int32, identical to TestDINT's, so no reverse map could have produced "SInt". Known consequence: pre-existing browse-committed tags keep their wrong dataType; the fix applies to new commits only. Claude-Session: https://claude.ai/code/session_015p7wGqy3YpZNCpDzTpGMKo	2026-08-01 15:20:07 -04:00
Joseph Doherty	df340b8bba	fix(tests): three real failures the integration suite had stopped catching ... None of these were fixture absence. Each is a guard that went quietly wrong and then reported the wrong thing. PrimaryGateFailoverTests — per-cluster mesh Phase 6 (a2c5d57f) moved RedundancyStateActor out of WithOtOpcUaControlPlaneSingletons into its own cluster-role-scoped registration, made from Program.cs's DRIVER branch. The harness models a fused admin,driver node but was never updated, so from that commit onward NO node it built spawned the singleton: nothing published redundancy-state, both nodes sat at "role unknown" forever, and the test polled 45s and timed out. The test's own summary calls this its negative control for a broken redundancy-topic subscribe — it fired correctly, at the harness rather than at production. Second time this shape has bitten the harness; the AddOtOpcUaRuntime note a few lines up records the first. DriverProbeRegistrationTests — the expected driver set was a hand-written array kept in sync by comment, and it drifted when Sql (9b5a9687) and Mqtt (f79d13e2) shipped. It failed as "12 where 10 expected", which names neither driver and reads as if the probes were wrong. It also could not catch the direction that matters: a driver type registered with no probe passed silently, because a hand-written list only grows when someone remembers, and this test exists for the case where nobody did. Now derived from DriverTypeNames.All, both directions, plus an explicit case-drift test for the two types whose AdminUI key differs in case from the constant (TwinCat/TwinCAT, Focas/FOCAS) — which the derived tests cannot cover, since they compare the constants to themselves. DriverProbeHandshakeE2eTests.AbCip_Green_AgainstSim — the probe config still used the retired v2 `Tags: [{DeviceHostAddress, TagPath}]` shape, so AbCipDriverOptions.RawTags bound empty, the probe fell through to its @raw_cpu_type system-tag fallback, and ab_server answered ErrorBadParam. The test has therefore spent the whole v3 migration exercising the one path its own comment says it does not exercise. Rewritten to the v3 RawTags shape, and the assertion tightened from ShouldContain("CIP session OK") to an exact match: the probe's two green messages both contain that substring, so the loose form would go green again the moment the config merely reached the controller, whether or not the authored tag resolved. Falsified each: drop the MTConnect probe (2 red, by name), remove the harness singleton registration (back to the 48s "role unknown" timeout), break the RawTags key (back to ErrorBadParam). Host.IntegrationTests 211 passed / 4 skipped / 0 failed, against live fixtures on 10.100.0.35. Still red and NOT addressed here: the AbLegacy integration suite (4 tests). Its fixture is genuinely down, but it hard-fails instead of skipping because the AbCip ControlLogix container holds :44818 — the reachability guard cannot tell "my ab_server" from "someone else's", so SkipReason stays null and SLC500-mode PCCC runs against a ControlLogix. Needs either distinct fixture ports or a family-aware guard; both are shared-infrastructure changes. Claude-Session: https://claude.ai/code/session_015p7wGqy3YpZNCpDzTpGMKo	2026-08-01 02:09:15 -04:00
Joseph Doherty	4b14feb373	fix(drivers): serialize driver-config enums as strings in AdminUI pages + probes ... AdminUI driver-instance pages serialized enum config fields (S7 CpuType, Modbus DataType/Region, AbCip PlcFamily, ...) as JSON *numbers* because each page's _jsonOpts lacked a JsonStringEnumConverter. The driver factories, however, deserialize into string-typed DTOs (+ lenient ParseEnum) and throw when binding a JSON number to a string? — so an AdminUI-authored config containing any enum field produced a blob the driver could not parse, faulting the driver on deploy. Proven end-to-end for S7 and Modbus; latent for AbCip/AbLegacy/TwinCAT/FOCAS/Galaxy/Historian. Only OpcUaClient was safe (its factory + probe already carried the converter). Add JsonStringEnumConverter to all 9 driver-instance pages' _jsonOpts and the 8 missing driver probes' _opts (factories unchanged — already string-via- ParseEnum; strictly more permissive, also lets pages load hand-seeded string-enum configs back into the form). Also fix DriverProbeHandshakeE2eTests.AbCip_Green_AgainstSim to probe a real sim tag (TestDINT) — the no-tags @raw_cpu_type fallback is rejected by the ab_server sim with ErrorBadParam (a real ControlLogix returns ErrorNotFound, which the probe treats as reachable; hardware-gated follow-up). Tests: reflection guard over all driver pages' _jsonOpts (AdminUI.Tests); factory round-trip + numeric-form-throws guards for S7 and Modbus. Found by running the never-before-run FB-9/FB-10 live verifies.	2026-06-19 04:52:47 -04:00
Joseph Doherty	1164d423b6	fix(probe): Galaxy gRPC ping — drop invalid Retry, treat MxGatewayAuth exceptions as reachable (live /run) ... Two bugs caught by live verification against the mxaccessgw at 10.100.0.48:5120: - MaxAttempts=1 produced an invalid Polly RetryStrategyOptions -> the probe failed on every real gateway. Removed the Retry override (matches GalaxyDriver); fail-fast is already guaranteed by the TCP preflight + the per-call deadline. - A rejected key surfaces as a typed MxGatewayAuthenticationException, not a raw RpcException, so 'auth-rejection = reachable' was bypassed. Catch the typed auth/ authorization exceptions -> Ok=true. Adds DriverProbeHandshakeE2eTests: direct-probe, skip-gated cross-protocol green/red discrimination (Modbus, OpcUaClient, Galaxy + a local real OPC UA server).	2026-06-16 07:32:59 -04:00