fix(ablegacy): review fixes - one family-aware address authority in Contracts, deploy gate + editor check, malformed address -> BadNodeIdUnknown warned once, probe normalised, octal/migration docs (#244 #245 #247)

Claude-Session: https://claude.ai/code/session_01Ef2ozxS7QPanGT8uoATbTe
2026-10-08 14:38:25 -04:00
parent 0dc09329b7
commit d8f3dd7394
10 changed files with 291 additions and 15 deletions
@@ -68,8 +68,11 @@ public sealed class AbLegacyTagConfigModel
        if (TagConfigJson.DescribeInvalidEnum<AbLegacyDataType>(_bag, "dataType") is { } dtError)
            return dtError;

-        if (string.IsNullOrWhiteSpace(Address))
-            return "Address is required.";
+        // The editor cannot see the device's PLC family, so it checks only what no family accepts (the same
+        // AbLegacyAddress authority the deploy gate and runtime use) — never stricter than the gate, which adds the
+        // family-specific verdict (PLC-5 octal I/O, MicroLogix-only function files).
+        if (AbLegacyAddress.Validate(Address, family: null) is { } addressError)
+            return addressError;

        // DELIBERATELY STRICTER THAN THE RUNTIME, and re-confirmed as such by the Gitea #554 survey — do not
        // "align" it. PCCC data-file elements are limited to AbLegacyArray.MaxElements (256). The reader