fix(opcuaclient): unresolvable acks warn instead of tripping the ack breaker; shutdown holds subscription management (review r1 N-1, N-2, N-3)
- N-1 (Important): m3's BadNodeIdUnknown throw for an ack with no resolvable condition counted toward the host's AlarmAcknowledge breaker (threshold 5), so re-acks of one unresolvable condition blocked every genuine ack. It now logs a Warning and returns; only a no-reply transport failure throws. Test through the real CapabilityInvoker: six unresolvable acks, then a genuine ack that is still delivered (red with the throw restored). - N-2: ShutdownAsync holds _subscriptionGate for the whole teardown (in-flight subscribes finish first, bounded by the budget), so a subscribe arriving during the delete phase finds the session released instead of creating a subscription on the closing session. Red-tested. - N-3: the shutdown-side cert-validation detach is generation-checked under _probeLock with the map / endpoint clear. Refs #743 Claude-Session: https://claude.ai/code/session_01Ub9hGmYLQvn9XETzw7CMsT
This commit is contained in:
+40
@@ -217,4 +217,44 @@ public sealed class OpcUaClientLifecycleGenerationTests
|
||||
while ((current = Volatile.Read(ref target)) < value)
|
||||
if (Interlocked.CompareExchange(ref target, value, current) == current) return;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// r1 N-2: a subscribe that arrives while shutdown is in its delete phase must not create a subscription on the
|
||||
/// closing session (it would register after the registry was enumerated and outlive the shutdown). It waits for
|
||||
/// the teardown and then finds no session. Positive control: before the shutdown the same subscribe reaches the
|
||||
/// session.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public async Task A_subscribe_during_the_shutdown_delete_phase_never_touches_the_closing_session()
|
||||
{
|
||||
using var drv = new OpcUaClientDriver(Options(), "opcua-n2");
|
||||
var session = NewSession();
|
||||
drv.SetSessionForTest(session.Object);
|
||||
drv.SetNamespaceMapForTest(NamespaceMap.FromTable(new NamespaceTable(), Tags));
|
||||
|
||||
// Positive control: an ordinary subscribe does reach the session (the mock then fails the create).
|
||||
await Should.ThrowAsync<Exception>(() =>
|
||||
drv.SubscribeAsync([SpeedRef], TimeSpan.FromSeconds(1), TestContext.Current.CancellationToken));
|
||||
session.Verify(s => s.AddSubscription(It.IsAny<Subscription>()), Times.Once);
|
||||
|
||||
var deleting = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
var releaseDelete = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
drv.DeleteSubscriptionAsync = async (_, _) =>
|
||||
{
|
||||
deleting.TrySetResult();
|
||||
await releaseDelete.Task;
|
||||
};
|
||||
drv.AddSubscriptionForTest([SpeedRef]);
|
||||
|
||||
var shutdown = drv.ShutdownAsync(TestContext.Current.CancellationToken);
|
||||
await deleting.Task.WaitAsync(TimeSpan.FromSeconds(10), TestContext.Current.CancellationToken);
|
||||
|
||||
var lateSubscribe = drv.SubscribeAsync([SpeedRef], TimeSpan.FromSeconds(1), TestContext.Current.CancellationToken);
|
||||
releaseDelete.SetResult();
|
||||
await shutdown.WaitAsync(TimeSpan.FromSeconds(10), TestContext.Current.CancellationToken);
|
||||
await Should.ThrowAsync<Exception>(() => lateSubscribe.WaitAsync(TimeSpan.FromSeconds(10), TestContext.Current.CancellationToken));
|
||||
|
||||
session.Verify(s => s.AddSubscription(It.IsAny<Subscription>()), Times.Once,
|
||||
"the late subscribe must not have created anything on the closing session");
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user