dohertj2/lmxopcua
1
0
Fork 0
Code Issues 32 Pull Requests Actions Packages Projects Releases Wiki Activity

Review remediation: Lane G1 — OpcUaClient + MTConnect #743

New Issue
Open
opened 2026-10-22 06:05:20 -04:00 by dohertj2 · 0 comments
dohertj2 commented 2026-10-22 06:05:20 -04:00
Owner
Copy Link
Copy Source

From the 2026-10-21 Fable system review. Findings R0x:ID refer to docs/reviews/2026-10-21/0x-*.md (location, evidence, failure scenario, fix recipe). Plan: docs/superpowers/plans/2026-10-22-review-remediation.md.

Lane G1 — OpcUaClient + MTConnect

OpcUaClient:

  • Data-subscribe cleanup on throw (R06:O-1).
  • Ack rethrows the transport status (O-8).
  • Split the read/write gate from subscription management; no gate across the recursive browse (O-6).
  • Close the local session on an init throw (O-2).
  • One teardown budget (O-9).
  • Wire ProbeTimeoutSeconds (O-4).
  • Browse AttributesAsync real + certificate-auth browse (O-5).

MTConnect:

  • Generation guard on cursor publish (T-1).
  • Read through the live index when the pump is healthy (T-4).
  • Lag metric + adaptive count (T-5).
  • Instance-id check in ReadAsync (T-2).
  • Delete dead parsed fields (T-3).
  • Batched PUT (T-6).
  • Headers-only probe (T-7).
  • Redacted URI everywhere (T-8).
From the 2026-10-21 Fable system review. Findings `R0x:ID` refer to `docs/reviews/2026-10-21/0x-*.md` (location, evidence, failure scenario, fix recipe). Plan: `docs/superpowers/plans/2026-10-22-review-remediation.md`. ### Lane G1 — OpcUaClient + MTConnect **OpcUaClient:** - Data-subscribe cleanup on throw (`R06:O-1`). - Ack rethrows the transport status (`O-8`). - Split the read/write gate from subscription management; no gate across the recursive browse (`O-6`). - Close the local session on an init throw (`O-2`). - One teardown budget (`O-9`). - Wire `ProbeTimeoutSeconds` (`O-4`). - Browse `AttributesAsync` real + certificate-auth browse (`O-5`). **MTConnect:** - Generation guard on cursor publish (`T-1`). - Read through the live index when the pump is healthy (`T-4`). - Lag metric + adaptive `count` (`T-5`). - Instance-id check in `ReadAsync` (`T-2`). - Delete dead parsed fields (`T-3`). - Batched PUT (`T-6`). - Headers-only probe (`T-7`). - Redacted URI everywhere (`T-8`).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#743
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?