chore(build): OpcUaClient driver/browser on ITelemetryContext ctors, TreatWarningsAsErrors on remaining src projects (#621 #606)

Claude-Session: https://claude.ai/code/session_01Ef2ozxS7QPanGT8uoATbTe

src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient.Browser/OpcUaClientDriverBrowser.cs

@@ -124,17 +124,13 @@ public sealed class OpcUaClientDriverBrowser : IDriverBrowser
     /// <param name="ct">Cancellation token for the configuration build.</param>
     private static async Task<ApplicationConfiguration> BuildBrowseAppConfigurationAsync(CancellationToken ct)
     {
-        // The default ctor is obsolete in favour of the ITelemetryContext overload; suppress
-        // locally rather than plumbing a telemetry context all the way through — the browser
-        // emits no per-request telemetry of its own and the SDK's internal fallback is fine
-        // for a transient picker session (mirrors the runtime driver's same suppression).
-#pragma warning disable CS0618
-        var app = new ApplicationInstance
+        // The ITelemetryContext overload is the non-obsolete ctor; an empty builder keeps SDK
+        // internals off any logging provider.
+        var app = new ApplicationInstance(BrowseTelemetry.Context)
         {
             ApplicationName = "OtOpcUa AdminUI Browse",
             ApplicationType = ApplicationType.Client,
         };
-#pragma warning restore CS0618
 
         var pkiRoot = Path.Combine(
             Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData),
@@ -245,3 +241,11 @@ public sealed class OpcUaClientDriverBrowser : IDriverBrowser
     private static string ShortName(string uri) =>
         uri?.Substring(uri.LastIndexOf('#') + 1) ?? "(null)";
 }
+
+internal static class BrowseTelemetry
+{
+    private static readonly Lazy<Opc.Ua.ITelemetryContext> Instance = new(() => Opc.Ua.DefaultTelemetry.Create(_ => { }));
+
+    /// <summary>Gets the shared telemetry context.</summary>
+    public static Opc.Ua.ITelemetryContext Context => Instance.Value;
+}

src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient/OpcUaClientDriver.cs

@@ -294,17 +294,13 @@ public sealed class OpcUaClientDriver : IDriver, ITagDiscovery, IReadable, IWrit
     /// </summary>
     private async Task<ApplicationConfiguration> BuildApplicationConfigurationAsync(CancellationToken ct)
     {
-        // The default ctor is obsolete in favour of the ITelemetryContext overload; suppress
-        // locally rather than plumbing a telemetry context all the way through the driver
-        // surface — the driver emits no per-request telemetry of its own and the SDK's
-        // internal fallback is fine for a gateway use case.
-#pragma warning disable CS0618
-        var app = new ApplicationInstance
+        // The ITelemetryContext overload is the non-obsolete ctor; an empty builder keeps SDK
+        // internals off any logging provider (mirrors Client.Shared's ClientTelemetry).
+        var app = new ApplicationInstance(SdkTelemetry.Context)
         {
             ApplicationName = _options.SessionName,
             ApplicationType = ApplicationType.Client,
         };
-#pragma warning restore CS0618
 
         var pkiRoot = Path.Combine(
             Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData),
@@ -472,7 +468,7 @@ public sealed class OpcUaClientDriver : IDriver, ITagDiscovery, IReadable, IWrit
         endpointConfig.OperationTimeout = (int)_options.Timeout.TotalMilliseconds;
         var endpoint = new ConfiguredEndpoint(null, selected, endpointConfig);
 
-        var session = await new DefaultSessionFactory(telemetry: null!).CreateAsync(
+        var session = await new DefaultSessionFactory(SdkTelemetry.Context).CreateAsync(
             appConfig,
             endpoint,
             false,                                              // updateBeforeConnect

src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient/SdkTelemetry.cs

@@ -0,0 +1,16 @@
+using Opc.Ua;
+
+namespace ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient;
+
+/// <summary>
+///     The one <see cref="ITelemetryContext" /> the driver hands the SDK's non-obsolete (telemetry-taking)
+///     overloads. An empty builder keeps SDK internals off any logging provider (mirrors Client.Shared's
+///     <c>ClientTelemetry</c>).
+/// </summary>
+internal static class SdkTelemetry
+{
+    private static readonly Lazy<ITelemetryContext> Instance = new(() => DefaultTelemetry.Create(_ => { }));
+
+    /// <summary>Gets the shared telemetry context.</summary>
+    public static ITelemetryContext Context => Instance.Value;
+}