dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Migrate off obsolete OPC UA SDK APIs (Utils.Log*, sync Session/Discovery calls) #621

New Issue
Closed
opened 2026-10-08 02:31:16 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-08 02:31:16 -04:00
Owner
Copy Link
Copy Source

The node manager suppresses Utils.LogWarning/LogError at 8 sites pending an ITelemetryContext rewire, so those diagnostics bypass Serilog. Client.Shared and OpcUaClient still call obsolete sync APIs unsuppressed (Session.Create, SessionObsolete.Close, SubscriptionObsolete.Delete, DiscoveryClient.Create/GetEndpoints, parameterless ApplicationInstance()/ServiceMessageContext()) — 20 CS0618 warnings; the next SDK bump makes them errors.
Sources: OtOpcUaNodeManager.cs:156,727,1027,1446,1484,2155,2240,2603; OpcUaClientDriver.cs:301; OpcUaClientDriverBrowser.cs:131; deferment.md §4.3.

  • Route node-manager logging through ILogger/ITelemetryContext
  • Move Client.Shared + the OpcUaClient driver/browser to async, telemetry-aware overloads

Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep.

The node manager suppresses `Utils.LogWarning/LogError` at 8 sites pending an `ITelemetryContext` rewire, so those diagnostics bypass Serilog. Client.Shared and OpcUaClient still call obsolete sync APIs unsuppressed (`Session.Create`, `SessionObsolete.Close`, `SubscriptionObsolete.Delete`, `DiscoveryClient.Create/GetEndpoints`, parameterless `ApplicationInstance()`/`ServiceMessageContext()`) — 20 CS0618 warnings; the next SDK bump makes them errors. Sources: OtOpcUaNodeManager.cs:156,727,1027,1446,1484,2155,2240,2603; OpcUaClientDriver.cs:301; OpcUaClientDriverBrowser.cs:131; deferment.md §4.3. - [ ] Route node-manager logging through `ILogger`/`ITelemetryContext` - [ ] Move Client.Shared + the OpcUaClient driver/browser to async, telemetry-aware overloads _Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep._
dohertj2 added the driver/opcuaclient label 2026-10-08 02:31:16 -04:00
dohertj2 commented 2026-10-08 09:24:35 -04:00
Author
Owner
Copy Link
Copy Source

Resolved on master (merges b176469b, 9b159025, 5a5f9b22).

  • Node-manager logging routed through an injected ILogger; the Utils.Log* calls and their CS0618 suppressions are gone (8d5e456c).
  • Client.Shared moved to the async SDK APIs (48bd266e); the OpcUaClient driver and browser use the telemetry-aware ctors (ITelemetryContext) (b007d450); the last CS0618 suppressions in the test project were removed. No #pragma warning disable CS0618 remains in src/ or tests/.

Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).

Resolved on master (merges b176469b, 9b159025, 5a5f9b22). - [x] Node-manager logging routed through an injected `ILogger`; the `Utils.Log*` calls and their CS0618 suppressions are gone (8d5e456c). - [x] Client.Shared moved to the async SDK APIs (48bd266e); the OpcUaClient driver and browser use the telemetry-aware ctors (`ITelemetryContext`) (b007d450); the last CS0618 suppressions in the test project were removed. No `#pragma warning disable CS0618` remains in src/ or tests/. *Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).*
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label driver/opcuaclient
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#621
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?