fix(ablegacy): stamp health from the injectable Clock; drop the redundant per-project TreatWarningsAsErrors (lmxopcua#768)

AbLegacyDriver stamped LastSuccessfulRead (init, read, write), the read's sample
timestamps and host-state change times from raw DateTime.UtcNow; only the backoff
path read the injectable Clock. All of them now read Clock(), so
NativePcccBridgeStatusHealthTests drives a manual clock (init at T0, read at T1)
and asserts LastSuccessfulRead == T1 exactly instead of spin-waiting for the wall
clock to pass the init stamp (#767). Without the driver change the 6 tests fail
(init stamp is wall-clock, not T0).

Directory.Build.props sets TreatWarningsAsErrors for every project since #766, so
the 75 per-csproj copies (64 src + 11 tests) are removed and the props comment
says it is now the only place. tools/mem-probe keeps its explicit opt-out.
Release build: 0 warnings, 0 errors; a planted CS0168 still fails the build in a
src project and in a test project that used to carry its own copy.

Claude-Session: https://claude.ai/code/session_01GT67AEHd2Acv1YPwGfXEoV

This commit is contained in:

Joseph Doherty

2026-11-09 13:40:07 -05:00

parent c904472af2

commit 919009c5ef

78 changed files with 39 additions and 107 deletions

									
										src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Historian.Gateway/ZB.MOM.WW.OtOpcUa.Driver.Historian.Gateway.csproj
									
		-1
	
												View File
												
				@@ -1,7 +1,6 @@

				<Project Sdk="Microsoft.NET.Sdk">

				    <PropertyGroup>

				        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>

				        <GenerateDocumentationFile>true</GenerateDocumentationFile>

				        <NoWarn>$(NoWarn);CS1591</NoWarn>

				        <Platforms>AnyCPU;x64</Platforms>