fix(browse): commit the browsed data type, and fix the probe classification the fixture was hiding (#536)

A browse-committed AB CIP / TwinCAT / FOCAS tag bound with its model's DEFAULT
data type, not the one the device reported. A browsed REAL committed as
`{"tagPath":"Pump_1_Speed","dataType":"DInt"}` — and those three drivers decode
the wire bytes by that field, not by the raw row's OPC UA DataType — so the tag
read four bytes of a float through an integer decoder and published a plausible
wrong number with no error raised anywhere. FOCAS was missed when #536 was filed.

The type is CARRIED, not derived. Reverse-mapping the leaf's driver-agnostic
DriverDataType looks like the smaller fix and is wrong: SInt/Int/DInt/USInt/UInt
all collapse into Int32 on the way out of the driver, so that version would bind
a 16-bit INT as a 32-bit DINT while appearing to fix the REAL. Drivers now state
their own type name on DriverAttributeInfo.NativeDataType, which reaches the
picker as AttributeInfo.AddressFields["dataType"] and the commit mapper from
there. A leaf that states nothing keeps the model default — the pre-#536
behaviour, kept deliberately as the fallback rather than a guess.

Numeric strings are refused before parsing: Enum.TryParse accepts "9" for any
enum and Enum.IsDefined then confirms it, so an unguarded parse would bind a tag
to a type nobody named. A test caught this in the first version of the guard.

--- and the other half, which the fixture was hiding ---

Test Connect on a device with NO authored tags — every AB CIP device at the
moment an operator first presses the button — reported "CIP handshake failed"
against a healthy controller. That was written down as a fixture limitation
("ab_server doesn't implement @raw_cpu_type"). Both halves of that were wrong:

  * @raw_cpu_type is not a libplctag special tag at all (only @raw, @tags and
    @udt/ are), so it goes out as an ordinary symbolic name that no controller
    defines, and the controller's "tag does not exist" IS the successful answer.
  * ab_server answered an unresolvable tag path with CIP 0x03 where a Logix
    controller answers 0x04 — ErrorBadParam vs ErrorNotFound, which the probe
    classifies oppositely. Fixed in vendored patch 0002.
  * With the fixture then telling the truth, the real defect surfaced:
    AbCipDriverProbe.IsReachableException matched the native C status spellings
    ("STATUS_NOT_FOUND"), but libplctag.NET throws with the MANAGED enum name
    ("ErrorNotFound"). Those substrings can never match, so the reachable
    classification could not fire on the exception path — which is the path every
    no-authored-tags probe takes. This was failing on real hardware too, not just
    against the sim. It now recovers the Status and defers to IsReachableStatus,
    so there is one classification rather than two that can drift.

Rejected: switching the fallback to @tags. libplctag builds a tag-listing tag
with NO network I/O, so it reports OK against any TCP listener — measured green
against a Mosquitto broker.

Verification: full solution suite green. Falsification runs confirm exactly the
intended tests go red — 9 for the type carry, 3 (the reachable statuses only) for
the probe classification. Live on docker-dev: browse-committed TestString/
Motor_Run/TestSINT now store String/Bool/SInt, alongside last session's
Pump_1_Speed still holding the wrong DInt. TestSINT is the falsifier — its row
DataType is Int32, identical to TestDINT's, so no reverse map could have produced
"SInt".

Known consequence: pre-existing browse-committed tags keep their wrong dataType;
the fix applies to new commits only.

Claude-Session: https://claude.ai/code/session_015p7wGqy3YpZNCpDzTpGMKo

tests/Server/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests/DriverProbeHandshakeE2eTests.cs

@@ -173,11 +173,7 @@ public sealed class DriverProbeHandshakeE2eTests
     {
         SkipUnless(DockerHost, AbCipPort);
         // Probe an explicit tag that the ab_server ControlLogix sim actually defines
-        // (`TestDINT:DINT[1]`). The no-tags fallback (`@raw_cpu_type`) is NOT exercised here:
-        // ab_server answers an unknown/unsupported tag with libplctag ErrorBadParam (a REAL
-        // ControlLogix instead returns ErrorNotFound, which the probe classifies as
-        // reachable). Whether the `@raw_cpu_type` system-tag fallback is valid on a real
-        // ControlLogix is a hardware-gated follow-up (AbCipDriverOptions.cs flags it deferred).
+        // (`TestDINT:DINT[1]`). The no-tags fallback is exercised separately, below.
         // ⚠️ The config must use the v3 `RawTags` shape — `[{RawPath, TagConfig, WriteIdempotent,
         // DeviceName}]`, where the Logix tag path lives inside the TagConfig blob as `tagPath`. This
         // test passed the retired v2 `Tags: [{DeviceHostAddress, TagPath}]` shape until 2026-08-01, so
@@ -200,4 +196,34 @@ public sealed class DriverProbeHandshakeE2eTests
         // ever resolved. Reading the authored tag is the entire point of this test.
         result.Message.ShouldBe("CIP session OK");
     }
+
+    /// <summary>
+    ///     Test Connect on a device with NO authored tags — which is every AB CIP device at the moment
+    ///     an operator first presses the button — must report the controller as reachable.
+    /// </summary>
+    /// <remarks>
+    ///     The probe falls back to a name no controller defines, so the green answer arrives as a CIP
+    ///     "tag does not exist" (0x04 → libplctag <c>ErrorNotFound</c>), which
+    ///     <c>AbCipDriverProbe.IsReachableStatus</c> classifies as reachable. Until 2026-08-01 that
+    ///     classification had never been exercised against any backend: <c>ab_server</c> answered an
+    ///     unresolvable tag path with 0x03 (<c>ErrorBadParam</c>) where a Logix controller answers 0x04,
+    ///     so the fixture reported a healthy sim as a failed handshake and the discrepancy was written
+    ///     down as a fixture limitation rather than fixed. It is now fixed in the vendored patch —
+    ///     <c>Docker/patches/0002-ab_server-answer-tag-not-found-with-cip-0x04.patch</c> — so this test
+    ///     needs the fixture rebuilt from that patch, not merely running.
+    /// </remarks>
+    [Fact]
+    public async Task AbCip_WithNoAuthoredTags_ReportsTheControllerReachable()
+    {
+        SkipUnless(DockerHost, AbCipPort);
+        var result = await new AbCipDriverProbe().ProbeAsync(
+            $"{{\"Devices\":[{{\"HostAddress\":\"ab://{DockerHost}:{AbCipPort}/1,0\"}}],\"RawTags\":[]}}",
+            Timeout, Ct);
+
+        result.Ok.ShouldBeTrue($"Probe message: {result.Message}");
+
+        // EXACT for the same reason as the test above, and here it carries the extra weight of proving
+        // WHICH green this is: the fallback's "probe tag not found", not a tag that was actually read.
+        result.Message.ShouldBe("CIP session OK (controller reachable; probe tag not found)");
+    }
 }