dohertj2/wwtools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "graccesscli: fail fast on package-only attribute writes (writeback gap fix)"

Browse Source 
This reverts commit bd95ace1c5.
This commit is contained in:
Joseph Doherty
2026-05-05 21:19:00 -04:00
parent 87c0124174
commit 4e242ca824
1 changed files with 0 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
graccesscli/src/ZB.MOM.WW.GRAccess.Cli/GRAccess/GRAccessCommandDispatcher.cs
-31
View File
@@ -503,7 +503,6 @@ namespace ZB.MOM.WW.GRAccess.Cli.GRAccess
return AtomicObjectEdit(obj, editObj =>
{
var editAttr = FindAttributeForMutation(editObj, Arg(args, "attribute"));
EnsureMutableViaSetValue(editAttr, Arg(args, "attribute"));
editAttr.SetValue(CreateMxValue(Arg(args, "value"), Arg(args, "data-type", "string")));
return CommandSummary(editAttr, "Set attribute value");
});
@@ -1624,40 +1623,11 @@ namespace ZB.MOM.WW.GRAccess.Cli.GRAccess
}
var attr = FindAttributeForMutation(obj, attributeName);
EnsureMutableViaSetValue(attr, attributeName);
var body = File.ReadAllText(file);
attr.SetValue(CreateMxValue(body, "string"));
return CommandSummary(attr, $"Set script {attributeName}");
}
// Checks whether `attr.SetValue` will actually persist on this attribute,
// or whether the attribute is package-only (in which case SetValue silently
// no-ops despite returning Successful=true). Discovered via investigation
// documented in the writeback-gap notes: ScriptExtension text fields
// (ExecuteText, DeclarationsText, StartupText, ShutdownText, OnScanText,
// OffScanText, Expression) are all `MxCategoryPackageOnly_Lockable` —
// editable only via the package import/export round-trip, never via the
// generic `IAttribute.SetValue` path. Same for any other attribute whose
// category starts with `MxCategoryPackageOnly`.
private static void EnsureMutableViaSetValue(IAttribute attr, string attributeName)
{
string category;
try { category = attr.AttributeCategory.ToString(); }
catch { return; } // best-effort; if we can't read the category, let the write proceed
if (category != null && category.StartsWith("MxCategoryPackageOnly", StringComparison.OrdinalIgnoreCase))
{
throw new InvalidOperationException(
$"Attribute '{attributeName}' has category '{category}'. " +
"Package-only attributes silently no-op via IAttribute.SetValue and can only be " +
"edited through the package import/export round-trip. " +
"For ScriptExtension bodies (ExecuteText / DeclarationsText / StartupText / etc.), " +
"edit the source object in the System Platform IDE and re-import, " +
"or use a future package-rewrite path. " +
"See docs/script-parsing.md:8.");
}
}
private static string ObjectScriptCreate(IGalaxy galaxy, IgObject obj, IDictionary<string, object> args)
{
var scriptName = Arg(args, "script");
@@ -1724,7 +1694,6 @@ namespace ZB.MOM.WW.GRAccess.Cli.GRAccess
if (!string.IsNullOrWhiteSpace(expression))
{
var attr = FindAttributeForMutation(obj, scriptName + ".Expression");
EnsureMutableViaSetValue(attr, scriptName + ".Expression");
attr.SetValue(CreateMxValue(expression, "string"));
yield return CommandSummary(attr, $"Set script {scriptName}.Expression");
}