Files
scadaproj/components/ui-theme/validation/ot-ui/ot07-root/peer-review.md
T

12 lines
2.2 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
# Independent OT07 density and menu review
Reviewed the frozen RawTree, ContextMenu, context-menu CSS, site CSS, FleetDiagnostics markup and tree-layout module against the preceding source. No concrete blocker found in this bounded change.
The new explicit overflow:auto viewport is a deliberate virtualization root. Row geometry and ItemSize use the same30/44 state; node keys, lazy loading, paging, mutation callbacks and selection payloads remain. The checkbox's larger implicit-label target retains the existing visible-node aria-labelledby relationship. Desktop density remains compact; coarse targets use44 without allowing narrow labels to inflate the row estimate.
Density initialization serializes import/observer/disposal and prevents an older initial media result overwriting a newer observation. Disposed callbacks cannot apply geometry. Menu setup captures its current presentation before awaits and checks generation/disposal before placement/focus. The JS module observes resize/removal, releases listeners/observers, keeps the original Blazor-owned node and uses manual native popover top-layer placement where supported; no cloned/reparented action nodes or replacement action/policy logic were introduced. Key-default prevention remains synchronous while original C# keyboard/action handlers keep ownership.
The named typed diagnostics field and toolbar geometry preserve values/event expressions. Reviewed retained native16-case records:30/44 exact rows, bounded55–62 mounted of800,500→800 paging,25-level local keyboard pan, selected same DOM/focus through density transitions, menu resize/coarse activation, and real200% innerWidth720/195 with DPR2. Recorded menu size is bounded (resize sample183.73×74.38). The two zoom screenshot framing corrections are capture corrections; the earlier photos are not claimed valid. This review did not rerun those existing suites without a new concern.
Actual broader browser/support/final whole-app acceptance remains OT14; this is not an exhaustive new certification of every native popover/focus failure mode. RawTree controller target/callback/follow-up sequencing and OT12 semantic/icon work remain the primary agent's next scope after this source commit/handoff.