21 lines
3.5 KiB
Markdown
21 lines
3.5 KiB
Markdown
# Independent MX native-dialog pilot review
|
|
|
|
Reviewed 2026-11-13 against the current uncommitted NativeDialog.razor, ConfirmDialog.razor, ApiKeysPage integration and dashboard-dialog.js. Read-only source/evidence review; no MX edits, fresh browser run, live action or deployment.
|
|
|
|
**No additional current-caller lifecycle blocker found.** Final MX02 acceptance still requires the parent's already identified create-validation alert visibility correction and its retained verification. Do not copy an unaccepted snapshot into OEE02.
|
|
|
|
- The adapter keeps its dialog element stable, serializes import/open/close/disposal with a lifecycle semaphore, and uses generation/target checks to discard superseded imports/cancel requests. Disposal is idempotent, marks the instance disposed before awaiting lifecycle completion, closes the native presentation and releases its module/self references. This matches the retained pending-import/hide/dispose/reopen lifecycle evidence.
|
|
- Native cancel events are prevented synchronously using their actual DOM event. Client pending/busy guards cover the first server round trip; dispatcher-side checks reject stale, repeated or busy cancellation. Current ConfirmDialog/API-create parents also guard explicit button cancellation on their server-owned IsBusy state. No operation or confidential value crosses the adapter.
|
|
- Tab stays native. The parent's document.hasFocus condition correctly distinguishes focus inside the document from permitted browser-chrome focus; a custom Tab trap is not warranted.
|
|
- The single-active native presentation guard rejects a second modal before showModal. The local parent remains the authority for cancellation and operation state. Current idle rejection/cancel paths do not dispatch a gateway action.
|
|
- WeakMap state and disconnected-node observation clean up listeners and native presentation. Focus restoration checks connected/visible/enabled usability and verifies actual focus before selecting the heading fallback. Temporary heading tabindex is removed on blur, addressing the earlier connected-disabled/disconnected trigger class of failure.
|
|
- Confirmation title/description IDs are per-instance and match rendered content. Confirmations initially focus Cancel; the long create form now starts at Key ID. The existing OnSubmit integration calls the parent even for custom validation failure, allowing the adapter's update to clear client pending state.
|
|
|
|
## OEE02 integration requirements
|
|
|
|
Use a stable, non-confidential target identity such as a form/session key; do not bind Target to an editable name or changing validation message, which would request a new presentation. Router TechModal has 15 caller files and its parent-owned busy/cancel/draft rules must all remain explicit. Keep typed cancellation and persistence with the existing router handlers.
|
|
|
|
If a router form uses OnValidSubmit only or native constraint validation, ensure invalid submission is acknowledged back to the adapter's idle update; marking a submit click pending must not leave idle Escape suppressed after validation rejects it. MX's current OnSubmit/custom-validation path supplies that parent update. This is an integration requirement for reuse, not a demonstrated failure of the current MX create caller.
|
|
|
|
Preserve the strongest existing focus fallback and native behavior; keep the first two pilots local and documented before considering generic shared extraction. The recorded focused lifecycle/confirmation evidence is useful, but this review does not claim every downstream form or complete authentication/COM behavior has been exercised.
|