Files
scadaproj/components/ui-theme/validation/theme-1.0.0/scadabridge-pilot/REPORT.md
T

45 lines
6.6 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
# ScadaBridge Theme 1.0.0 local consumer pilot
This report supersedes the historical candidate-not-run statements in `../canary/SCADABRIDGE-CANARY.md`. That document remains the baseline/setup record. This is a disposable **actual-component host**, not a full application/fleet integration or deployment. The existing Docker rigs were untouched.
## Package and scope
The exact reviewed package came from source commit `3d61456d6150145a525a3a646721f865f5680c1b`, package SHA256 `834d2aad4e61cebff3fb48bbf608d412547d4aa39bdda142d0c7caf24c9e10d0`. It was not repacked. Restore uses task-local package directories and a private approved-source NuGet config; credentials are not evidence. `package-provenance.json` records production/test resolution and package/runtime DLL equality. The actual CentralUI production graph resolves Theme 1.0.0 and contains neither bUnit nor AngleSharp; tests retain bUnit 2.7.2 and AngleSharp 1.5.2.
Under the parent's limited pilot exception, actual ScadaBridge changes are `Directory.Packages.props` Theme 0.5.3 → 1.0.0 and the dark token block plus a supported-dark-only Bootstrap Secondary adapter in `CentralUI/wwwroot/css/site.css`. Light tokens stay unchanged. Dark blue is #7aa0ef / #9dbaf6 with #111827 primary foreground, #1e2640 tint, #566d9c border and #a7c1ff focus. Dark semantic text/faint aliases are added; existing status signal colors are preserved. The fixture's former proposed dark palette is removed: actual served CentralUI CSS is now authoritative.
## Browser evidence
- `../canary/scadabridge-first-inspection/results.json` retains the first 22-case matrix: four light accent families at 1440/1024/390; actual MainLayout light/dark at those widths; actual login light/dark; real 200% browser zoom light/dark. Functional checks passed, including native mobile navigation, field associations/error clearing, slow local success/failure busy feedback, caller-disabled actions, focus and no horizontal overflow/JS errors.
- **Nine immediate motion readings in that first JSON were invalid empty values from prerender nodes detached during hydration. Do not describe every first-pass assertion as passing.** The raw results remain unchanged.
- `../canary/scadabridge-confirmation/results.json` corrects the measurement method with synchronous current-node/style lookup, and replaces misleading full-page zoom captures with viewport captures. All ten confirmation cases pass: connected content immediately opacity 1/animation none with reduced motion, actual zoom `innerWidth=720`, `scrollWidth=720`, DPR 2. No product fix was made for this measurement correction.
- `actual-dark-adoption.json` is the bounded focused check after the actual dark source adoption. Served site.css bytes match the actual source (SHA256 recorded). Primary text 6.84:1; link 8.67:1; selected navigation 7.67:1; five semantic status samples 8.50–9.25:1; keyboard focus is a solid 2px #a7c1ff outline. Desktop content has no horizontal overflow or browser error. `actual-dark-adoption.png` captures this final actual-source state.
- Four-family cases cover **light themes only**. The separately tested dark palette is supported ScadaBridge blue, not an expansion of all four brands into dark themes.
The focused check exposed inherited local Bootstrap Secondary text at 3.15:1. Under explicit parent authorization, a supported-dark-only `.btn-outline-secondary` host adapter now uses existing `--ink-soft` and `--card` variables for normal, hover, pressed and disabled component variables. Actual active normal/hover/pressed labels each measure 5.62:1. Shared focus remains intact. This adapter is in actual CentralUI site.css; Theme has no built-in family dark mode and the immutable package is unchanged.
## Consumer suite
The first full Release run retained as `first-tests.trx` / `first-tests.log` completed 1550 passed, 1 failed, zero skips. `CloseButton_DismissesModal` encountered bUnit `UnknownEventHandlerIdException` between finding a button and clicking it while asynchronous modal rendering replaced its event handler. The exception recommends dispatcher-atomic Find+Click. The behavioral assertion remains that clicking Close removes the modal.
After converting only this test to `async Task` and awaiting `cut.InvokeAsync(() => cut.Find(...).Click())`, the complete Release suite passed **1551/1551**, zero failures/skips (`scadabridge-theme-1.0.0.trx`, `final-tests.log`). The failed first run remains retained. No test identity/assertion was removed or weakened; no production behavior changed. This report supplies pilot evidence; the parent owns final G1 acceptance.
## Accepted pilot commit
Parent acceptance and independent review preceded the explicit three-path commit `cdd3adf6` in the ScadaBridge `codex/scada-ui-consistency` branch. The sibling checkout is clean after this commit. Package publication was performed separately by the parent; this pilot did not repack or publish.
## Reproduction
Actual consumer cwd `/Users/dohertj2/Desktop/ScadaBridge`:
```sh
dotnet restore tests/ZB.MOM.WW.ScadaBridge.CentralUI.Tests/ZB.MOM.WW.ScadaBridge.CentralUI.Tests.csproj --force --packages /tmp/scadabridge-theme-pilot-packages --configfile /tmp/scadabridge-ui-canary-nuget.config
dotnet test tests/ZB.MOM.WW.ScadaBridge.CentralUI.Tests/ZB.MOM.WW.ScadaBridge.CentralUI.Tests.csproj -c Release --no-restore --logger 'trx;LogFileName=scadabridge-theme-1.0.0.trx' --results-directory /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/components/ui-theme/validation/theme-1.0.0/scadabridge-pilot
```
The private config maps exact `ZB.MOM.WW.Theme` to the local immutable package feed and merges existing approved sources. It must be recreated privately for future runs; do not commit credentials. Candidate canary restore/run uses the retained csproj with `-p:CanaryThemeVersion=1.0.0`, `--artifacts-path /tmp/scadabridge-ui-canary-candidate-artifacts` and isolated `/tmp/scadabridge-ui-canary-candidate-packages`. Its source remains synthetic/local; actual consumer tests run from the sister checkout above. `../canary/inspect_scadabridge_actual_adoption.py` records the focused final browser check; the earlier scripts/evidence remain separately retained.
## Rollback and limits
Before any publication/deployment, rollback is the original Theme 0.5.3 pin plus the original dark token block, restored together. The disposable canary binds only 127.0.0.1:5199, has no fleet/database/LDAP services, and uses synthetic values. Local delayed button outcomes exercise presentation only. No live operation, production deployment, or complete authenticated fleet route coverage is claimed. Source/runtime provenance is evidence of consuming the handed package, not publication authorization.