Files
scadaproj/impeccable/Theme.md
T
2026-11-13 14:40:42 -05:00

5.0 KiB

ZB.MOM.WW.Theme — shared foundation review

Source: ZB.MOM.WW.Theme/src/ZB.MOM.WW.Theme. Source version 0.5.3 (Directory.Build.props:7). Reviewed November 12, 2026 using Impeccable's Operate and audit guidance.

The primary recommendation is to preserve Technical-Light and improve its shared accessibility and interaction contract. Shared findings, evidence, ownership and acceptance criteria are authoritative for all projects. Component mockup.

Coverage

Inspected both CSS files and ThemeShell, ThemeHead, ThemeScripts, TechField, TechButton, LoginCard, StatusPill; scanned BrandBar, NavRailItem, NavRailSection, TechCard and TreeTable and existing documentation. All 13 component files are inventoried in source inventory. This library is not a standalone deployed UI. Mockups represent proposed changes, not a rendered bUnit fixture or a current consumer screenshot.

Prioritized recommendations

Priority / reference Recommendation Ownership and acceptance
P1 / DS-01 Introduce readable status text and secondary text tokens; preserve brighter signal colors separately Theme CSS; ≥4.5:1 on actual small-text surfaces. Measured failing and proposed pairs in contrast evidence
P1 / DS-02 Connect TechField labels, hints and errors with explicit control IDs Theme API and consumer callers; label click focuses control and screen reader announces description/error
P2 / DS-03 Carry a complete product accent family through hover, active and focus Theme configuration; green/purple products keep their identity and deliberate state colors
P2 / DS-04 Add consistent focus and busy announcements; reduced-motion alternatives Theme and caller state; keyboard focus visible throughout, final content visible without entrance motion
P2 / DS-05 Standardize table/filter/dialog recipes before extracting complex widgets Shared examples and reusable behavior; demonstrate in two consumers without pulling domain logic into Theme
P2 / DS-06 Maintain package adoption matrix and explicit color-scheme support Theme release + consumer pins; screenshots and supported browser checks at the actual installed package

Do not infer from Bootstrap CSS variable overrides that every Bootstrap component has adopted the palette. Inventory .btn, .rail-btn, table and form call sites before migrating; the existing README correctly explains why a CSS rule can be inert in a consumer. Likewise do not remove copied rules solely because their class names now exist upstream: compare declarations and version first.

Preserve

  • Local fonts with working relative asset URLs; no external font dependency.
  • A CSS/native-disclosure shell that supports SSR, including recent fixes keeping content visible with mobile navigation closed.
  • Distinct status, role and hierarchy components; a stateless TreeTable whose caller owns visible rows and expansion state.
  • TechButton class merging, explicit disabled preservation and action disabling while busy.
  • Static POST login with host-supplied antiforgery and validated return URL; visual changes must preserve that HTTP contract.

Verification and rollout

Start with token pair checks and a rendered TechField association test. Confirm focus, 200% zoom, 390px and 1440px layouts, native disclosures in the supported browser engines, and each consumer's relevant overlays. Browser focus defaults and Bootstrap need inspection together; source alone cannot establish a complete focus failure. Run Impeccable audit after implementation and polish last. No production source or package was changed by this review.

Independent consistency check

A second source review verified the shared findings against field/button/shell/login markup, status and navigation components, tree-table semantics, both CSS files and the actual 0.5.3 version declaration. DS-01 through DS-06 describe current source accurately. The dedicated TreeTable already supplies node-specific labels and expansion state; carry that approach into local Raw/UNS trees without replacing their virtualization blindly. Native NavRailSection disclosure semantics and its enhancement should remain aligned when JavaScript is unavailable.

The combined source detector run emitted no warnings in Theme source. Its four findings were Overview's vendored Bootstrap definitions and were excluded as product defects. This does not establish rendered contrast/focus conformance; the shared token-pair calculations and manual interaction findings are separate evidence.

Rendered proposal previews

These are proposed UI artifacts with illustrative data, not screenshots of the current application. All use the same shared stylesheet. See verification and limits.

Theme

Interactive HTML · Desktop PNG · Mobile PNG

Proposed Theme desktop UI