Joseph Doherty
477245f5db
First reviews of Secrets, LocalDb, GalaxyRepository and Overview, and
2026-11-09 re-reviews of Auth, Health, Theme, Telemetry, Audit and
Configuration, all at 91fb2b4. 49 new open findings, each with a P1/P2/P3
priority and a failure scenario: 1 P1, 13 P2, 35 P3. README regenerated;
REVIEW-PROCESS, template and regen script now cover all ten libraries and
the Priority field.
Claude-Session: https://claude.ai/code/session_01GT67AEHd2Acv1YPwGfXEoV
78 lines
2.4 KiB
Markdown
78 lines
2.4 KiB
Markdown
# Code Review — <Library>
|
|
|
|
<!--
|
|
Template for a shared-library review. Copy the structure below into
|
|
code-reviews/<Library>/findings.md and fill it in.
|
|
<Library> is the ZB.MOM.WW.* library with the prefix stripped (Auth, Theme,
|
|
Health, Telemetry, Configuration, Audit, Secrets, LocalDb, GalaxyRepository,
|
|
Overview). See ../REVIEW-PROCESS.md for the
|
|
full process and the library → component-spec mapping.
|
|
-->
|
|
|
|
| Field | Value |
|
|
|-------|-------|
|
|
| Library | `ZB.MOM.WW.<Library>/` |
|
|
| Packages | `<package ids, e.g. ZB.MOM.WW.<Library>>` |
|
|
| Component spec | `components/<component>/spec/SPEC.md` |
|
|
| Shared contract | `components/<component>/shared-contract/ZB.MOM.WW.<Library>.md` |
|
|
| Status | Not yet reviewed \| In progress \| Reviewed |
|
|
| Last reviewed | YYYY-MM-DD |
|
|
| Reviewer | <name> |
|
|
| Commit reviewed | `<short SHA>` |
|
|
| Open findings | 0 |
|
|
|
|
## Summary
|
|
|
|
One short paragraph: overall health of the library, themes across findings, and anything
|
|
notable that is not a finding (e.g. test count, dependency footprint, adoption status).
|
|
|
|
## Checklist coverage
|
|
|
|
Confirm every category was examined. Record "No issues found" where applicable.
|
|
|
|
| # | Category | Examined | Notes |
|
|
|---|----------|----------|-------|
|
|
| 1 | Correctness & logic bugs | ☐ | |
|
|
| 2 | Public API surface & compatibility | ☐ | |
|
|
| 3 | Concurrency & thread safety | ☐ | |
|
|
| 4 | Error handling & resilience | ☐ | |
|
|
| 5 | Security & secret handling | ☐ | |
|
|
| 6 | Performance & resource management | ☐ | |
|
|
| 7 | Spec & shared-contract adherence | ☐ | |
|
|
| 8 | Packaging, dependencies & project layout | ☐ | |
|
|
| 9 | Testing coverage | ☐ | |
|
|
| 10 | Documentation & XML docs | ☐ | |
|
|
|
|
## Findings
|
|
|
|
<!-- One entry per finding. Copy the block below. Never delete a finding; close it
|
|
by changing Status and completing Resolution. -->
|
|
|
|
### <Library>-001 — <Short title>
|
|
|
|
| | |
|
|
|--|--|
|
|
| Severity | Critical \| High \| Medium \| Low |
|
|
| Priority | P1 \| P2 \| P3 |
|
|
| Category | <one of the 10 checklist categories> |
|
|
| Status | Open \| In Progress \| Resolved \| Won't Fix \| Deferred |
|
|
| Location | `ZB.MOM.WW.<Library>/src/<Package>/<File>.cs:<line>` |
|
|
|
|
**Description**
|
|
|
|
What is wrong and why it matters.
|
|
|
|
**Failure scenario**
|
|
|
|
Concrete inputs/sequence and the wrong outcome.
|
|
|
|
**Recommendation**
|
|
|
|
Concrete suggested fix.
|
|
|
|
**Resolution**
|
|
|
|
_Unresolved._
|
|
<!-- When closed: fixing commit `<SHA>`, date YYYY-MM-DD, one-line description.
|
|
For Won't Fix / Deferred, justify the decision here. -->
|