33 lines
5.1 KiB
Markdown
33 lines
5.1 KiB
Markdown
# Remaining ScadaBridge chapter preflight
|
||
|
||
Read-only preflight after pilot commit `cdd3adf6`; broad UI implementation waits for the parent's explicit **G1 passed** message. Existing-checkout branch execution was explicitly user-authorized, overriding executeplan's default new-worktree requirement. No new source changes are made by this preflight.
|
||
|
||
## Baseline and task boundaries
|
||
|
||
Actual consumer baseline is Theme 1.0.0, full CentralUI Release suite 1551 passed/zero skipped, bUnit 2.7.2 / AngleSharp 1.5.2. Shared package and static export are published unchanged per parent; final feed-only restoration is owned by parent. Pilot evidence is component-host evidence, so SB-00's authenticated route-family captures remain incomplete. SB-07/13 have only the scoped supported-dark prerequisites completed; do not mark all semantic colors/palette ownership done from the pilot.
|
||
|
||
The remaining chapter is `docs/plans/2026-11-12-scada-ui-consistency/ScadaBridge.md`; task IDs SB-00–15 differ from TH07's pilot terminology. In particular **SB-01 is dialog naming**, not the completed dark prerequisite.
|
||
|
||
## First post-G1 batch
|
||
|
||
1. **SB-01 naming:** existing `Components/Shared/DialogHost.razor` lacks aria-labelledby/describedby and prompt label/input association. Existing `Shared/DialogHostShowAsyncTests.cs` and `DialogSeverityStylingTests.cs` provide actual service/renderer fixtures. Add red regressions for sequential confirm/prompt naming, implement stable per-dialog IDs, preserve cancellation/severity/result typing. Verify `dotnet test tests/ZB.MOM.WW.ScadaBridge.CentralUI.Tests/ZB.MOM.WW.ScadaBridge.CentralUI.Tests.csproj -c Release --filter 'FullyQualifiedName~DialogHost|FullyQualifiedName~DialogSeverity'`.
|
||
2. **SB-02 overlay pilot:** real `wwwroot/js/dialog.js` uses module-global saved trigger and `window.event`; `DialogHost` relies on server keydown interop. Replace with per-element native-event lifecycle while preserving existing service contracts and testing current scenarios. Reuse actual audit drawer test fixtures. Browser harness must supply an explicit local fixture and demonstrate boundary Tab/Shift+Tab, no-focusable case, disconnected trigger, hidden/disabled descendants, Escape, disposal and repeat openings. Generic extraction remains deferred until BTDB's second successful pilot. Canary source can be extended with synthetic audit drawer data; no existing rig writes.
|
||
3. **SB-03 field association:** apply labels/descriptions through DataTable, MultiSelectDropdown, AuditFilterBar and all report inventory callsites. Proposed ControlLabelTests is a new test file, not an existing harness. Add optional LabelledBy to local multiselect, preserve selection semantics. Audit filter tests already exist under `Components/Audit/`. Source scan and role coverage must precede a claim that all forms are fixed.
|
||
|
||
## Remaining sequence and verified test families
|
||
|
||
- SB-04 UTC and SB-14 exact-ID guards share AuditFilterBar files; implement sequentially with distinct behavior tests. Preserve the lax query-model API for other callers. Run timezone-filter tests under UTC/America/Indianapolis/Asia/Tokyo; process TZ only.
|
||
- SB-05 independent Dashboard states and SB-10 policy shortcuts share Dashboard; create planned `Pages/DashboardStateTests.cs`, then SB-08 hierarchy and SB-11 summaries. Existing `Pages/HealthPageTests.cs` and `Monitoring/HealthFailoverButtonTests.cs` are available.
|
||
- SB-06 ToastNotification naming uses existing `Shared/ToastNotificationTests.cs`; no timer-policy expansion.
|
||
- SB-07 semantic flow/caption inks, SB-08 page/table anatomy and SB-15 flow/audit presentation use bounded browser comparison, not CSS declaration tests. Dark aliases already landed do not establish every local component's contrast.
|
||
- SB-09 DataTable empty count/overflow has existing `Shared/DataTablePagerTests.cs`; preserve pagination/selection and add local named scroll wrapper without double wrapping.
|
||
- SB-12 topology touch/short-viewport adaptation must preserve tree lazy loading, poll limits and loaded-search qualification; no backend search promise.
|
||
- SB-13 retains local dark palette and saved sb-theme because Theme ships light base plus supported consumer adapters, not a shared dark switch. No preference migration is indicated by this release.
|
||
- SB-15 full acceptance follows all tasks, with full suite plus an authenticated authorized disposable fixture for remaining full-route/role/live-replay semantics. No fleet deployment is required or authorized by browser verification.
|
||
|
||
## Existing harness limitations
|
||
|
||
The current localhost5199 canary renders actual MainLayout/login/components with anonymous auth and synthetic data; it can validate overlay DOM, layout and component focus after adding synthetic cases. It cannot substantiate actual authenticated dashboard/health/topology data-state or authorization end-to-end claims. bUnit fixtures supply deterministic role/data behavior, while any final browser route matrix must explicitly label fixture composition and remaining integration limits. Do not reuse or mutate the existing Docker fleet rig for convenience.
|
||
|
||
No blocking source/test-path mismatch found for the first batch. Parent final G1 result is the pending gate, not a request for new user permission.
|