Files
scadaproj/components/ui-theme/validation/theme-1.0.0/review-g1-independent.md
T

46 lines
6.0 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
# Independent G1 candidate review
Reviewed 2026-11-13. This is an independent source/evidence review, not a gate update, publication approval, deployment or fresh browser execution.
**Result: no concrete source or artifact release blocker found in the reviewed candidate and limited pilots. G1 remains open for publication and independent feed-download/restore verification.**
## Immutable candidate
Independently recomputed SHA256 of the actual nupkg and static zip:
- Source commit: `3d61456d6150145a525a3a646721f865f5680c1b`.
- Package: `834d2aad4e61cebff3fb48bbf608d412547d4aa39bdda142d0c7caf24c9e10d0`.
- Export: `6c9c1ee721c51a74a6efe39f596c5ea6d609b851b39f967d71b3f8b426a5cdca`.
The zip file set equals the six manifest payload paths plus manifest.json. Every payload hash matches; manifest equals artifacts.json. The five CSS/font assets match both the nupkg staticwebassets entries and `git show` of the recorded clean source commit byte for byte. Nuspec ID/version/repository commit are correct. Actual prepack TRX counters are 105 executed/passed, zero failed/notExecuted; build log has zero warnings/errors. Earlier independent exporter review covers input alias protection and all 15 passing offline tests; see review-exporter.md.
## Overview and registry
Overview evidence supports its bounded one-entry, loopback-only host claims. Actual browser zoom helper invokes chrome.tabs.setZoom; saved evidence records innerWidth1440→720, DPR1→2, scrollWidth720. Its 30 computed selector contrast samples have minimum5.555:1. The recorded CSS/font hashes equal the exact package assets. Actual suite TRX records197 passed with no failures/skips. This does not establish the complete OV-01 stale-state fixture or full chapter completion. The parent's separate grouped/stale fixture diagnosis involved detached-node empty styles; no actual grouped narrow-layout defect is established by that diagnosis.
Registry accepted import commit is `018f504448ff3745a0ca18b34eba657763a478f7`. Actual browser TRX records11 passed, no failures/skips. Asset and import checks preserve canonical bytes and the existing Auth graph; no private Theme NuGet dependency was introduced. layout.css is served but deliberately not loaded against unmatched native registry chassis markup. Registry's broader chapter and actual200%zoom acceptance are not claimed by this limited pilot.
## Final ScadaBridge source and evidence
Reviewed the actual three-file working diff in `/Users/dohertj2/Desktop/ScadaBridge`:
- Directory.Packages.props changes only Theme0.5.3→1.0.0.
- CentralUI/wwwroot/css/site.css supplies the supported dark accent family, readable semantic text/faint inks, on-accent foreground and scoped Bootstrap Secondary variables. Existing dark signal colors and light token block are preserved. The Secondary bridge remains host-local, as Theme does not claim built-in family dark support.
- NotificationReportDetailModalTests.CloseButton_DismissesModal changes to async and dispatches Find+Click atomically. The existing modal-dismissal assertion and identity remain intact; no skip or production workaround was added.
Independently parsed both actual TRXs: first1550/1551 with one failed CloseButton_DismissesModal; final1551/1551 executed/passed, zero failed/notExecuted. The retained first failure and explanation are consistent with the narrow dispatcher correction.
Independently read actual production/test project.assets.json: production resolves Theme1.0.0 without bUnit/AngleSharp; tests resolve Theme1.0.0, bUnit2.7.2 and AngleSharp1.5.2. Both recorded runtime DLLs hash to the exact nupkg DLL. Actual CentralUI site.css SHA256 matches final served-source evidence (`0c511c5f208942d4666678e931b4931534b4eb44921cfad95cf02f2cf03fb480`).
Final actual-source browser evidence records primary6.844:1, link8.670:1, selected7.670:1, five status samples8.500–9.253:1, Secondary normal/hover/pressed5.621:1, scoped2px focus and bounded desktop content. Reviewed its retained screenshot and measurement script. These are enabled-state contrast measurements; disabled/busy screenshot appearance does not establish enabled-state contrast. Script's actual computed pairs support the report's numerical claims, even though its boolean passed field alone does not assert every reported pair.
The initial22-case matrix retains nine invalid detached-prerender-node readings; it is not universally green. Ten current-node confirmation cases explicitly replace those motion observations and correct zoom captures. The final report correctly retains this history and supersedes baseline candidate-not-run prose. Four brand families are light-only; actual dark adoption is supported ScadaBridge blue only. No complete fleet/authenticated-app acceptance is claimed.
## Remaining delivery gate
The release draft correctly states that publication and G1 acceptance are pending. Publish only the exact reviewed immutable bytes, independently download/hash both delivered artifacts and prove a consumer restore without the local source before closing G1. This review changes no ledger/gate and authorizes no live operation. Full consumer chapters, native Perspective acceptance and broader Overview fixtures remain their own scoped work.
## Delivery addendum — 2026-11-13
Reviewed publication.json and independent-feed-restore.json/log. NuGet publication records exit0; generic static upload records HTTP201. Independently rehashed the retained downloaded nupkg and static zip: both equal the immutable candidate hashes above. Independently read the isolated restored Theme .nupkg.metadata: source is the official Gitea NuGet endpoint; rehashed its actual nupkg and confirmed the exact reviewed package hash. Overview restore records exit0 and unchanged resolved libraries, with no local candidate feed. The SDK library-packs directory is a standard SDK source and does not invalidate the actual Theme-source proof; the earlier overbroad assertion and correction are disclosed. ScadaBridge accepted source is now committed as cdd3adf6. No remaining delivery-evidence blocker found. Parent owns G1 closure; this addendum changes no ledger/gate and runs no extra broad suite.