39 lines
4.5 KiB
Markdown
39 lines
4.5 KiB
Markdown
# Independent exporter and release-candidate source review
|
|
|
|
Reviewed 2026-11-13 in the managed `scada-ui-consistency/scadaproj` worktree. Scope: TH-08 exporter/tests after the alias fix; candidate component/usage documentation, token/accent rules and interaction recipes. No production source, CSS, test or release-ledger edits were made during this review.
|
|
|
|
## Confirmed correction
|
|
|
|
The earlier input-alias defect is resolved. `export_package` now rejects either resolved-path equality or an existing output whose `samefile(package)` identity matches the input. The latter is necessary on this actual case-insensitive APFS filesystem: case aliases can have unequal `resolve()` paths while identifying the same file.
|
|
|
|
The case-alias and hardlink regressions verify rejection before replacement and preservation of both original/alias bytes. They are meaningful negative tests rather than just checking the guard's source text.
|
|
|
|
## Independently executed verification
|
|
|
|
Cwd: `ZB.MOM.WW.Theme` in the managed worktree.
|
|
|
|
```sh
|
|
PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s build -p 'test_export_web_assets.py' -v
|
|
```
|
|
|
|
Result: **15 tests passed, zero failures, zero skips**, exit 0. Both APFS case-alias and hardlink cases actually executed on this host. Synthetic input/output files were confined to temporary directories. Bytecode output was disabled to keep the source tree untouched.
|
|
|
|
## Review conclusions
|
|
|
|
- ZIP paths are validated before payload selection: absolute/traversal/backslash/drive/alias paths and duplicate names are rejected, including unrelated entries outside the export allowlist. No arbitrary package member is extracted to the filesystem.
|
|
- Exactly one nuspec with the intended package id and a nonempty valid-shaped version is required. The exported version comes from that nuspec, not an output filename.
|
|
- Required CSS/font assets are copied without modification. Comment removal applies only to token parsing, not emitted CSS bytes. The canonical root parser preserves raw references and future custom properties while rejecting malformed/ambiguous supported structures; it is explicitly not an arbitrary CSS/cascade validator.
|
|
- Manifest provenance includes the exact package SHA256 and all payload hashes, with no self-hash. Source revision/tag are explicitly caller-supplied; the exporter checks their shape, while the release workflow must establish that they identify the reviewed clean build.
|
|
- Output creation follows validation and uses atomic replacement. Stable JSON, sorted ZIP entries, fixed timestamps and fixed metadata support deterministic repeated exports; byte parity/determinism/hash-change tests all pass.
|
|
- Real cached Theme 0.5.3 nupkg entry names were inspected independently: both CSS paths and all three font paths match the exporter allowlist. That confirms path assumptions only, not acceptance of an old package as the new semantic release.
|
|
- The current candidate CSS parses successfully into 47 canonical tokens. Product active-state color reads the shell-scoped accent tint directly and the compatibility alias is rebound on the shell. Semantic info remains separate blue; small status text uses semantic ink while signal colors remain available for decoration.
|
|
- Field documentation now uses null-or-empty error checks consistent with component behavior. Busy state/caller-disabled ownership and outcome-region guidance remain accurate. Interaction recipes document real DOM keydown handling, safe focus/inertness and caller-owned state without introducing an untested generic modal component.
|
|
|
|
No further concrete exporter/source implementation blocker was found after the alias correction. The parent owns source freeze, full-suite/package integration and real-host acceptance.
|
|
|
|
## Release checks still required
|
|
|
|
This review does not claim G1 or publication. Freeze and commit reviewed source/version before packing the exact 1.0.0 artifact, then export from those bytes and independently recompute source/package/payload/export hashes using the matching source revision/tag. Test actual registry import paths and the exact candidate host graph; synthetic package tests cannot substitute for those checks.
|
|
|
|
The earlier ScadaBridge dark-mode risk remains an explicit candidate-host acceptance item: its pre-adoption `--accent:#4d7fe8` against a white primary label is approximately 3.81:1 under the new primary-button mapping. The parent-assigned dark canary must verify a safe scheme-specific foreground/background before that consumer adopts. This reviewer did not run or claim that dark probe, label-click/screen-reader checks, reduced-motion browser checks or new-package canaries.
|