d82d3451e7
G-8 (KEK rotation) — built in ZB.MOM.WW.Secrets, lib 0.1.2->0.1.3: - ISecretCipher.Rewrap(row, oldKek, newKek): re-wraps the per-secret DEK only (bodies never re-encrypted; revision/timestamps preserved -> invisible to cluster LWW). Fail-closed on wrong old-KEK id, wrong key bytes, and malformed wraps; DEK zeroed on all paths. - ISecretStore.ApplyRewrapAsync(rewrappedRow, expectedCurrentWrappedDek): updates only the 4 wrap columns + kek_id, compare-and-swap on the current wrapped DEK so a concurrent set/rotate cannot corrupt a row (closes a review-caught TOCTOU). - KekRotationService.RewrapAllAsync + RewrapReport: enumerate all rows incl. tombstones, idempotent/resumable skip-already-current, bounded CAS-retry, fail-closed on unknown/identical KEK. - `secret rewrap-all` CLI verb: key material only via env-var name / file path, JSON counts report; README section + operator runbook. Verified: full offline suite green (82 core + 15 UI, 0 regressions) + end-to-end CLI smoke + adversarial crypto review (all 7 categories PASS; TOCTOU fixed). G-7 (clustered replication) — designed + planned, no code: - Fork resolved to build Option A (shared SQL-Server ISecretStore); Akka replicator ZB.MOM.WW.Secrets.Akka is a deferred phase-2. Design doc + executable plan + .tasks.json under docs/plans/2026-07-17-secrets-g7-*. Tracking: components/secrets/GAPS.md + CLAUDE.md secrets row updated.
133 lines
4.8 KiB
C#
133 lines
4.8 KiB
C#
using Bunit;
|
|
using Bunit.TestDoubles;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using ZB.MOM.WW.Audit;
|
|
using ZB.MOM.WW.Secrets.Abstractions;
|
|
using ZB.MOM.WW.Secrets.Ui;
|
|
using ZB.MOM.WW.Secrets.Ui.Tests.Fakes;
|
|
|
|
namespace ZB.MOM.WW.Secrets.Ui.Tests;
|
|
|
|
public class SecretsListTests : TestContext
|
|
{
|
|
private static readonly SecretMetadata SecretOne = new()
|
|
{
|
|
Name = new SecretName("db/primary"),
|
|
Description = "Primary database connection",
|
|
ContentType = SecretContentType.ConnectionString,
|
|
KekId = "kek-a",
|
|
Revision = 3,
|
|
CreatedUtc = new DateTimeOffset(2026, 7, 1, 0, 0, 0, TimeSpan.Zero),
|
|
UpdatedUtc = new DateTimeOffset(2026, 7, 10, 12, 0, 0, TimeSpan.Zero),
|
|
UpdatedBy = "alice",
|
|
};
|
|
|
|
private static readonly SecretMetadata SecretTwo = new()
|
|
{
|
|
Name = new SecretName("api/token"),
|
|
Description = "External API token",
|
|
ContentType = SecretContentType.Text,
|
|
KekId = "kek-b",
|
|
Revision = 1,
|
|
CreatedUtc = new DateTimeOffset(2026, 7, 2, 0, 0, 0, TimeSpan.Zero),
|
|
UpdatedUtc = new DateTimeOffset(2026, 7, 11, 8, 30, 0, TimeSpan.Zero),
|
|
UpdatedBy = "bob",
|
|
};
|
|
|
|
private void RegisterStore(params SecretMetadata[] rows)
|
|
{
|
|
// SecretsList now embeds RevealButton / ConfirmDeleteModal / SecretEditor, which inject the
|
|
// cipher and audit writer, so those seams must be registered even for list-only assertions.
|
|
Services.AddSingleton<ISecretStore>(new FakeSecretStore(rows));
|
|
Services.AddSingleton<ISecretCipher>(new FakeCipher());
|
|
Services.AddSingleton<IAuditWriter>(new CapturingAuditWriter());
|
|
}
|
|
|
|
[Fact]
|
|
public void Renders_Metadata_ForEachSecret()
|
|
{
|
|
RegisterStore(SecretOne, SecretTwo);
|
|
var auth = this.AddTestAuthorization();
|
|
auth.SetAuthorized("alice");
|
|
auth.SetPolicies(SecretsAuthorization.ManagePolicy);
|
|
|
|
var cut = RenderComponent<SecretsList>();
|
|
var markup = cut.Markup;
|
|
|
|
Assert.Contains("db/primary", markup);
|
|
Assert.Contains("Primary database connection", markup);
|
|
Assert.Contains(nameof(SecretContentType.ConnectionString), markup);
|
|
|
|
Assert.Contains("api/token", markup);
|
|
Assert.Contains("External API token", markup);
|
|
Assert.Contains(nameof(SecretContentType.Text), markup);
|
|
}
|
|
|
|
[Fact]
|
|
public void RevealButton_Hidden_WithoutRevealPolicy()
|
|
{
|
|
RegisterStore(SecretOne, SecretTwo);
|
|
var auth = this.AddTestAuthorization();
|
|
auth.SetAuthorized("alice");
|
|
auth.SetPolicies(SecretsAuthorization.ManagePolicy);
|
|
|
|
var cut = RenderComponent<SecretsList>();
|
|
|
|
Assert.Empty(cut.FindAll("button.reveal-secret"));
|
|
Assert.DoesNotContain("Reveal", cut.Markup);
|
|
}
|
|
|
|
[Fact]
|
|
public void RevealButton_Shown_WithRevealPolicy()
|
|
{
|
|
RegisterStore(SecretOne, SecretTwo);
|
|
var auth = this.AddTestAuthorization();
|
|
auth.SetAuthorized("carol");
|
|
auth.SetPolicies(SecretsAuthorization.ManagePolicy, SecretsAuthorization.RevealPolicy);
|
|
|
|
var cut = RenderComponent<SecretsList>();
|
|
|
|
// One reveal affordance per secret row.
|
|
Assert.Equal(2, cut.FindAll("button.reveal-secret").Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void EmptyList_ShowsEmptyState()
|
|
{
|
|
RegisterStore();
|
|
var auth = this.AddTestAuthorization();
|
|
auth.SetAuthorized("alice");
|
|
auth.SetPolicies(SecretsAuthorization.ManagePolicy);
|
|
|
|
var cut = RenderComponent<SecretsList>();
|
|
|
|
Assert.Contains("No secrets", cut.Markup);
|
|
}
|
|
|
|
/// <summary>Minimal hand-written <see cref="ISecretStore"/> whose only real behavior is <see cref="ListAsync"/>.</summary>
|
|
private sealed class FakeSecretStore(IReadOnlyList<SecretMetadata> rows) : ISecretStore
|
|
{
|
|
public Task<IReadOnlyList<SecretMetadata>> ListAsync(bool includeDeleted, CancellationToken ct)
|
|
=> Task.FromResult(rows);
|
|
|
|
public Task<StoredSecret?> GetAsync(SecretName name, CancellationToken ct)
|
|
=> throw new NotSupportedException();
|
|
|
|
public Task UpsertAsync(StoredSecret row, CancellationToken ct)
|
|
=> throw new NotSupportedException();
|
|
|
|
public Task<bool> DeleteAsync(SecretName name, string? actor, CancellationToken ct)
|
|
=> throw new NotSupportedException();
|
|
|
|
public Task<IReadOnlyList<SecretManifestEntry>> GetManifestAsync(CancellationToken ct)
|
|
=> throw new NotSupportedException();
|
|
|
|
public Task ApplyReplicatedAsync(StoredSecret row, CancellationToken ct)
|
|
=> throw new NotSupportedException();
|
|
|
|
public Task<bool> ApplyRewrapAsync(
|
|
StoredSecret rewrappedRow, byte[] expectedCurrentWrappedDek, CancellationToken ct)
|
|
=> throw new NotSupportedException();
|
|
}
|
|
}
|