18 lines
3.4 KiB
Markdown
18 lines
3.4 KiB
Markdown
# BTDB BT00–01 independent peer review
|
||
|
||
Read-only review of the pending BTDB codex/scada-ui-consistency source checkpoint, including App script order, Theme pin, DialogHost, EditableRows, shared native-event adapter, typed service and existing/new tests. Later BT02/03 form edits are outside this review. No BTDB source edit, test execution, production/DB interaction or deployment was performed by this reviewer.
|
||
|
||
## Concrete findings and reviewed corrections
|
||
|
||
1. **P2 delayed focus restoration could steal user/fatal recovery focus.** The original400ms disabled-trigger observer/timer could survive after the user focused another control, or after fatal UI deactivated overlays and explicitly focused Reload. Its later callback would focus the old Save or H1. The original browser assertion checked fatal focus immediately. The author now cancels pending restoration on native focus/pointer interaction, new activation and fatal recovery, and restore itself refuses to move focus while fatal recovery is visible. Source re-reviewed; the retained17-check browser result includes deliberate newer-focus persistence and Reload focus beyond550ms, plus prior stack/rollback/cleanup cases. This finding is resolved in the current pending source.
|
||
|
||
2. **P2 existing custom DialogContext completion was not target-bound.** This pre-existing service gap was not introduced by the adapter diff: ShowAsync supplied bare global Resolve, so A-context/cancel-A/open-B/old-A.Close(true) completed B. Actual MachineForm/BatchEdit custom bool confirmation callers use these contexts. The author now captures the pending TCS and resolves only while that identity remains current, without changing public APIs or typed defaults. Actual new regression failed before (B became null/resolved) and passes after; DialogServiceTests6/6 green. Source guard re-reviewed. This finding is resolved in the current pending source.
|
||
|
||
## Remaining source assessment
|
||
|
||
No further concrete BT00–01 blocker found. Both local adapters capture rendered target/generation, serialize activation/deactivation, clean attempted late activation before releasing callback references, and ignore stale native Escape identities. Existing typed confirm/prompt/custom cancel outcomes remain owned by DialogService. EditableRows retains Clone rollback, cancelled-new-row removal, local Done classification and replacement/disposal restoration; no Done-to-database-save behavior was introduced.
|
||
|
||
The shared DOM namespace attaches real element keydown handlers with synchronous preventDefault, top-only Escape/Tab/focus containment, refcounted inert restoration and previous body state. Fatal Reload/reconnect nodes are excluded from background inertness/containment; the new pending-restore cancellation preserves that recovery focus. App loads the module after fatal markup and before Blazor, with existing asset-version stamping. Theme is the sole initial graph delta0.4.1→1.0.1; BTDB's deliberate non-central package style and product/domain ownership are preserved.
|
||
|
||
Evidence read, not rerun: BT01-manager.trx430/430; BT01-lifecycle.trx20/20; native browser result17passing functional checks with0page errors/0repository saves; custom-context red1failed then6focused green. These are checkpoint counts, not a claim that every later BT02/03 edit or final chapter matrix has been verified. Browser checks are a scenario's functional assertions, not17independent viewport scenes. Final current-source full-suite/viewport acceptance remains the author/parent chapter gate.
|