29 lines
3.5 KiB
Markdown
29 lines
3.5 KiB
Markdown
# TH-04 accent shell component verification
|
|
|
|
Execution checkout: `/Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj`, branch `codex/scada-ui-consistency`. Scope is the ThemeShell parameter/markup portion of TH-04 only. Shared release target 1.0.0 was selected by TH-01; this slice does not edit the package version, CSS, shared README or token documentation.
|
|
|
|
## Changes
|
|
|
|
- `ZB.MOM.WW.Theme/src/ZB.MOM.WW.Theme/Components/ThemeShell.razor`: additive nullable `AccentDeep`, `AccentTint`, `AccentBorder`, `AccentFocus` parameters, mapped respectively to `--accent-deep`, `--accent-tint`, `--accent-border`, `--accent-focus` on the shell root.
|
|
- Existing `Accent` remains the `--accent` override. Only non-null supplied values emit declarations; no default companion values are manufactured. No style attribute emits when all five values are null, including after a rerender. Accent-only formatting remains unchanged.
|
|
- Parameter documentation identifies styling values as trusted application configuration. Existing shell structure, child/nav slots, ScrollNav, native mobile disclosure and SSR behavior are unchanged.
|
|
- `ZB.MOM.WW.Theme/tests/ZB.MOM.WW.Theme.Tests/ThemeShellTests.cs`: preserved all eight existing tests; added five regressions for full-family emission, exact Accent-only behavior, companion-only override, clearing overrides on rerender, and nested shell declaration scope.
|
|
|
|
## Actual red and green checks
|
|
|
|
The new tests were added before the parameters. The first targeted test command failed compilation with missing `AccentDeep`, `AccentTint`, `AccentBorder`, `AccentFocus` members, as expected (`accent-shell-red.log`). After implementing the additive parameters, the final focused run passed **13 tests, zero failures, zero skips** (`accent-shell-green.log`, `accent-shell-results/accent-shell.trx`). The shared test project briefly contained other workers' red field/button tests; the final green run occurred after those components compiled. No other worker's files were modified to resolve that temporary compilation dependency.
|
|
|
|
Cwd: `/Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/ZB.MOM.WW.Theme`.
|
|
|
|
```sh
|
|
dotnet test tests/ZB.MOM.WW.Theme.Tests/ZB.MOM.WW.Theme.Tests.csproj --artifacts-path /tmp/theme-shell-artifacts -c Release --filter FullyQualifiedName~ThemeShellTests --logger "trx;LogFileName=accent-shell.trx" --results-directory /Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/components/ui-theme/validation/theme-1.0.0/accent-shell-results
|
|
```
|
|
|
|
An isolated artifacts path avoided collision with the parent's standard-output integration suite. Static-source asset tests assume the normal output layout, so the parent owns the aggregate test run from that layout. This slice does not claim an isolated-path full suite pass.
|
|
|
|
`git diff --check` passed for the two modified source/test files. The Impeccable mechanical detector ran once on ThemeShell source and reported an empty finding list (`accent-shell-detector.json`).
|
|
|
|
## Acceptance boundary
|
|
|
|
Nested-shell tests prove that each rendered shell declares its supplied family only on its own root and that no declarations are copied to child content. They **do not** prove browser inheritance, computed active/hover/focus colors, contrast, Bootstrap variable rebinding or supported-engine rendering. CSS integration, default/green/teal/purple browser pilots and computed-style acceptance remain with the parent; complete TH-04 remains partial until those checks are recorded. No browser acceptance claim, package publication, deployment or commit was made by this slice.
|