Files
scadaproj/components/ui-theme/validation/ot-ui/simple-wrapper-review.md
T

2.1 KiB

Independent first five wrapper review

Reviewed actual source for RawNameDialog, RawDriverTypeDialog, RawStubModal, AreaModal and LineModal, including final c086f977/3ef919a7 safeguard. No additional blocker under the supplied loaded-DTO/callback contracts.

  • Presentation-local handlers capture submit/cancel/saved callbacks and generations. Submitted scalar data and row-version arrays detach before await; stale results do not apply errors or saved/close callbacks to replacements. Global per-instance single-flight remains until an already-dispatched operation returns.
  • Raw submit-then-close order, driver type table/default, RawPath validation, area/line DTO mappings and data annotations remain. External form-button associations point to per-instance form IDs; Cancel remains safe initial focus and busy controls are disabled.
  • Final missing-edit-DTO guard prevents an old populated draft being updated with an empty rowversion when Existing becomes null. Producer retained its two red cases and final49-unit/15-native186-check plus final32-check confirmation proof; this review did not independently rerun those suites.

Caller work remains explicitly outside these wrappers' acceptance. RawDriverType and RawName require explicit stable target identity for different nodes sharing captions/initial values. RawTree must queue blocked/warning messages until the originating modal hides; actual removal/native cleanup must precede follow-up activation under the single-active policy. Native MutationObserver cleanup and generation-specific deactivation protect a new sibling dialog, but actual composed caller behavior still needs its own regression/browser proof.

GlobalUns OnModalSavedAsync and ReloadAndCloseAsync await LoadStructureAsync then unconditionally CloseModals. Caller generations must prevent an earlier save/reload completion closing replacement B after the wrapper has already invoked its captured OnSaved. Existing service/callback exception propagation is preserved; arbitrary stale exceptions or all future caller compositions are not newly certified here. No source UI edit was made as part of this review.