docs(ui): record accepted native pilot and consumer checkpoints

This commit is contained in:
Joseph Doherty
2026-11-13 17:52:31 -05:00
parent 46556dbb56
commit 447f3c8bf0
5 changed files with 109 additions and 28 deletions
@@ -0,0 +1,20 @@
# Independent MX native-dialog pilot review
Reviewed 2026-11-13 against the current uncommitted NativeDialog.razor, ConfirmDialog.razor, ApiKeysPage integration and dashboard-dialog.js. Read-only source/evidence review; no MX edits, fresh browser run, live action or deployment.
**No additional current-caller lifecycle blocker found.** Final MX02 acceptance still requires the parent's already identified create-validation alert visibility correction and its retained verification. Do not copy an unaccepted snapshot into OEE02.
- The adapter keeps its dialog element stable, serializes import/open/close/disposal with a lifecycle semaphore, and uses generation/target checks to discard superseded imports/cancel requests. Disposal is idempotent, marks the instance disposed before awaiting lifecycle completion, closes the native presentation and releases its module/self references. This matches the retained pending-import/hide/dispose/reopen lifecycle evidence.
- Native cancel events are prevented synchronously using their actual DOM event. Client pending/busy guards cover the first server round trip; dispatcher-side checks reject stale, repeated or busy cancellation. Current ConfirmDialog/API-create parents also guard explicit button cancellation on their server-owned IsBusy state. No operation or confidential value crosses the adapter.
- Tab stays native. The parent's document.hasFocus condition correctly distinguishes focus inside the document from permitted browser-chrome focus; a custom Tab trap is not warranted.
- The single-active native presentation guard rejects a second modal before showModal. The local parent remains the authority for cancellation and operation state. Current idle rejection/cancel paths do not dispatch a gateway action.
- WeakMap state and disconnected-node observation clean up listeners and native presentation. Focus restoration checks connected/visible/enabled usability and verifies actual focus before selecting the heading fallback. Temporary heading tabindex is removed on blur, addressing the earlier connected-disabled/disconnected trigger class of failure.
- Confirmation title/description IDs are per-instance and match rendered content. Confirmations initially focus Cancel; the long create form now starts at Key ID. The existing OnSubmit integration calls the parent even for custom validation failure, allowing the adapter's update to clear client pending state.
## OEE02 integration requirements
Use a stable, non-confidential target identity such as a form/session key; do not bind Target to an editable name or changing validation message, which would request a new presentation. Router TechModal has 15 caller files and its parent-owned busy/cancel/draft rules must all remain explicit. Keep typed cancellation and persistence with the existing router handlers.
If a router form uses OnValidSubmit only or native constraint validation, ensure invalid submission is acknowledged back to the adapter's idle update; marking a submit click pending must not leave idle Escape suppressed after validation rejects it. MX's current OnSubmit/custom-validation path supplies that parent update. This is an integration requirement for reuse, not a demonstrated failure of the current MX create caller.
Preserve the strongest existing focus fallback and native behavior; keep the first two pilots local and documented before considering generic shared extraction. The recorded focused lifecycle/confirmation evidence is useful, but this review does not claim every downstream form or complete authentication/COM behavior has been exercised.
@@ -42,3 +42,8 @@ Recomputed both hashes; verified exact export file set, every payload hash, mani
Reviewed the parent's actual Overview browser-confirmation JSON: all 31 measurements have document scroll equal viewport width; page error list is empty. The real 200% case records720px/DPR2. Nine recorded functional outcomes cover filtering/full totals, clear focus, pause aging/held snapshot/resume latest, keyboard disclosure/escaped full diagnostics and reduced motion; three motion samples have opacity1/animation none. Raw descendant-rectangle flags are not universally empty: expanded evidence contains offscreen bold “members” descendants, so this review does not claim every descendant rectangle lies within the viewport. The supported claim is bounded document/card-grid layout with locally accessible evidence, not blanket empty element-overflow lists. Source labels use escaped values in that evidence markup. Actual Theme TRX remains105 passed with no failures/skips; exporter log records15 passing checks. No concrete final source/artifact blocker found in this reviewed scope.
This reviews exact bytes and retained runtime evidence, not fresh browser execution or fleet-wide consumer acceptance. Publication, independent delivered downloads and official-feed restore still require the parent's delivery record. No gate/ledger is changed here.
## Accepted delivery addendum
Parent delivery record now shows successful publication of these exact final bytes (NuGet exit0/static HTTP201). Independently rehashed both retained fresh downloads against the final995b117b/ad523234 hashes and the isolated official Overview restore's actual nupkg; its .nupkg.metadata source equals the official Gitea endpoint. This supersedes the pending-delivery wording above. No source/artifact/delivery blocker remains in the reviewed scope; fleet-wide consumer acceptance is not inferred. Ledger/gates remain parent-owned.