From 447f3c8bf03c6ed5f7c341a2d839757f98e8bc7c Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Fri, 13 Nov 2026 17:52:31 -0500 Subject: [PATCH] docs(ui): record accepted native pilot and consumer checkpoints --- .../validation/mx-ui/native-dialog-review.md | 20 ++++++ .../ui-theme/validation/theme-1.0.1/review.md | 5 ++ .../EXECUTION.md | 19 ++++++ .../MxAccessGateway.md | 27 ++++++++ .../tasks.json | 66 +++++++++++-------- 5 files changed, 109 insertions(+), 28 deletions(-) create mode 100644 components/ui-theme/validation/mx-ui/native-dialog-review.md diff --git a/components/ui-theme/validation/mx-ui/native-dialog-review.md b/components/ui-theme/validation/mx-ui/native-dialog-review.md new file mode 100644 index 0000000..b20620a --- /dev/null +++ b/components/ui-theme/validation/mx-ui/native-dialog-review.md @@ -0,0 +1,20 @@ +# Independent MX native-dialog pilot review + +Reviewed 2026-11-13 against the current uncommitted NativeDialog.razor, ConfirmDialog.razor, ApiKeysPage integration and dashboard-dialog.js. Read-only source/evidence review; no MX edits, fresh browser run, live action or deployment. + +**No additional current-caller lifecycle blocker found.** Final MX02 acceptance still requires the parent's already identified create-validation alert visibility correction and its retained verification. Do not copy an unaccepted snapshot into OEE02. + +- The adapter keeps its dialog element stable, serializes import/open/close/disposal with a lifecycle semaphore, and uses generation/target checks to discard superseded imports/cancel requests. Disposal is idempotent, marks the instance disposed before awaiting lifecycle completion, closes the native presentation and releases its module/self references. This matches the retained pending-import/hide/dispose/reopen lifecycle evidence. +- Native cancel events are prevented synchronously using their actual DOM event. Client pending/busy guards cover the first server round trip; dispatcher-side checks reject stale, repeated or busy cancellation. Current ConfirmDialog/API-create parents also guard explicit button cancellation on their server-owned IsBusy state. No operation or confidential value crosses the adapter. +- Tab stays native. The parent's document.hasFocus condition correctly distinguishes focus inside the document from permitted browser-chrome focus; a custom Tab trap is not warranted. +- The single-active native presentation guard rejects a second modal before showModal. The local parent remains the authority for cancellation and operation state. Current idle rejection/cancel paths do not dispatch a gateway action. +- WeakMap state and disconnected-node observation clean up listeners and native presentation. Focus restoration checks connected/visible/enabled usability and verifies actual focus before selecting the heading fallback. Temporary heading tabindex is removed on blur, addressing the earlier connected-disabled/disconnected trigger class of failure. +- Confirmation title/description IDs are per-instance and match rendered content. Confirmations initially focus Cancel; the long create form now starts at Key ID. The existing OnSubmit integration calls the parent even for custom validation failure, allowing the adapter's update to clear client pending state. + +## OEE02 integration requirements + +Use a stable, non-confidential target identity such as a form/session key; do not bind Target to an editable name or changing validation message, which would request a new presentation. Router TechModal has 15 caller files and its parent-owned busy/cancel/draft rules must all remain explicit. Keep typed cancellation and persistence with the existing router handlers. + +If a router form uses OnValidSubmit only or native constraint validation, ensure invalid submission is acknowledged back to the adapter's idle update; marking a submit click pending must not leave idle Escape suppressed after validation rejects it. MX's current OnSubmit/custom-validation path supplies that parent update. This is an integration requirement for reuse, not a demonstrated failure of the current MX create caller. + +Preserve the strongest existing focus fallback and native behavior; keep the first two pilots local and documented before considering generic shared extraction. The recorded focused lifecycle/confirmation evidence is useful, but this review does not claim every downstream form or complete authentication/COM behavior has been exercised. diff --git a/components/ui-theme/validation/theme-1.0.1/review.md b/components/ui-theme/validation/theme-1.0.1/review.md index f3c2c22..fa6520e 100644 --- a/components/ui-theme/validation/theme-1.0.1/review.md +++ b/components/ui-theme/validation/theme-1.0.1/review.md @@ -42,3 +42,8 @@ Recomputed both hashes; verified exact export file set, every payload hash, mani Reviewed the parent's actual Overview browser-confirmation JSON: all 31 measurements have document scroll equal viewport width; page error list is empty. The real 200% case records720px/DPR2. Nine recorded functional outcomes cover filtering/full totals, clear focus, pause aging/held snapshot/resume latest, keyboard disclosure/escaped full diagnostics and reduced motion; three motion samples have opacity1/animation none. Raw descendant-rectangle flags are not universally empty: expanded evidence contains offscreen bold “members” descendants, so this review does not claim every descendant rectangle lies within the viewport. The supported claim is bounded document/card-grid layout with locally accessible evidence, not blanket empty element-overflow lists. Source labels use escaped values in that evidence markup. Actual Theme TRX remains105 passed with no failures/skips; exporter log records15 passing checks. No concrete final source/artifact blocker found in this reviewed scope. This reviews exact bytes and retained runtime evidence, not fresh browser execution or fleet-wide consumer acceptance. Publication, independent delivered downloads and official-feed restore still require the parent's delivery record. No gate/ledger is changed here. + + +## Accepted delivery addendum + +Parent delivery record now shows successful publication of these exact final bytes (NuGet exit0/static HTTP201). Independently rehashed both retained fresh downloads against the final995b117b/ad523234 hashes and the isolated official Overview restore's actual nupkg; its .nupkg.metadata source equals the official Gitea endpoint. This supersedes the pending-delivery wording above. No source/artifact/delivery blocker remains in the reviewed scope; fleet-wide consumer acceptance is not inferred. Ledger/gates remain parent-owned. diff --git a/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md b/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md index 4e01a7c..f160439 100644 --- a/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md +++ b/docs/plans/2026-11-12-scada-ui-consistency/EXECUTION.md @@ -72,3 +72,22 @@ acceptance. No G2/G3 completion or application deployment claimed. MxAccessGateway clean existing checkout moved from main to authorized codex branch; pre-change dashboard341/341 passes. No COM/worker/proto/options/auth changes. + +## Native pilot and consumer checkpoint — November 13, 2026 + +MX native pilot committed260d58af plus raw evidence5a1daab9 in the authorized +sister checkout. Framework HtmlRenderer remains;341 baseline identities retained +and343 dashboard tests pass. Actual native/browser and focused deferred-import, +disposal, focus fallback and validation-visibility checks pass. Native browser +chrome focus is distinguished with document.hasFocus under W3C H102; no custom Tab +trap. MX02 complete; MX01 starting. OEE02 may now perform its second native pilot. +No generic dialog extraction is claimed. + +Secrets05–06 committed46556db,81 tests and93 final two-host browser checks after +exact official Theme1.0.1 restoration. The cached unpublished candidate was caught +by served-byte checks; only its known root-created cache entry was removed/refilled. +SEC07 minimal package/release compatibility work is in progress, publication held +for independent artifact review. SB01–02 committed87c882ec; exact Theme1.0.1 pin +20885b61 has1557 full tests. SB03 composite/help acceptance still in progress. +OEE01/05/06/07 observed source/test/browser proofs accepted; remaining native and +cross-page contracts remain in progress. G2/G3 and whole100-task objective stay open. diff --git a/docs/plans/2026-11-12-scada-ui-consistency/MxAccessGateway.md b/docs/plans/2026-11-12-scada-ui-consistency/MxAccessGateway.md index a71e1b8..98da655 100644 --- a/docs/plans/2026-11-12-scada-ui-consistency/MxAccessGateway.md +++ b/docs/plans/2026-11-12-scada-ui-consistency/MxAccessGateway.md @@ -417,3 +417,30 @@ No runtime timestamps or status values in a mockup are deployment evidence. Keep 6. Removing the native dialog enhancement must restore its previous component version coherently; do not roll back just the JS module while leaving calling markup. Validate browse/watch and session confirmation after rollback. **Done:** every finding above is mapped, tests and actual browser outcomes are recorded, shared look/feel agrees with G1, and runtime/permission boundaries are preserved. + +## Execution clarification — native pilot, November 13, 2026 + +GB and shared delivery gates passed; current exact Theme target is 1.0.1. MX-02 is +being piloted before the other local tasks because its native behavior is a +prerequisite for OEE-02 and is independent of MX-01. Add app-local +`Dashboard/Components/Shared/NativeDialog.razor` to MX-02's file set so confirmation +and the existing create-key form share one lifecycle/interop adapter. This is not +a new shared package or extraction decision. Keep field/form content and all +management policies, validation/request construction, single-flight ownership and +one-time-token handling in their current page. Render failed create feedback inside +the active native modal; never pass field values or tokens through JS. + +Framework HtmlRenderer tests remain; no bUnit dependency is introduced. The browser +host under `docs/ui-validation/host/` uses actual components with inert snapshot +and fake management services only, OS-assigned loopback port, canonical Theme and +actual Bootstrap/site assets. No COM, worker, real key store or live writes. + +The native pilot's browser focus assertion distinguishes application focus from +browser chrome: require `dialog.contains(document.activeElement)` whenever +`document.hasFocus()` is true. Native Chromium may Tab to its own chrome and report +BODY with document focus false; this is expected native behavior, not access to an +underlying application control. W3C's [native dialog technique H102](https://www.w3.org/WAI/WCAG22/Techniques/html/H102) +explicitly includes browser chrome in the permitted focus scope. Keep native Tab +behavior; test outside application controls remain inert. The illustrative snippet +above is stricter than that native-browser acceptance condition and must not force +an unnecessary custom Tab trap. diff --git a/docs/plans/2026-11-12-scada-ui-consistency/tasks.json b/docs/plans/2026-11-12-scada-ui-consistency/tasks.json index 881feaf..a0c18e7 100644 --- a/docs/plans/2026-11-12-scada-ui-consistency/tasks.json +++ b/docs/plans/2026-11-12-scada-ui-consistency/tasks.json @@ -342,29 +342,31 @@ "title": "Improve metadata scanning and row-action context", "chapter": "Secrets.md", "line": 159, - "status": "in_progress", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "evidence": "components/ui-theme/validation/secrets-ui/SEC05-06.md (46556db;81tests,93renderedchecks)" }, { "id": "SEC-06", "title": "Keep reveal outcomes discoverable without announcing plaintext", "chapter": "Secrets.md", "line": 185, - "status": "in_progress", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "evidence": "components/ui-theme/validation/secrets-ui/SEC05-06.md (46556db;81tests,93renderedchecks)" }, { "id": "SEC-07", "title": "Package and host integration evidence", "chapter": "Secrets.md", "line": 209, - "status": "planned", + "status": "in_progress", "prerequisiteGates": [ "GB" ], @@ -460,40 +462,43 @@ "title": "Compatibility adoption and baseline captures", "chapter": "ScadaBridge.md", "line": 49, - "status": "planned", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "evidence": "ScadaBridge commit20885b61; docs/ui-consistency/ScadaBridge-verification.md; exact official Theme1.0.1/1557tests" }, { "id": "SB-01", "title": "Name reusable dialogs and prompt fields", "chapter": "ScadaBridge.md", "line": 59, - "status": "planned", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "evidence": "ScadaBridge commit87c882ec; docs/ui-consistency/ScadaBridge-verification.md" }, { "id": "SB-02", "title": "Pilot robust modal keyboard behavior in audit drawer", "chapter": "ScadaBridge.md", "line": 79, - "status": "planned", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "evidence": "ScadaBridge commit87c882ec; focus fallback and single-active native-overlay regressions" }, { "id": "SB-03", "title": "Wire labels, hints and errors across forms and filters", "chapter": "ScadaBridge.md", "line": 91, - "status": "planned", + "status": "in_progress", "prerequisiteGates": [ "GB" ], @@ -790,7 +795,7 @@ "title": "Make tree expansion and watching explicit", "chapter": "MxAccessGateway.md", "line": 85, - "status": "planned", + "status": "in_progress", "prerequisiteGates": [ "GB" ], @@ -801,11 +806,12 @@ "title": "Pilot native dialogs with actual focus management", "chapter": "MxAccessGateway.md", "line": 129, - "status": "planned", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "evidence": "MxAccessGateway260d58af/5a1daab9; docs/ui-validation/technical-light-dialogs.md;343dashboardtests,actualnative/lifecycle/validationproof" }, { "id": "MX-03", @@ -1087,18 +1093,19 @@ "title": "Give Jobs details a semantic keyboard disclosure", "chapter": "ignitionoee.md", "line": 67, - "status": "planned", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "evidence": "ignitionoee bed0d29; docs/ui-validation/technical-light-family.md;semanticJobsdisclosurekeyboard/fullGuid" }, { "id": "OEE-02", "title": "Pilot complete native modal behavior in router", "chapter": "ignitionoee.md", "line": 116, - "status": "planned", + "status": "in_progress", "prerequisiteGates": [ "GB" ], @@ -1109,7 +1116,7 @@ "title": "Import canonical static assets without a private registry feed", "chapter": "ignitionoee.md", "line": 208, - "status": "planned", + "status": "in_progress", "prerequisiteGates": [ "GB" ], @@ -1120,7 +1127,7 @@ "title": "Map shared tokens into native Perspective views", "chapter": "ignitionoee.md", "line": 250, - "status": "planned", + "status": "in_progress", "prerequisiteGates": [ "GB" ], @@ -1131,40 +1138,43 @@ "title": "Keep long router navigation and sign-out reachable", "chapter": "ignitionoee.md", "line": 287, - "status": "planned", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "evidence": "ignitionoee bed0d29; docs/ui-validation/technical-light-family.md;longnav/signout/390pxwrap+realzoom" }, { "id": "OEE-06", "title": "Preserve scope across related scheduling screens", "chapter": "ignitionoee.md", "line": 315, - "status": "planned", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "evidence": "ignitionoee f773ff5; docs/ui-validation/technical-light-family.md;1688tests+actualroute/contextmatrix" }, { "id": "OEE-07", "title": "Standardize issue-state feedback without hiding consequences", "chapter": "ignitionoee.md", "line": 368, - "status": "planned", + "status": "completed", "prerequisiteGates": [ "GB" ], - "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task." + "dependencies": "GB is mandatory before every UI task; additional G1/G2/chapter dependencies remain in the master and named task.", + "evidence": "ignitionoee89778c4 and61e70fa; docs/ui-validation/technical-light-family.md;atomicstale/retry+unsolicitedcancellationregressions" }, { "id": "OEE-08", "title": "Reuse wrapping toolbar/table contracts across router", "chapter": "ignitionoee.md", "line": 400, - "status": "planned", + "status": "in_progress", "prerequisiteGates": [ "GB" ], @@ -1175,7 +1185,7 @@ "title": "Keep eligibility and verification semantics distinct from health", "chapter": "ignitionoee.md", "line": 433, - "status": "planned", + "status": "in_progress", "prerequisiteGates": [ "GB" ],