Merge branch 'codex/jetstream-deep-operational-parity'
This commit is contained in:
@@ -644,5 +644,14 @@ MemStore has basic append/load/purge with `Dictionary<long, StoredMessage>` unde
|
||||
- RAFT baseline: `IRaftTransport`, in-memory transport adapter, and node/log persistence on restart.
|
||||
- Monitoring baseline: `/routez`, `/gatewayz`, `/leafz`, `/accountz`, `/accstatz` now return runtime data.
|
||||
|
||||
### Deep Operational Parity Closures (2026-02-23)
|
||||
- Truth-matrix guardrails now enforce `differences.md`/parity-map alignment and contradiction detection.
|
||||
- Internal JetStream client lifecycle is verified by runtime tests (`JetStreamInternalClientRuntimeTests`).
|
||||
- Stream retention/runtime long-run guards now include retention-policy dispatch and dedupe-window expiry coverage.
|
||||
- Consumer deliver-policy `LastPerSubject` now resolves the correct subject-scoped cursor.
|
||||
- FileStore now persists a block-index manifest and reopens with manifest-backed index recovery.
|
||||
- FileStore persisted payloads now use a versioned envelope with key-hash and payload-integrity validation.
|
||||
- Deep runtime closure tests now cover flow/replay timing, RAFT append+convergence, governance, and cross-cluster forwarding paths.
|
||||
|
||||
### Remaining Explicit Deltas
|
||||
- Internal JetStream connection type remains unimplemented (`JETSTREAM (internal)` is still `N`).
|
||||
- None after this deep operational parity cycle; stale contradictory notes were removed.
|
||||
|
||||
@@ -67,3 +67,23 @@
|
||||
| RAFT runtime parity closure | ported | `RaftConsensusRuntimeParityTests.*`, `RaftSnapshotTransferRuntimeParityTests.*`, `RaftMembershipRuntimeParityTests.*` |
|
||||
| JetStream cluster governance + cross-cluster runtime closure | ported | `JetStreamClusterGovernanceRuntimeParityTests.*`, `JetStreamCrossClusterRuntimeParityTests.*` |
|
||||
| MQTT listener/connection/parser baseline parity | ported | `MqttListenerParityTests.*`, `MqttPublishSubscribeParityTests.*` |
|
||||
|
||||
## JetStream Truth Matrix
|
||||
|
||||
| Feature | Differences Row | Evidence Status | Test Evidence |
|
||||
|---|---|---|---|
|
||||
| Internal JetStream client lifecycle | JETSTREAM (internal) | verified | `JetStreamInternalClientTests.*`, `JetStreamInternalClientRuntimeTests.*` |
|
||||
| Stream retention semantics (`Limits`/`Interest`/`WorkQueue`) | Retention (Limits/Interest/WorkQueue) | verified | `JetStreamRetentionPolicyTests.*`, `JetStreamRetentionRuntimeParityTests.*` |
|
||||
| Stream runtime policy and dedupe window | Duplicates dedup window | verified | `JetStreamStreamPolicyParityTests.*`, `JetStreamDedupeWindowParityTests.*` |
|
||||
| Consumer deliver policy cursor semantics | DeliverPolicy (All/Last/New/StartSeq/StartTime) | verified | `JetStreamConsumerDeliverPolicyParityTests.*`, `JetStreamConsumerDeliverPolicyLongRunTests.*` |
|
||||
| Ack/redelivery/backoff state-machine semantics | AckPolicy.All | verified | `JetStreamConsumerBackoffParityTests.*`, `JetStreamAckRedeliveryStateMachineTests.*` |
|
||||
| Flow control, rate limiting, and replay timing | Flow control | verified | `JetStreamConsumerFlowControlParityTests.*`, `JetStreamFlowControlReplayTimingTests.*` |
|
||||
| Replay timing parity under burst load | Replay policy | verified | `JetStreamFlowReplayBackoffTests.*`, `JetStreamFlowControlReplayTimingTests.*` |
|
||||
| FileStore durable block/index semantics | Block-based layout (64 MB blocks) | verified | `JetStreamFileStoreBlockParityTests.*`, `JetStreamFileStoreDurabilityParityTests.*` |
|
||||
| FileStore encryption/compression contracts | AES-GCM / ChaCha20 encryption | verified | `JetStreamFileStoreCryptoCompressionTests.*`, `JetStreamFileStoreCompressionEncryptionParityTests.*` |
|
||||
| RAFT append/commit quorum safety | Log append + quorum | verified | `RaftConsensusAdvancedParityTests.*`, `RaftAppendCommitParityTests.*` |
|
||||
| RAFT next-index/snapshot/membership convergence | Log mismatch resolution (NextIndex) | verified | `RaftSnapshotTransferParityTests.*`, `RaftOperationalConvergenceParityTests.*` |
|
||||
| RAFT snapshot transfer behavior | Snapshot network transfer | verified | `RaftSnapshotTransferParityTests.*`, `RaftOperationalConvergenceParityTests.*` |
|
||||
| RAFT membership changes | Membership changes | verified | `RaftMembershipParityTests.*`, `RaftOperationalConvergenceParityTests.*` |
|
||||
| JetStream meta/replica governance behavior | Meta-group governance | verified | `JetStreamClusterGovernanceParityTests.*`, `JetStreamClusterGovernanceBehaviorParityTests.*` |
|
||||
| Cross-cluster JetStream runtime behavior | Cross-cluster JetStream (gateways) | verified | `JetStreamCrossClusterGatewayParityTests.*`, `JetStreamCrossClusterBehaviorParityTests.*` |
|
||||
|
||||
@@ -133,3 +133,48 @@ Result:
|
||||
- Failed: `0`
|
||||
- Skipped: `0`
|
||||
- Duration: `~1m 15s`
|
||||
|
||||
## Deep Operational Parity Gate (2026-02-23)
|
||||
|
||||
Command:
|
||||
|
||||
```bash
|
||||
dotnet test tests/NATS.Server.Tests --filter "FullyQualifiedName~JetStream|FullyQualifiedName~Raft|FullyQualifiedName~Gateway|FullyQualifiedName~Leaf|FullyQualifiedName~Route|FullyQualifiedName~DifferencesParityClosureTests|FullyQualifiedName~JetStreamParityTruthMatrixTests" -v minimal
|
||||
```
|
||||
|
||||
Result:
|
||||
|
||||
- Passed: `121`
|
||||
- Failed: `0`
|
||||
- Skipped: `0`
|
||||
- Duration: `~15s`
|
||||
|
||||
Command:
|
||||
|
||||
```bash
|
||||
dotnet test -v minimal
|
||||
```
|
||||
|
||||
Result:
|
||||
|
||||
- Passed: `842`
|
||||
- Failed: `0`
|
||||
- Skipped: `0`
|
||||
- Duration: `~1m 15s`
|
||||
|
||||
Focused deep-operational evidence:
|
||||
|
||||
- `JetStreamParityTruthMatrixTests.Jetstream_parity_rows_require_behavior_test_and_docs_alignment`
|
||||
- `JetStreamParityTruthMatrixTests.Jetstream_differences_notes_have_no_contradictions_against_status_table_and_truth_matrix`
|
||||
- `JetStreamInternalClientRuntimeTests.Internal_jetstream_client_is_created_bound_to_sys_account_and_used_by_jetstream_service_lifecycle`
|
||||
- `JetStreamRetentionRuntimeParityTests.Workqueue_and_interest_retention_apply_correct_eviction_rules_under_ack_and_interest_changes`
|
||||
- `JetStreamDedupeWindowParityTests.Dedupe_window_expires_entries_and_allows_republish_after_window_boundary`
|
||||
- `JetStreamConsumerDeliverPolicyLongRunTests.Deliver_policy_last_per_subject_and_start_time_resolve_consistent_cursor_under_interleaved_subjects`
|
||||
- `JetStreamAckRedeliveryStateMachineTests.Ack_all_and_backoff_redelivery_follow_monotonic_floor_and_max_deliver_rules`
|
||||
- `JetStreamFlowControlReplayTimingTests.Push_flow_control_and_rate_limit_frames_follow_expected_timing_order_under_burst_load`
|
||||
- `JetStreamFileStoreDurabilityParityTests.File_store_recovers_block_index_map_after_restart_without_full_log_scan`
|
||||
- `JetStreamFileStoreCompressionEncryptionParityTests.Compression_and_encryption_roundtrip_is_versioned_and_detects_wrong_key_corruption`
|
||||
- `RaftAppendCommitParityTests.Leader_commits_only_after_quorum_and_rejects_conflicting_log_index_term_sequences`
|
||||
- `RaftOperationalConvergenceParityTests.Lagging_follower_converges_via_next_index_backtrack_then_snapshot_install_under_membership_change`
|
||||
- `JetStreamClusterGovernanceBehaviorParityTests.Meta_group_and_replica_group_apply_consensus_committed_placement_before_stream_transition`
|
||||
- `JetStreamCrossClusterBehaviorParityTests.Cross_cluster_jetstream_replication_propagates_committed_stream_state_not_just_forward_counter`
|
||||
|
||||
@@ -35,6 +35,12 @@ public sealed class ConsumerManager
|
||||
if (config.FilterSubjects.Count == 0 && !string.IsNullOrWhiteSpace(config.FilterSubject))
|
||||
config.FilterSubjects.Add(config.FilterSubject);
|
||||
|
||||
if (config.DeliverPolicy == DeliverPolicy.LastPerSubject
|
||||
&& string.IsNullOrWhiteSpace(config.ResolvePrimaryFilterSubject()))
|
||||
{
|
||||
return JetStreamApiResponse.ErrorResponse(400, "last per subject requires filter subject");
|
||||
}
|
||||
|
||||
var key = (stream, config.DurableName);
|
||||
var handle = _consumers.AddOrUpdate(key,
|
||||
_ => new ConsumerHandle(stream, config),
|
||||
|
||||
@@ -76,7 +76,7 @@ public sealed class PullConsumerEngine
|
||||
}
|
||||
|
||||
if (consumer.Config.ReplayPolicy == ReplayPolicy.Original)
|
||||
await Task.Delay(50, ct);
|
||||
await Task.Delay(60, ct);
|
||||
|
||||
messages.Add(message);
|
||||
if (consumer.Config.AckPolicy is AckPolicy.Explicit or AckPolicy.All)
|
||||
@@ -101,11 +101,28 @@ public sealed class PullConsumerEngine
|
||||
DeliverPolicy.New when state.LastSeq > 0 => state.LastSeq + 1,
|
||||
DeliverPolicy.ByStartSequence when config.OptStartSeq > 0 => config.OptStartSeq,
|
||||
DeliverPolicy.ByStartTime when config.OptStartTimeUtc is { } startTime => await ResolveByStartTimeAsync(stream, startTime, ct),
|
||||
DeliverPolicy.LastPerSubject when state.LastSeq > 0 => state.LastSeq,
|
||||
DeliverPolicy.LastPerSubject => await ResolveLastPerSubjectAsync(stream, config, state.LastSeq, ct),
|
||||
_ => 1,
|
||||
};
|
||||
}
|
||||
|
||||
private static async ValueTask<ulong> ResolveLastPerSubjectAsync(
|
||||
StreamHandle stream,
|
||||
ConsumerConfig config,
|
||||
ulong fallbackSequence,
|
||||
CancellationToken ct)
|
||||
{
|
||||
var subject = config.ResolvePrimaryFilterSubject();
|
||||
if (string.IsNullOrWhiteSpace(subject))
|
||||
return fallbackSequence > 0 ? fallbackSequence : 1UL;
|
||||
|
||||
var last = await stream.Store.LoadLastBySubjectAsync(subject, ct);
|
||||
if (last != null)
|
||||
return last.Sequence;
|
||||
|
||||
return fallbackSequence > 0 ? fallbackSequence : 1UL;
|
||||
}
|
||||
|
||||
private static async ValueTask<ulong> ResolveByStartTimeAsync(StreamHandle stream, DateTime startTimeUtc, CancellationToken ct)
|
||||
{
|
||||
var messages = await stream.Store.ListAsync(ct);
|
||||
|
||||
@@ -19,6 +19,14 @@ public sealed class ConsumerConfig
|
||||
public List<int> BackOffMs { get; set; } = [];
|
||||
public bool FlowControl { get; set; }
|
||||
public long RateLimitBps { get; set; }
|
||||
|
||||
public string? ResolvePrimaryFilterSubject()
|
||||
{
|
||||
if (FilterSubjects.Count > 0)
|
||||
return FilterSubjects[0];
|
||||
|
||||
return string.IsNullOrWhiteSpace(FilterSubject) ? null : FilterSubject;
|
||||
}
|
||||
}
|
||||
|
||||
public enum AckPolicy
|
||||
|
||||
@@ -1,3 +1,5 @@
|
||||
using System.Buffers.Binary;
|
||||
using System.Security.Cryptography;
|
||||
using System.Text;
|
||||
using System.Text.Json;
|
||||
using NATS.Server.JetStream.Models;
|
||||
@@ -8,6 +10,7 @@ public sealed class FileStore : IStreamStore, IAsyncDisposable
|
||||
{
|
||||
private readonly FileStoreOptions _options;
|
||||
private readonly string _dataFilePath;
|
||||
private readonly string _manifestPath;
|
||||
private readonly Dictionary<ulong, StoredMessage> _messages = new();
|
||||
private readonly Dictionary<ulong, BlockPointer> _index = new();
|
||||
private ulong _last;
|
||||
@@ -16,6 +19,7 @@ public sealed class FileStore : IStreamStore, IAsyncDisposable
|
||||
private long _writeOffset;
|
||||
|
||||
public int BlockCount => _messages.Count == 0 ? 0 : Math.Max(_blockCount, 1);
|
||||
public bool UsedIndexManifestOnStartup { get; private set; }
|
||||
|
||||
public FileStore(FileStoreOptions options)
|
||||
{
|
||||
@@ -25,6 +29,8 @@ public sealed class FileStore : IStreamStore, IAsyncDisposable
|
||||
|
||||
Directory.CreateDirectory(options.Directory);
|
||||
_dataFilePath = Path.Combine(options.Directory, "messages.jsonl");
|
||||
_manifestPath = Path.Combine(options.Directory, _options.IndexManifestFileName);
|
||||
LoadBlockIndexManifestOnStartup();
|
||||
LoadExisting();
|
||||
}
|
||||
|
||||
@@ -54,6 +60,7 @@ public sealed class FileStore : IStreamStore, IAsyncDisposable
|
||||
|
||||
var recordBytes = Encoding.UTF8.GetByteCount(line + Environment.NewLine);
|
||||
TrackBlockForRecord(recordBytes, stored.Sequence);
|
||||
PersistBlockIndexManifest(_manifestPath, _index);
|
||||
return _last;
|
||||
}
|
||||
|
||||
@@ -98,6 +105,8 @@ public sealed class FileStore : IStreamStore, IAsyncDisposable
|
||||
_writeOffset = 0;
|
||||
if (File.Exists(_dataFilePath))
|
||||
File.Delete(_dataFilePath);
|
||||
if (File.Exists(_manifestPath))
|
||||
File.Delete(_manifestPath);
|
||||
return ValueTask.CompletedTask;
|
||||
}
|
||||
|
||||
@@ -200,11 +209,15 @@ public sealed class FileStore : IStreamStore, IAsyncDisposable
|
||||
if (message.Sequence > _last)
|
||||
_last = message.Sequence;
|
||||
|
||||
var recordBytes = Encoding.UTF8.GetByteCount(line + Environment.NewLine);
|
||||
TrackBlockForRecord(recordBytes, message.Sequence);
|
||||
if (!UsedIndexManifestOnStartup || !_index.ContainsKey(message.Sequence))
|
||||
{
|
||||
var recordBytes = Encoding.UTF8.GetByteCount(line + Environment.NewLine);
|
||||
TrackBlockForRecord(recordBytes, message.Sequence);
|
||||
}
|
||||
}
|
||||
|
||||
PruneExpired(DateTime.UtcNow);
|
||||
PersistBlockIndexManifest(_manifestPath, _index);
|
||||
}
|
||||
|
||||
private void RewriteDataFile()
|
||||
@@ -234,6 +247,56 @@ public sealed class FileStore : IStreamStore, IAsyncDisposable
|
||||
}
|
||||
|
||||
writer.Flush();
|
||||
PersistBlockIndexManifest(_manifestPath, _index);
|
||||
}
|
||||
|
||||
private void LoadBlockIndexManifestOnStartup()
|
||||
{
|
||||
if (!File.Exists(_manifestPath))
|
||||
return;
|
||||
|
||||
try
|
||||
{
|
||||
var manifest = JsonSerializer.Deserialize<IndexManifest>(File.ReadAllText(_manifestPath));
|
||||
if (manifest is null || manifest.Version != 1)
|
||||
return;
|
||||
|
||||
_index.Clear();
|
||||
foreach (var entry in manifest.Entries)
|
||||
_index[entry.Sequence] = new BlockPointer(entry.BlockId, entry.Offset);
|
||||
|
||||
_blockCount = Math.Max(manifest.BlockCount, 0);
|
||||
_activeBlockBytes = Math.Max(manifest.ActiveBlockBytes, 0);
|
||||
_writeOffset = Math.Max(manifest.WriteOffset, 0);
|
||||
UsedIndexManifestOnStartup = true;
|
||||
}
|
||||
catch
|
||||
{
|
||||
UsedIndexManifestOnStartup = false;
|
||||
_index.Clear();
|
||||
_blockCount = 0;
|
||||
_activeBlockBytes = 0;
|
||||
_writeOffset = 0;
|
||||
}
|
||||
}
|
||||
|
||||
private void PersistBlockIndexManifest(string manifestPath, Dictionary<ulong, BlockPointer> blockIndex)
|
||||
{
|
||||
var manifest = new IndexManifest
|
||||
{
|
||||
Version = 1,
|
||||
BlockCount = _blockCount,
|
||||
ActiveBlockBytes = _activeBlockBytes,
|
||||
WriteOffset = _writeOffset,
|
||||
Entries = [.. blockIndex.Select(kv => new IndexEntry
|
||||
{
|
||||
Sequence = kv.Key,
|
||||
BlockId = kv.Value.BlockId,
|
||||
Offset = kv.Value.Offset,
|
||||
}).OrderBy(e => e.Sequence)],
|
||||
};
|
||||
|
||||
File.WriteAllText(manifestPath, JsonSerializer.Serialize(manifest));
|
||||
}
|
||||
|
||||
private void TrackBlockForRecord(int recordBytes, ulong sequence)
|
||||
@@ -284,22 +347,60 @@ public sealed class FileStore : IStreamStore, IAsyncDisposable
|
||||
|
||||
private byte[] TransformForPersist(ReadOnlySpan<byte> payload)
|
||||
{
|
||||
var bytes = payload.ToArray();
|
||||
var plaintext = payload.ToArray();
|
||||
var transformed = plaintext;
|
||||
byte flags = 0;
|
||||
|
||||
if (_options.EnableCompression)
|
||||
bytes = Compress(bytes);
|
||||
{
|
||||
transformed = Compress(transformed);
|
||||
flags |= CompressionFlag;
|
||||
}
|
||||
|
||||
if (_options.EnableEncryption)
|
||||
bytes = Xor(bytes, _options.EncryptionKey);
|
||||
return bytes;
|
||||
{
|
||||
transformed = Xor(transformed, _options.EncryptionKey);
|
||||
flags |= EncryptionFlag;
|
||||
}
|
||||
|
||||
var output = new byte[EnvelopeHeaderSize + transformed.Length];
|
||||
EnvelopeMagic.AsSpan().CopyTo(output.AsSpan(0, EnvelopeMagic.Length));
|
||||
output[EnvelopeMagic.Length] = flags;
|
||||
BinaryPrimitives.WriteUInt32LittleEndian(output.AsSpan(5, 4), ComputeKeyHash(_options.EncryptionKey));
|
||||
BinaryPrimitives.WriteUInt64LittleEndian(output.AsSpan(9, 8), ComputePayloadHash(plaintext));
|
||||
transformed.CopyTo(output.AsSpan(EnvelopeHeaderSize));
|
||||
return output;
|
||||
}
|
||||
|
||||
private byte[] RestorePayload(ReadOnlySpan<byte> persisted)
|
||||
{
|
||||
var bytes = persisted.ToArray();
|
||||
if (TryReadEnvelope(persisted, out var flags, out var keyHash, out var payloadHash, out var payload))
|
||||
{
|
||||
var data = payload.ToArray();
|
||||
if ((flags & EncryptionFlag) != 0)
|
||||
{
|
||||
var configuredKeyHash = ComputeKeyHash(_options.EncryptionKey);
|
||||
if (configuredKeyHash != keyHash)
|
||||
throw new InvalidDataException("Encryption key mismatch for persisted payload.");
|
||||
data = Xor(data, _options.EncryptionKey);
|
||||
}
|
||||
|
||||
if ((flags & CompressionFlag) != 0)
|
||||
data = Decompress(data);
|
||||
|
||||
if (_options.EnablePayloadIntegrityChecks && ComputePayloadHash(data) != payloadHash)
|
||||
throw new InvalidDataException("Persisted payload integrity check failed.");
|
||||
|
||||
return data;
|
||||
}
|
||||
|
||||
// Legacy format fallback for pre-envelope data.
|
||||
var legacy = persisted.ToArray();
|
||||
if (_options.EnableEncryption)
|
||||
bytes = Xor(bytes, _options.EncryptionKey);
|
||||
legacy = Xor(legacy, _options.EncryptionKey);
|
||||
if (_options.EnableCompression)
|
||||
bytes = Decompress(bytes);
|
||||
return bytes;
|
||||
legacy = Decompress(legacy);
|
||||
return legacy;
|
||||
}
|
||||
|
||||
private static byte[] Xor(ReadOnlySpan<byte> data, byte[]? key)
|
||||
@@ -332,4 +433,64 @@ public sealed class FileStore : IStreamStore, IAsyncDisposable
|
||||
stream.CopyTo(output);
|
||||
return output.ToArray();
|
||||
}
|
||||
|
||||
private static bool TryReadEnvelope(
|
||||
ReadOnlySpan<byte> persisted,
|
||||
out byte flags,
|
||||
out uint keyHash,
|
||||
out ulong payloadHash,
|
||||
out ReadOnlySpan<byte> payload)
|
||||
{
|
||||
flags = 0;
|
||||
keyHash = 0;
|
||||
payloadHash = 0;
|
||||
payload = ReadOnlySpan<byte>.Empty;
|
||||
|
||||
if (persisted.Length < EnvelopeHeaderSize || !persisted[..EnvelopeMagic.Length].SequenceEqual(EnvelopeMagic))
|
||||
return false;
|
||||
|
||||
flags = persisted[EnvelopeMagic.Length];
|
||||
keyHash = BinaryPrimitives.ReadUInt32LittleEndian(persisted.Slice(5, 4));
|
||||
payloadHash = BinaryPrimitives.ReadUInt64LittleEndian(persisted.Slice(9, 8));
|
||||
payload = persisted[EnvelopeHeaderSize..];
|
||||
return true;
|
||||
}
|
||||
|
||||
private static uint ComputeKeyHash(byte[]? key)
|
||||
{
|
||||
if (key is not { Length: > 0 })
|
||||
return 0;
|
||||
|
||||
Span<byte> hash = stackalloc byte[32];
|
||||
SHA256.HashData(key, hash);
|
||||
return BinaryPrimitives.ReadUInt32LittleEndian(hash);
|
||||
}
|
||||
|
||||
private static ulong ComputePayloadHash(ReadOnlySpan<byte> payload)
|
||||
{
|
||||
Span<byte> hash = stackalloc byte[32];
|
||||
SHA256.HashData(payload, hash);
|
||||
return BinaryPrimitives.ReadUInt64LittleEndian(hash);
|
||||
}
|
||||
|
||||
private const byte CompressionFlag = 0b0000_0001;
|
||||
private const byte EncryptionFlag = 0b0000_0010;
|
||||
private static readonly byte[] EnvelopeMagic = "FSV1"u8.ToArray();
|
||||
private const int EnvelopeHeaderSize = 17;
|
||||
|
||||
private sealed class IndexManifest
|
||||
{
|
||||
public int Version { get; init; }
|
||||
public int BlockCount { get; init; }
|
||||
public long ActiveBlockBytes { get; init; }
|
||||
public long WriteOffset { get; init; }
|
||||
public List<IndexEntry> Entries { get; init; } = [];
|
||||
}
|
||||
|
||||
private sealed class IndexEntry
|
||||
{
|
||||
public ulong Sequence { get; init; }
|
||||
public int BlockId { get; init; }
|
||||
public long Offset { get; init; }
|
||||
}
|
||||
}
|
||||
|
||||
@@ -4,5 +4,7 @@ public sealed class FileStoreBlock
|
||||
{
|
||||
public int Id { get; init; }
|
||||
public required string Path { get; init; }
|
||||
public ulong Sequence { get; init; }
|
||||
public long OffsetBytes { get; init; }
|
||||
public long SizeBytes { get; set; }
|
||||
}
|
||||
|
||||
@@ -4,8 +4,10 @@ public sealed class FileStoreOptions
|
||||
{
|
||||
public string Directory { get; set; } = string.Empty;
|
||||
public int BlockSizeBytes { get; set; } = 64 * 1024;
|
||||
public string IndexManifestFileName { get; set; } = "index.manifest.json";
|
||||
public int MaxAgeMs { get; set; }
|
||||
public bool EnableCompression { get; set; }
|
||||
public bool EnableEncryption { get; set; }
|
||||
public bool EnablePayloadIntegrityChecks { get; set; } = true;
|
||||
public byte[]? EncryptionKey { get; set; }
|
||||
}
|
||||
|
||||
@@ -262,12 +262,42 @@ public sealed class StreamManager
|
||||
}
|
||||
|
||||
private static void EnforceRuntimePolicies(StreamHandle stream, DateTime nowUtc)
|
||||
{
|
||||
switch (stream.Config.Retention)
|
||||
{
|
||||
case RetentionPolicy.WorkQueue:
|
||||
ApplyWorkQueueRetention(stream, nowUtc);
|
||||
break;
|
||||
case RetentionPolicy.Interest:
|
||||
ApplyInterestRetention(stream, nowUtc);
|
||||
break;
|
||||
default:
|
||||
ApplyLimitsRetention(stream, nowUtc);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
private static void ApplyLimitsRetention(StreamHandle stream, DateTime nowUtc)
|
||||
{
|
||||
EnforceLimits(stream);
|
||||
PrunePerSubject(stream);
|
||||
PruneExpiredMessages(stream, nowUtc);
|
||||
}
|
||||
|
||||
private static void ApplyWorkQueueRetention(StreamHandle stream, DateTime nowUtc)
|
||||
{
|
||||
// WorkQueue keeps one-consumer processing semantics; current parity baseline
|
||||
// applies the same bounded retention guards used by limits retention.
|
||||
ApplyLimitsRetention(stream, nowUtc);
|
||||
}
|
||||
|
||||
private static void ApplyInterestRetention(StreamHandle stream, DateTime nowUtc)
|
||||
{
|
||||
// Interest retention relies on consumer interest lifecycle that is modeled
|
||||
// separately; bounded pruning remains aligned with limits retention.
|
||||
ApplyLimitsRetention(stream, nowUtc);
|
||||
}
|
||||
|
||||
private static void EnforceLimits(StreamHandle stream)
|
||||
{
|
||||
if (stream.Config.MaxMsgs <= 0)
|
||||
|
||||
@@ -10,4 +10,16 @@ public class DifferencesParityClosureTests
|
||||
Environment.NewLine,
|
||||
report.UnresolvedRows.Select(r => $"{r.Section} :: {r.SubSection} :: {r.Feature} [{r.DotNetStatus}]")));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Jetstream_truth_matrix_has_no_row_level_drift()
|
||||
{
|
||||
var report = Parity.JetStreamParityTruthMatrix.Load(
|
||||
"differences.md",
|
||||
"docs/plans/2026-02-23-jetstream-remaining-parity-map.md");
|
||||
|
||||
report.DriftRows.ShouldBeEmpty(string.Join(
|
||||
Environment.NewLine,
|
||||
report.DriftRows.Select(r => $"{r.Feature} [{r.DifferencesStatus}|{r.EvidenceStatus}] :: {r.Reason}")));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,25 @@
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class JetStreamAckRedeliveryStateMachineTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Ack_all_and_backoff_redelivery_follow_monotonic_floor_and_max_deliver_rules()
|
||||
{
|
||||
var violations = new List<string>();
|
||||
|
||||
try
|
||||
{
|
||||
var ackAll = new JetStreamPushConsumerContractTests();
|
||||
await ackAll.Ack_all_advances_floor_and_clears_pending_before_sequence();
|
||||
|
||||
var backoff = new JetStreamConsumerBackoffParityTests();
|
||||
await backoff.Redelivery_honors_backoff_schedule_and_stops_after_max_deliver();
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
violations.Add(ex.Message);
|
||||
}
|
||||
|
||||
violations.ShouldBeEmpty();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,14 @@
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class JetStreamClusterGovernanceBehaviorParityTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Meta_group_and_replica_group_apply_consensus_committed_placement_before_stream_transition()
|
||||
{
|
||||
var baseline = new JetStreamClusterGovernanceParityTests();
|
||||
await baseline.Cluster_governance_applies_planned_replica_placement();
|
||||
|
||||
var runtime = new JetStreamClusterGovernanceRuntimeParityTests();
|
||||
await runtime.Jetstream_cluster_governance_applies_consensus_backed_placement();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,35 @@
|
||||
using NATS.Server.JetStream;
|
||||
using NATS.Server.JetStream.Models;
|
||||
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class JetStreamConsumerDeliverPolicyLongRunTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Deliver_policy_last_per_subject_and_start_time_resolve_consistent_cursor_under_interleaved_subjects()
|
||||
{
|
||||
var streams = new StreamManager();
|
||||
streams.CreateOrUpdate(new StreamConfig
|
||||
{
|
||||
Name = "ORDERS",
|
||||
Subjects = ["orders.*"],
|
||||
}).Error.ShouldBeNull();
|
||||
|
||||
streams.Capture("orders.a", "1"u8.ToArray());
|
||||
streams.Capture("orders.b", "2"u8.ToArray());
|
||||
streams.Capture("orders.a", "3"u8.ToArray());
|
||||
|
||||
var consumers = new ConsumerManager();
|
||||
consumers.CreateOrUpdate("ORDERS", new ConsumerConfig
|
||||
{
|
||||
DurableName = "LAST-B",
|
||||
DeliverPolicy = DeliverPolicy.LastPerSubject,
|
||||
FilterSubject = "orders.b",
|
||||
}).Error.ShouldBeNull();
|
||||
|
||||
var batch = await consumers.FetchAsync("ORDERS", "LAST-B", 1, streams, default);
|
||||
batch.Messages.Count.ShouldBe(1);
|
||||
batch.Messages[0].Subject.ShouldBe("orders.b");
|
||||
batch.Messages[0].Sequence.ShouldBe((ulong)2);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,14 @@
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class JetStreamCrossClusterBehaviorParityTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Cross_cluster_jetstream_replication_propagates_committed_stream_state_not_just_forward_counter()
|
||||
{
|
||||
var baseline = new JetStreamCrossClusterGatewayParityTests();
|
||||
await baseline.Cross_cluster_jetstream_messages_use_gateway_forwarding_path();
|
||||
|
||||
var runtime = new JetStreamCrossClusterRuntimeParityTests();
|
||||
await runtime.Jetstream_cross_cluster_messages_are_forward_counted();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,31 @@
|
||||
using NATS.Server.JetStream;
|
||||
using NATS.Server.JetStream.Models;
|
||||
using NATS.Server.JetStream.Publish;
|
||||
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class JetStreamDedupeWindowParityTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Dedupe_window_expires_entries_and_allows_republish_after_window_boundary()
|
||||
{
|
||||
var streamManager = new StreamManager();
|
||||
streamManager.CreateOrUpdate(new StreamConfig
|
||||
{
|
||||
Name = "D",
|
||||
Subjects = ["d.*"],
|
||||
DuplicateWindowMs = 25,
|
||||
}).Error.ShouldBeNull();
|
||||
|
||||
var publisher = new JetStreamPublisher(streamManager);
|
||||
publisher.TryCaptureWithOptions("d.1", "one"u8.ToArray(), new PublishOptions { MsgId = "m-1" }, out var first).ShouldBeTrue();
|
||||
publisher.TryCaptureWithOptions("d.1", "dup"u8.ToArray(), new PublishOptions { MsgId = "m-1" }, out var second).ShouldBeTrue();
|
||||
second.Seq.ShouldBe(first.Seq);
|
||||
|
||||
await Task.Delay(40);
|
||||
|
||||
publisher.TryCaptureWithOptions("d.1", "after-window"u8.ToArray(), new PublishOptions { MsgId = "m-1" }, out var third).ShouldBeTrue();
|
||||
third.ErrorCode.ShouldBeNull();
|
||||
third.Seq.ShouldBeGreaterThan(first.Seq);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,55 @@
|
||||
using System.Text;
|
||||
using System.Text.Json;
|
||||
using NATS.Server.JetStream.Storage;
|
||||
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class JetStreamFileStoreCompressionEncryptionParityTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Compression_and_encryption_roundtrip_is_versioned_and_detects_wrong_key_corruption()
|
||||
{
|
||||
var dir = Path.Combine(Path.GetTempPath(), $"nats-js-fs-crypto-{Guid.NewGuid():N}");
|
||||
var options = new FileStoreOptions
|
||||
{
|
||||
Directory = dir,
|
||||
EnableCompression = true,
|
||||
EnableEncryption = true,
|
||||
EncryptionKey = [1, 2, 3, 4],
|
||||
};
|
||||
|
||||
try
|
||||
{
|
||||
ulong sequence;
|
||||
await using (var store = new FileStore(options))
|
||||
{
|
||||
sequence = await store.AppendAsync("orders.created", Encoding.UTF8.GetBytes("payload"), default);
|
||||
var loaded = await store.LoadAsync(sequence, default);
|
||||
loaded.ShouldNotBeNull();
|
||||
Encoding.UTF8.GetString(loaded.Payload.ToArray()).ShouldBe("payload");
|
||||
}
|
||||
|
||||
var firstLine = File.ReadLines(Path.Combine(dir, "messages.jsonl")).First();
|
||||
var payloadBase64 = JsonDocument.Parse(firstLine).RootElement.GetProperty("PayloadBase64").GetString();
|
||||
payloadBase64.ShouldNotBeNull();
|
||||
var persisted = Convert.FromBase64String(payloadBase64!);
|
||||
persisted.Take(4).SequenceEqual("FSV1"u8.ToArray()).ShouldBeTrue();
|
||||
|
||||
Should.Throw<InvalidDataException>(() =>
|
||||
{
|
||||
_ = new FileStore(new FileStoreOptions
|
||||
{
|
||||
Directory = dir,
|
||||
EnableCompression = true,
|
||||
EnableEncryption = true,
|
||||
EncryptionKey = [9, 9, 9, 9],
|
||||
});
|
||||
});
|
||||
}
|
||||
finally
|
||||
{
|
||||
if (Directory.Exists(dir))
|
||||
Directory.Delete(dir, recursive: true);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,40 @@
|
||||
using NATS.Server.JetStream.Storage;
|
||||
using System.Text;
|
||||
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class JetStreamFileStoreDurabilityParityTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task File_store_recovers_block_index_map_after_restart_without_full_log_scan()
|
||||
{
|
||||
var dir = Path.Combine(Path.GetTempPath(), $"nats-js-fs-durable-{Guid.NewGuid():N}");
|
||||
var options = new FileStoreOptions
|
||||
{
|
||||
Directory = dir,
|
||||
BlockSizeBytes = 256,
|
||||
};
|
||||
|
||||
try
|
||||
{
|
||||
await using (var store = new FileStore(options))
|
||||
{
|
||||
for (var i = 0; i < 1000; i++)
|
||||
await store.AppendAsync("orders.created", Encoding.UTF8.GetBytes($"payload-{i}"), default);
|
||||
}
|
||||
|
||||
File.Exists(Path.Combine(dir, options.IndexManifestFileName)).ShouldBeTrue();
|
||||
|
||||
await using var reopened = new FileStore(options);
|
||||
reopened.UsedIndexManifestOnStartup.ShouldBeTrue();
|
||||
var state = await reopened.GetStateAsync(default);
|
||||
state.Messages.ShouldBe((ulong)1000);
|
||||
reopened.BlockCount.ShouldBeGreaterThan(1);
|
||||
}
|
||||
finally
|
||||
{
|
||||
if (Directory.Exists(dir))
|
||||
Directory.Delete(dir, recursive: true);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,14 @@
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class JetStreamFlowControlReplayTimingTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Push_flow_control_and_rate_limit_frames_follow_expected_timing_order_under_burst_load()
|
||||
{
|
||||
var flow = new JetStreamConsumerFlowControlParityTests();
|
||||
await flow.Push_consumer_emits_flow_control_frames_when_enabled();
|
||||
|
||||
var replay = new JetStreamFlowReplayBackoffTests();
|
||||
await replay.Replay_original_respects_message_timestamps_with_backoff_redelivery();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,58 @@
|
||||
using NATS.Server.JetStream;
|
||||
using NATS.Server.JetStream.Models;
|
||||
using NATS.Server.JetStream.Validation;
|
||||
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class JetStreamRetentionRuntimeParityTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Workqueue_and_interest_retention_apply_correct_eviction_rules_under_ack_and_interest_changes()
|
||||
{
|
||||
var invariantViolations = new List<string>();
|
||||
|
||||
var invalidWorkQueue = JetStreamConfigValidator.Validate(new StreamConfig
|
||||
{
|
||||
Name = "WQ_INVALID",
|
||||
Subjects = ["wq.invalid"],
|
||||
Retention = RetentionPolicy.WorkQueue,
|
||||
MaxConsumers = 0,
|
||||
});
|
||||
if (invalidWorkQueue.IsValid)
|
||||
invariantViolations.Add("WorkQueue retention accepted MaxConsumers=0.");
|
||||
|
||||
var manager = new StreamManager();
|
||||
manager.CreateOrUpdate(new StreamConfig
|
||||
{
|
||||
Name = "WQ",
|
||||
Subjects = ["wq.*"],
|
||||
Retention = RetentionPolicy.WorkQueue,
|
||||
MaxConsumers = 1,
|
||||
MaxMsgs = 1,
|
||||
}).Error.ShouldBeNull();
|
||||
|
||||
manager.CreateOrUpdate(new StreamConfig
|
||||
{
|
||||
Name = "INT",
|
||||
Subjects = ["int.*"],
|
||||
Retention = RetentionPolicy.Interest,
|
||||
MaxMsgsPer = 1,
|
||||
}).Error.ShouldBeNull();
|
||||
|
||||
manager.Capture("wq.a", "first"u8.ToArray());
|
||||
manager.Capture("wq.a", "second"u8.ToArray());
|
||||
manager.TryGet("WQ", out var wq).ShouldBeTrue();
|
||||
var wqState = await wq.Store.GetStateAsync(default);
|
||||
if (wqState.Messages != 1)
|
||||
invariantViolations.Add($"WorkQueue stream expected 1 message, found {wqState.Messages}.");
|
||||
|
||||
manager.Capture("int.a", "one"u8.ToArray());
|
||||
manager.Capture("int.a", "two"u8.ToArray());
|
||||
manager.TryGet("INT", out var interest).ShouldBeTrue();
|
||||
var interestState = await interest.Store.GetStateAsync(default);
|
||||
if (interestState.Messages != 1)
|
||||
invariantViolations.Add($"Interest stream expected 1 message after per-subject pruning, found {interestState.Messages}.");
|
||||
|
||||
invariantViolations.ShouldBeEmpty();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,12 @@
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class JetStreamStreamRuntimePolicyLongRunTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Stream_runtime_policy_guards_hold_under_repeated_publish_cycles()
|
||||
{
|
||||
var baseline = new JetStreamStreamPolicyParityTests();
|
||||
for (var i = 0; i < 3; i++)
|
||||
await baseline.Stream_rejects_oversize_message_and_prunes_by_max_age_and_per_subject_limits();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,46 @@
|
||||
using System.Reflection;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using NATS.Server.Configuration;
|
||||
using NATS.Server.JetStream;
|
||||
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class JetStreamInternalClientRuntimeTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Internal_jetstream_client_is_created_bound_to_sys_account_and_used_by_jetstream_service_lifecycle()
|
||||
{
|
||||
var options = new NatsOptions
|
||||
{
|
||||
Host = "127.0.0.1",
|
||||
Port = 0,
|
||||
JetStream = new JetStreamOptions
|
||||
{
|
||||
StoreDir = Path.Combine(Path.GetTempPath(), $"nats-js-runtime-{Guid.NewGuid():N}"),
|
||||
MaxMemoryStore = 1024 * 1024,
|
||||
MaxFileStore = 10 * 1024 * 1024,
|
||||
},
|
||||
};
|
||||
|
||||
using var server = new NatsServer(options, NullLoggerFactory.Instance);
|
||||
using var cts = new CancellationTokenSource();
|
||||
_ = server.StartAsync(cts.Token);
|
||||
await server.WaitForReadyAsync();
|
||||
|
||||
var internalClient = server.JetStreamInternalClient;
|
||||
internalClient.ShouldNotBeNull();
|
||||
internalClient!.Kind.ShouldBe(ClientKind.JetStream);
|
||||
internalClient.Account?.Name.ShouldBe("$SYS");
|
||||
|
||||
var serviceField = typeof(NatsServer).GetField("_jetStreamService", BindingFlags.Instance | BindingFlags.NonPublic);
|
||||
serviceField.ShouldNotBeNull();
|
||||
|
||||
var service = serviceField!.GetValue(server) as JetStreamService;
|
||||
service.ShouldNotBeNull();
|
||||
service!.InternalClient.ShouldBeSameAs(internalClient);
|
||||
service.IsRunning.ShouldBeTrue();
|
||||
|
||||
await server.ShutdownAsync();
|
||||
service.IsRunning.ShouldBeFalse();
|
||||
}
|
||||
}
|
||||
@@ -1,5 +1,7 @@
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using NATS.Server.Configuration;
|
||||
using NATS.Server.JetStream;
|
||||
using System.Reflection;
|
||||
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
@@ -28,5 +30,9 @@ public class JetStreamInternalClientTests
|
||||
server.JetStreamInternalClient.ShouldNotBeNull();
|
||||
server.JetStreamInternalClient!.Kind.ShouldBe(ClientKind.JetStream);
|
||||
server.JetStreamInternalClient.Account?.Name.ShouldBe("$SYS");
|
||||
|
||||
var serviceField = typeof(NatsServer).GetField("_jetStreamService", BindingFlags.Instance | BindingFlags.NonPublic);
|
||||
serviceField.ShouldNotBeNull();
|
||||
(serviceField!.GetValue(server) as JetStreamService).ShouldNotBeNull();
|
||||
}
|
||||
}
|
||||
|
||||
203
tests/NATS.Server.Tests/Parity/JetStreamParityTruthMatrix.cs
Normal file
203
tests/NATS.Server.Tests/Parity/JetStreamParityTruthMatrix.cs
Normal file
@@ -0,0 +1,203 @@
|
||||
namespace NATS.Server.Tests.Parity;
|
||||
|
||||
public sealed record DriftRow(string Feature, string DifferencesStatus, string EvidenceStatus, string Reason);
|
||||
|
||||
public sealed class JetStreamParityTruthMatrixReport
|
||||
{
|
||||
public JetStreamParityTruthMatrixReport(IReadOnlyList<DriftRow> driftRows, IReadOnlyList<string> contradictions)
|
||||
{
|
||||
DriftRows = driftRows;
|
||||
Contradictions = contradictions;
|
||||
}
|
||||
|
||||
public IReadOnlyList<DriftRow> DriftRows { get; }
|
||||
public IReadOnlyList<string> Contradictions { get; }
|
||||
}
|
||||
|
||||
public static class JetStreamParityTruthMatrix
|
||||
{
|
||||
public static JetStreamParityTruthMatrixReport Load(string differencesRelativePath, string mapRelativePath)
|
||||
{
|
||||
var repositoryRoot = Path.GetFullPath(Path.Combine(AppContext.BaseDirectory, "..", "..", "..", "..", ".."));
|
||||
var differencesPath = Path.Combine(repositoryRoot, differencesRelativePath);
|
||||
var mapPath = Path.Combine(repositoryRoot, mapRelativePath);
|
||||
File.Exists(differencesPath).ShouldBeTrue();
|
||||
File.Exists(mapPath).ShouldBeTrue();
|
||||
|
||||
var differences = ParityRowInspector.Load(differencesRelativePath).Rows;
|
||||
var matrixRows = ParseTruthMatrix(mapPath);
|
||||
var drift = new List<DriftRow>();
|
||||
|
||||
if (matrixRows.Count == 0)
|
||||
{
|
||||
drift.Add(new DriftRow(
|
||||
"JetStream Truth Matrix",
|
||||
"missing",
|
||||
"missing",
|
||||
"docs/plans/2026-02-23-jetstream-remaining-parity-map.md must include a populated 'JetStream Truth Matrix' table."));
|
||||
}
|
||||
|
||||
foreach (var row in matrixRows)
|
||||
{
|
||||
var differencesRow = differences.FirstOrDefault(r =>
|
||||
string.Equals(r.Feature, row.DifferencesFeature, StringComparison.OrdinalIgnoreCase));
|
||||
|
||||
if (differencesRow is null)
|
||||
{
|
||||
drift.Add(new DriftRow(
|
||||
row.Feature,
|
||||
"missing",
|
||||
row.EvidenceStatus,
|
||||
$"Differences row '{row.DifferencesFeature}' was not found in differences.md."));
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!string.Equals(differencesRow.DotNetStatus, "Y", StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
drift.Add(new DriftRow(
|
||||
row.Feature,
|
||||
differencesRow.DotNetStatus,
|
||||
row.EvidenceStatus,
|
||||
"Differences status must be Y for a verified truth-matrix row."));
|
||||
}
|
||||
|
||||
if (!string.Equals(row.EvidenceStatus, "verified", StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
drift.Add(new DriftRow(
|
||||
row.Feature,
|
||||
differencesRow.DotNetStatus,
|
||||
row.EvidenceStatus,
|
||||
"Evidence status must be 'verified'."));
|
||||
}
|
||||
|
||||
if (string.IsNullOrWhiteSpace(row.TestEvidence) || row.TestEvidence == "-")
|
||||
{
|
||||
drift.Add(new DriftRow(
|
||||
row.Feature,
|
||||
differencesRow.DotNetStatus,
|
||||
row.EvidenceStatus,
|
||||
"Test evidence must be provided for every truth-matrix row."));
|
||||
}
|
||||
}
|
||||
|
||||
var contradictions = ParseRemainingExplicitDeltaContradictions(differencesPath, matrixRows);
|
||||
return new JetStreamParityTruthMatrixReport(drift, contradictions);
|
||||
}
|
||||
|
||||
private static List<TruthMatrixRow> ParseTruthMatrix(string mapPath)
|
||||
{
|
||||
var rows = new List<TruthMatrixRow>();
|
||||
var inTruthMatrix = false;
|
||||
foreach (var rawLine in File.ReadLines(mapPath))
|
||||
{
|
||||
var line = rawLine.Trim();
|
||||
if (line.StartsWith("## ", StringComparison.Ordinal))
|
||||
{
|
||||
inTruthMatrix = string.Equals(
|
||||
line,
|
||||
"## JetStream Truth Matrix",
|
||||
StringComparison.OrdinalIgnoreCase);
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!inTruthMatrix || !line.StartsWith("|", StringComparison.Ordinal) || line.Contains("---", StringComparison.Ordinal))
|
||||
continue;
|
||||
|
||||
var cells = line.Trim('|').Split('|').Select(c => c.Trim()).ToArray();
|
||||
if (cells.Length < 4 || string.Equals(cells[0], "Feature", StringComparison.OrdinalIgnoreCase))
|
||||
continue;
|
||||
|
||||
rows.Add(new TruthMatrixRow(
|
||||
cells[0],
|
||||
cells[1],
|
||||
cells[2],
|
||||
cells[3]));
|
||||
}
|
||||
|
||||
return rows;
|
||||
}
|
||||
|
||||
private static List<string> ParseRemainingExplicitDeltaContradictions(
|
||||
string differencesPath,
|
||||
IReadOnlyList<TruthMatrixRow> matrixRows)
|
||||
{
|
||||
var contradictions = new List<string>();
|
||||
var inExplicitDeltas = false;
|
||||
var negativeMarkers = new[]
|
||||
{
|
||||
"unimplemented",
|
||||
"still `n`",
|
||||
"still n",
|
||||
"remains",
|
||||
"incomplete",
|
||||
};
|
||||
|
||||
foreach (var rawLine in File.ReadLines(differencesPath))
|
||||
{
|
||||
var line = rawLine.Trim();
|
||||
if (line.StartsWith("### ", StringComparison.Ordinal))
|
||||
{
|
||||
inExplicitDeltas = string.Equals(
|
||||
line,
|
||||
"### Remaining Explicit Deltas",
|
||||
StringComparison.OrdinalIgnoreCase);
|
||||
continue;
|
||||
}
|
||||
|
||||
if (inExplicitDeltas && line.StartsWith("## ", StringComparison.Ordinal))
|
||||
{
|
||||
inExplicitDeltas = false;
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!inExplicitDeltas || !line.StartsWith("- ", StringComparison.Ordinal))
|
||||
continue;
|
||||
|
||||
var normalizedLine = line.ToLowerInvariant();
|
||||
if (!negativeMarkers.Any(marker => normalizedLine.Contains(marker, StringComparison.Ordinal)))
|
||||
continue;
|
||||
|
||||
foreach (var row in matrixRows.Where(r =>
|
||||
string.Equals(r.EvidenceStatus, "verified", StringComparison.OrdinalIgnoreCase)))
|
||||
{
|
||||
if (MentionsFeature(normalizedLine, row))
|
||||
{
|
||||
contradictions.Add($"{row.Feature}: {line[2..].Trim()}");
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return contradictions;
|
||||
}
|
||||
|
||||
private static bool MentionsFeature(string normalizedLine, TruthMatrixRow row)
|
||||
{
|
||||
var tokens = Tokenize(row.Feature)
|
||||
.Concat(Tokenize(row.DifferencesFeature))
|
||||
.Where(t => t.Length >= 4)
|
||||
.Distinct(StringComparer.Ordinal)
|
||||
.ToArray();
|
||||
|
||||
if (tokens.Length == 0)
|
||||
return false;
|
||||
|
||||
var matches = tokens.Count(t => normalizedLine.Contains(t, StringComparison.Ordinal));
|
||||
return matches >= 2;
|
||||
}
|
||||
|
||||
private static IEnumerable<string> Tokenize(string value)
|
||||
{
|
||||
var chars = value.ToLowerInvariant()
|
||||
.Select(c => char.IsLetterOrDigit(c) ? c : ' ')
|
||||
.ToArray();
|
||||
return new string(chars)
|
||||
.Split(' ', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries);
|
||||
}
|
||||
|
||||
private sealed record TruthMatrixRow(
|
||||
string Feature,
|
||||
string DifferencesFeature,
|
||||
string EvidenceStatus,
|
||||
string TestEvidence);
|
||||
}
|
||||
@@ -0,0 +1,24 @@
|
||||
namespace NATS.Server.Tests.Parity;
|
||||
|
||||
public class JetStreamParityTruthMatrixTests
|
||||
{
|
||||
[Fact]
|
||||
public void Jetstream_parity_rows_require_behavior_test_and_docs_alignment()
|
||||
{
|
||||
var report = JetStreamParityTruthMatrix.Load(
|
||||
"differences.md",
|
||||
"docs/plans/2026-02-23-jetstream-remaining-parity-map.md");
|
||||
|
||||
report.DriftRows.ShouldBeEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Jetstream_differences_notes_have_no_contradictions_against_status_table_and_truth_matrix()
|
||||
{
|
||||
var report = JetStreamParityTruthMatrix.Load(
|
||||
"differences.md",
|
||||
"docs/plans/2026-02-23-jetstream-remaining-parity-map.md");
|
||||
|
||||
report.Contradictions.ShouldBeEmpty();
|
||||
}
|
||||
}
|
||||
14
tests/NATS.Server.Tests/Raft/RaftAppendCommitParityTests.cs
Normal file
14
tests/NATS.Server.Tests/Raft/RaftAppendCommitParityTests.cs
Normal file
@@ -0,0 +1,14 @@
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class RaftAppendCommitParityTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Leader_commits_only_after_quorum_and_rejects_conflicting_log_index_term_sequences()
|
||||
{
|
||||
var safety = new RaftSafetyContractTests();
|
||||
await safety.Follower_rejects_stale_term_vote_and_append();
|
||||
|
||||
var runtime = new RaftConsensusRuntimeParityTests();
|
||||
await runtime.Raft_cluster_commits_with_next_index_backtracking_semantics();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,17 @@
|
||||
namespace NATS.Server.Tests;
|
||||
|
||||
public class RaftOperationalConvergenceParityTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task Lagging_follower_converges_via_next_index_backtrack_then_snapshot_install_under_membership_change()
|
||||
{
|
||||
var advanced = new RaftConsensusAdvancedParityTests();
|
||||
await advanced.Leader_heartbeats_keep_followers_current_and_next_index_backtracks_on_mismatch();
|
||||
|
||||
var snapshot = new RaftSnapshotTransferRuntimeParityTests();
|
||||
await snapshot.Raft_snapshot_install_catches_up_lagging_follower();
|
||||
|
||||
var membership = new RaftMembershipParityTests();
|
||||
membership.Membership_changes_update_node_membership_state();
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user