Joseph Doherty
d6b2f24c3f
One cross-client conformance pass; also closes first-cycle CLI-08. CLI-37: an MxStatusProxy entry is a failure iff `category != MX_STATUS_CATEGORY_OK`. The proto contract has always said so — `success` is the raw 16-bit COM member carried verbatim for diagnostics, not a boolean — but four clients branched on `success` alone and .NET required both, so the same gateway reply produced opposite verdicts per language. An absent entry stays success; a present entry with an UNSPECIFIED category is a failure, because the worker always maps a category and an unmapped one is not proven OK. CLI-38: a reply fails on HRESULT iff `hresult` is present and negative, so positive COM success codes such as S_FALSE (1) pass. .NET/Go/Java used `!= 0`, which errored on a parity-preserving S_FALSE that Python and Rust accepted. This makes the existing ClientLibrariesDesign.md claim true rather than rewriting the doc to describe the divergence. Four shared fixtures pin both rules cross-client, and each language suite also carries a table test for the two edges a fixture cannot express (absent entry, UNSPECIFIED category). A Java test fake that built a status with a bare `setSuccess(1)` and no category is fixed — under the category rule that reply was never a success.
18 lines
788 B
Go
18 lines
788 B
Go
package mxgateway
|
|
|
|
import (
|
|
pb "gitea.dohertylan.com/dohertj2/mxaccessgw/clients/go/internal/generated"
|
|
)
|
|
|
|
// StatusSucceeded reports whether an MXSTATUS_PROXY entry represents success.
|
|
//
|
|
// The wire contract makes Category authoritative: an entry succeeds only when
|
|
// its category is MX_STATUS_CATEGORY_OK. The Success member mirrors the raw
|
|
// 16-bit COM value verbatim for diagnostics and is not a boolean, so it takes
|
|
// no part in the verdict. A nil entry is success (nothing was reported); a
|
|
// present entry with an unspecified category is a failure, because the worker
|
|
// always maps a category and an unmapped one is not proven OK.
|
|
func StatusSucceeded(status *MxStatusProxy) bool {
|
|
return status == nil || status.GetCategory() == pb.MxStatusCategory_MX_STATUS_CATEGORY_OK
|
|
}
|