mxaccessgw

T

Joseph Doherty 1d9e3afadd Resolve Server-002, -004, -005, -006 code-review findings

Server-002: the gateway never terminated leftover MxGateway.Worker.exe
processes at startup, contradicting gateway.md and CLAUDE.md. Added
IRunningProcessInspector/SystemRunningProcessInspector, OrphanWorkerTerminator,
and OrphanWorkerCleanupHostedService (best-effort, runs before sessions are
accepted); updated gateway.md to describe the implemented behavior.

Server-004: API-key scopes were persisted verbatim with no validation. Added
GatewayScopes.All/IsKnown; the CLI parser and dashboard create path now
reject unknown scope strings.

Server-005: a non-SqlException/InvalidOperationException fault on the initial
Galaxy hierarchy load faulted the BackgroundService. ExecuteAsync now catches
all non-cancellation exceptions on first load and RefreshCoreAsync broadens
its catch so the cache records Stale/Unavailable instead.

Server-006: OpenSessionAsync incremented the open-sessions gauge before
alarm auto-subscribe; an auto-subscribe failure leaked the gauge. The catch
path now calls SessionRemoved() when the gauge was incremented.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-18 21:31:10 -04:00

clients

Resolve Client.Go-001 code-review finding

2026-05-18 20:46:12 -04:00

code-reviews

Resolve Server-002, -004, -005, -006 code-review findings

2026-05-18 21:31:10 -04:00

docs

Resolve IntegrationTests-001 and IntegrationTests-002 code-review findings

2026-05-18 20:46:09 -04:00

lib

A.2: replace AlarmClientConsumer with wnwrap-based polling consumer