Joseph Doherty
f9fbd4ee0d
R07 U7: Driver.Cli.Common gains RunCancellableAsync (moved up from AbLegacy) and CreateChangeLineWriter (one lock-serialised line per change; a failing console write is logged and swallowed so it cannot fault the poll loop). AbCip probe/read/write print Cancelled. on Ctrl-C instead of a stack trace, and AbCip subscribe uses the shared writer. SnapshotFormatter renders arrays/lists as [a, b, c] instead of System.Int32[]. Refs #747 Claude-Session: https://claude.ai/code/session_01Ub9hGmYLQvn9XETzw7CMsT
75 lines
3.2 KiB
C#
75 lines
3.2 KiB
C#
using CliFx.Attributes;
|
|
using CliFx.Infrastructure;
|
|
using ZB.MOM.WW.OtOpcUa.Driver.Cli.Common;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.AbCip.Cli.Commands;
|
|
|
|
/// <summary>
|
|
/// Read one Logix tag by symbolic path. Operator specifies <c>--tag</c> + <c>--type</c>;
|
|
/// the CLI synthesises a one-tag driver config, reads once, prints the snapshot, shuts
|
|
/// down. UDT / Structure reads are out of scope here — those need the member layout
|
|
/// declared, which belongs in a real driver config.
|
|
/// </summary>
|
|
[Command("read", Description = "Read a single Logix tag by symbolic path.")]
|
|
public sealed class ReadCommand : AbCipCommandBase
|
|
{
|
|
/// <summary>Gets the tag path to read.</summary>
|
|
[CommandOption("tag", 't', Description =
|
|
"Logix symbolic path. Controller scope: 'Motor01_Speed'. Program scope: " +
|
|
"'Program:Main.Motor01_Speed'. Array element: 'Recipe[3]'. UDT member: " +
|
|
"'Motor01.Speed'.", IsRequired = true)]
|
|
public string TagPath { get; init; } = default!;
|
|
|
|
/// <summary>Gets the data type to read as.</summary>
|
|
[CommandOption("type", Description =
|
|
"Bool / SInt / Int / DInt / LInt / USInt / UInt / UDInt / ULInt / Real / LReal / " +
|
|
"String / Dt (default DInt). UDT / composite types are not supported here — use a full driver config.")]
|
|
public AbCipDataType DataType { get; init; } = AbCipDataType.DInt;
|
|
|
|
/// <inheritdoc />
|
|
public override async ValueTask ExecuteAsync(IConsole console)
|
|
{
|
|
ConfigureLogging();
|
|
RejectStructure(DataType);
|
|
var ct = console.RegisterCancellationHandler();
|
|
|
|
var tagName = SynthesiseTagName(TagPath, DataType);
|
|
var tag = new AbCipTagDefinition(
|
|
Name: tagName,
|
|
DeviceHostAddress: Gateway,
|
|
TagPath: TagPath,
|
|
DataType: DataType,
|
|
Writable: false);
|
|
var options = BuildOptions([tag]);
|
|
|
|
await using var driver = new AbCipDriver(options, DriverInstanceId);
|
|
try
|
|
{
|
|
// Ctrl-C prints "Cancelled." instead of an OperationCanceledException stack trace (review 07 U7).
|
|
await RunCancellableAsync(console, ct, async () =>
|
|
{
|
|
await driver.InitializeAsync("{}", ct);
|
|
var snapshot = await driver.ReadAsync([tagName], ct);
|
|
await console.Output.WriteLineAsync(SnapshotFormatter.Format(TagPath, snapshot[0]));
|
|
});
|
|
}
|
|
finally
|
|
{
|
|
await driver.ShutdownAsync(CancellationToken.None);
|
|
// Flush Serilog before process exit so buffered log output emitted during
|
|
// driver shutdown is not lost.
|
|
FlushLogging();
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tag-name key the driver uses internally. The path + type pair is already unique
|
|
/// so we use them verbatim — keeps tag-level diagnostics readable without mangling.
|
|
/// </summary>
|
|
/// <param name="tagPath">The symbolic tag path.</param>
|
|
/// <param name="type">The data type.</param>
|
|
/// <returns>A synthetic tag name combining the tag path and data type.</returns>
|
|
internal static string SynthesiseTagName(string tagPath, AbCipDataType type)
|
|
=> $"{tagPath}:{type}";
|
|
}
|