dohertj2/lmxopcua
1
0
Fork 0
Code Issues 32 Pull Requests Actions Packages Projects Releases Wiki Activity

Review remediation: Lane K — Clients, CLI, transport (sonnet; review opus) #747

New Issue
Open
opened 2026-10-22 06:05:20 -04:00 by dohertj2 · 0 comments
dohertj2 commented 2026-10-22 06:05:20 -04:00
Owner
Copy Link
Copy Source

From the 2026-10-21 Fable system review. Findings R0x:ID refer to docs/reviews/2026-10-21/0x-*.md (location, evidence, failure scenario, fix recipe). Plan: docs/superpowers/plans/2026-10-22-review-remediation.md.

Lane K — Clients, CLI, transport (sonnet; review opus)

Owns: src/Client/**, src/Drivers/Cli/Driver.Cli.Common + the AbCip/AbLegacy CLI command files (after the Wave 2 merge), Driver.Ab.Transport/**.

  • Client:
    • release the raw CP (R08:1.4);
    • RemoveSubscription (1.5);
    • align AggregateType with AggregateFamilies.Served (2.3);
    • lazy HasChildren (3.6);
    • NodeId dictionary in the UI (3.6);
    • failover under _subscriptionLock, and ConnectAsync refusing when already connected (4.5).
  • CLI fixes (R07:U7).
  • Pooled buffers in EncapsulationClient/CipWriter/LogixTagClient + Modbus transports via ArrayPool (R07:L5). Benchmark-gated: no regression in Ab.Transport.Tests timings.
From the 2026-10-21 Fable system review. Findings `R0x:ID` refer to `docs/reviews/2026-10-21/0x-*.md` (location, evidence, failure scenario, fix recipe). Plan: `docs/superpowers/plans/2026-10-22-review-remediation.md`. ### Lane K — Clients, CLI, transport (sonnet; review opus) **Owns:** `src/Client/**`, `src/Drivers/Cli/Driver.Cli.Common` + the AbCip/AbLegacy CLI command files (after the Wave 2 merge), `Driver.Ab.Transport/**`. - Client: - release the raw CP (`R08:1.4`); - `RemoveSubscription` (`1.5`); - align `AggregateType` with `AggregateFamilies.Served` (`2.3`); - lazy HasChildren (`3.6`); - NodeId dictionary in the UI (`3.6`); - failover under `_subscriptionLock`, and `ConnectAsync` refusing when already connected (`4.5`). - CLI fixes (`R07:U7`). - Pooled buffers in `EncapsulationClient`/`CipWriter`/`LogixTagClient` + Modbus transports via `ArrayPool` (`R07:L5`). Benchmark-gated: no regression in `Ab.Transport.Tests` timings.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#747
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?