28 lines
4.9 KiB
Markdown
28 lines
4.9 KiB
Markdown
# Alerts field and action acceptance
|
|
|
|
Actual `Alerts.razor` over fabricated in-process events and a rejecting-by-default local operation proxy. No fleet commands, historian writes, or external actor operations were performed. This closes the remaining Alerts portion of OT13; it does not certify the final combined suite.
|
|
|
|
## Changes and preserved contracts
|
|
|
|
Page-only monotonically assigned row keys retain the original `AlarmTransitionEvent` payload and stop prepended transitions from reassigning the focused duration input to a different alarm. Each repeated transition gets unique control/label/error IDs and contextual alarm-row names. Timed-shelve drafts remain keyed by alarm condition, preserving the existing choice across its repeated transitions. A native form enforces required positive integer minutes and retains invalid strings for correction; server validation also rejects invalid values. Existing default five minutes, UTC deadline captured before authentication awaits, fresh username fallback, null comment, 15-second request cancellation and eight-second transient outcome remain.
|
|
|
|
A page-wide entry guard prevents overlapping operations even from an already captured rendered callback; all action controls show the same busy state. The existing DriverOperator policy is rechecked immediately before dispatch. Disposal prevents late UI results without pretending to cancel already dispatched operations. A single short live request outcome is separated from escaped full diagnostic details; individual transition messages and result details are outside live regions. No persistent command history was added. Pause/resume, coalescing, 200-entry capacity, clear semantics and wire payloads remain.
|
|
|
|
## Actual verification
|
|
|
|
- `baseline-red.log`: three valid failures before production edits (duplicate duration associations, cross-row pending dispatch, permission revocation). Initial test-authoring compile errors are not behavioral failures.
|
|
- `alerts-final5.trx` / `final-managed.log`: **22 passed, zero failed/skipped**, including 11 new cases and existing live-tail tests. All discovery/execution used `infra/tools/ui-consistency/with_private_sql.py` and the owned disposable loopback SQL fixture. The SQL credential state remains private and is absent from these artifacts.
|
|
- `before-native.json`: Chromium incomplete exponent had `value=''`, `badInput=true`, and the observed fake counter was zero; this is explicitly **not** evidence of native invalid dispatch. The actual focus red is decisive: after a new event prepended, the same focused input belonged to alarm-b instead of alarm-a.
|
|
- `after-native.json`: four contexts (1440/390 at 100%, actual 200% zoom yielding 720/195 CSS pixels and DPR2) passed all ten checks each: retained focused condition, distinct associations, incomplete input rejection, valid UTC timed request, page-wide pending state, one pending request, escaped complete exception, short live outcome, no document overflow and no page errors.
|
|
- First native matrix (`first-native-matrix.json`) incorrectly read the fixture observer output before its render and failed two counter checks. Source was unchanged; one confirmation waits for observer rendering and records the actual count/deadline. First raw matrix/log are retained.
|
|
- Earlier managed attempts retain their failures: cached retired bUnit event IDs required capturing the actual render-local callback; synchronous render assertions required awaiting the event/render; an initial blocking test correction was rejected by xUnit1031 and replaced with async. No production assertion was removed. Existing Script pause/cap checks remain, with dispatcher-atomic click plus `WaitForAssertion`.
|
|
|
|
Commands (cwd `/Users/dohertj2/Desktop/OtOpcUa`):
|
|
|
|
```sh
|
|
python3 infra/tools/ui-consistency/with_private_sql.py --state "$TASK_PRIVATE_SQL_STATE" -- dotnet test tests/Server/ZB.MOM.WW.OtOpcUa.AdminUI.Tests/ZB.MOM.WW.OtOpcUa.AdminUI.Tests.csproj -c Release --no-restore --filter 'FullyQualifiedName~AlarmOperationFormTests|FullyQualifiedName~LiveTailPageTests|FullyQualifiedName~LiveTailTests' --logger 'trx;LogFileName=alerts-final5.trx' --results-directory docs/ui-consistency/evidence/ot13-alert-operations
|
|
python3 infra/tools/ui-consistency/check_alarm_operations.py
|
|
```
|
|
|
|
The browser script reads the owned host URL from `/tmp/ot13-alerts-after-host.log`. Main retained canary source provides only synthetic local feeds/operations. `actual-surface-720.png` and `actual-surface-195.png` supersede the earlier Playwright real-zoom framing: direct CDP `Page.captureScreenshot` with `captureBeyondViewport=false` captures the actual surface at DPR2, with exact DOM geometry in `actual-surface-geometry.json`. The195px artifact was visually inspected; escaped exception text wraps within the local detail panel. No VoiceOver testing was performed, per user instruction. Rollback is a scoped revert of this page/test change; no schema or backend contract changed, and no deployment occurred.
|