Client.Shared-001: lowered the OnAlarmEventNotification early-return guard from <6 to <1; per-index field guards already default missing fields safely. Client.Shared-002: GetRedundancyInfoAsync replaces unguarded unboxing casts with StatusCode.IsGood + Convert.ToInt32/ToByte, defaulting on bad reads. Client.Shared-007: alarm fallback Task.Run guards on ReferenceEquals(session, _session) and drops stale alarms on ObjectDisposedException after failover. Client.Shared-008: WriteValueAsync rejects type inference from bad/null reads; ValueConverter wraps parse failures in a descriptive FormatException. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
139 lines
3.6 KiB
C#
139 lines
3.6 KiB
C#
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Client.Shared.Helpers;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Client.Shared.Tests.Helpers;
|
|
|
|
public class ValueConverterTests
|
|
{
|
|
[Fact]
|
|
public void ConvertValue_Bool_True()
|
|
{
|
|
ValueConverter.ConvertValue("True", true).ShouldBe(true);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_Bool_False()
|
|
{
|
|
ValueConverter.ConvertValue("False", false).ShouldBe(false);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_Byte()
|
|
{
|
|
ValueConverter.ConvertValue("255", (byte)0).ShouldBe((byte)255);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_Short()
|
|
{
|
|
ValueConverter.ConvertValue("-100", (short)0).ShouldBe((short)-100);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_UShort()
|
|
{
|
|
ValueConverter.ConvertValue("65535", (ushort)0).ShouldBe((ushort)65535);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_Int()
|
|
{
|
|
ValueConverter.ConvertValue("42", 0).ShouldBe(42);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_UInt()
|
|
{
|
|
ValueConverter.ConvertValue("42", 0u).ShouldBe(42u);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_Long()
|
|
{
|
|
ValueConverter.ConvertValue("9999999999", 0L).ShouldBe(9999999999L);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_ULong()
|
|
{
|
|
ValueConverter.ConvertValue("18446744073709551615", 0UL).ShouldBe(ulong.MaxValue);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_Float()
|
|
{
|
|
ValueConverter.ConvertValue("3.14", 0f).ShouldBe(3.14f);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_Double()
|
|
{
|
|
ValueConverter.ConvertValue("3.14159", 0.0).ShouldBe(3.14159);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_String_WhenCurrentIsString()
|
|
{
|
|
ValueConverter.ConvertValue("hello", "").ShouldBe("hello");
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_String_WhenCurrentIsNull()
|
|
{
|
|
ValueConverter.ConvertValue("hello", null).ShouldBe("hello");
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_String_WhenCurrentIsUnknownType()
|
|
{
|
|
ValueConverter.ConvertValue("hello", new object()).ShouldBe("hello");
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_InvalidBool_Throws()
|
|
{
|
|
Should.Throw<FormatException>(() => ValueConverter.ConvertValue("notabool", true));
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_InvalidInt_ThrowsWithDescription()
|
|
{
|
|
var ex = Should.Throw<FormatException>(() => ValueConverter.ConvertValue("notanint", 0));
|
|
ex.Message.ShouldContain("Int32");
|
|
ex.Message.ShouldContain("notanint");
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_Overflow_ThrowsFormatException()
|
|
{
|
|
// OverflowException is now wrapped in a descriptive FormatException
|
|
var ex = Should.Throw<FormatException>(() => ValueConverter.ConvertValue("256", (byte)0));
|
|
ex.InnerException.ShouldBeOfType<OverflowException>();
|
|
}
|
|
|
|
// --- Client.Shared-008: Boolean aliases ---
|
|
|
|
[Theory]
|
|
[InlineData("1", true)]
|
|
[InlineData("0", false)]
|
|
[InlineData("yes", true)]
|
|
[InlineData("no", false)]
|
|
[InlineData("YES", true)]
|
|
[InlineData("NO", false)]
|
|
[InlineData("true", true)]
|
|
[InlineData("false", false)]
|
|
[InlineData("True", true)]
|
|
[InlineData("False", false)]
|
|
public void ConvertValue_Bool_AcceptsNumericAndWordAliases(string input, bool expected)
|
|
{
|
|
ValueConverter.ConvertValue(input, true).ShouldBe(expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void ConvertValue_InvalidBool_ThrowsDescriptiveFormatException()
|
|
{
|
|
var ex = Should.Throw<FormatException>(() => ValueConverter.ConvertValue("maybe", false));
|
|
ex.Message.ShouldContain("Boolean");
|
|
}
|
|
} |